From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965154AbdGTK4d (ORCPT <rfc822;w@1wt.eu>);
        Thu, 20 Jul 2017 06:56:33 -0400
Received: from regular1.263xmail.com ([211.150.99.130]:50731 "EHLO
        regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S965118AbdGTK4b (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 20 Jul 2017 06:56:31 -0400
X-263anti-spam: KSV:0;BIG:0;
X-MAIL-GRAY: 0
X-MAIL-DELIVERY: 1
X-KSVirus-check: 0
X-ADDR-CHECKED4: 1
X-ABS-CHECKED: 1
X-SKE-CHECKED: 1
X-ANTISPAM-LEVEL: 2
X-RL-SENDER: jeffy.chen@rock-chips.com
X-FST-TO: oneukum@suse.com
X-SENDER-IP: 103.29.142.67
X-LOGIN-NAME: jeffy.chen@rock-chips.com
X-UNIQUE-TAG: <7dedfae29bff91cf62cf67cc4847363d>
X-ATTACHMENT-NUM: 0
X-DNS-TYPE: 0
Message-ID: <59708C48.3020500@rock-chips.com>
Date: Thu, 20 Jul 2017 18:56:08 +0800
From: jeffy <jeffy.chen@rock-chips.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0
MIME-Version: 1.0
To: Oliver Neukum <oneukum@suse.com>, linux-kernel@vger.kernel.org
CC: briannorris@chromium.org, dianders@chromium.org,
        Johan Hedberg <johan.hedberg@gmail.com>, xiyou.wangcong@gmail.com,
        Marcel Holtmann <marcel@holtmann.org>,
        Gustavo Padovan <gustavo@padovan.org>, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v5] Bluetooth: btusb: Fix memory leak in play_deferred
References: <1500511321-16092-1-git-send-email-jeffy.chen@rock-chips.com> <1500541861.10409.2.camel@suse.com>
In-Reply-To: <1500541861.10409.2.camel@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Oliver,

On 07/20/2017 05:11 PM, Oliver Neukum wrote:
>> >+		if (err < 0) {
>> >+			if (err != -EPERM && err != -ENODEV)
>> >+				BT_ERR("%s urb %p submission failed (%d)",
>> >+				       data->hdev->name, urb, -err);
>> >+			kfree(urb->setup_packet);
>> >+			usb_unanchor_urb(urb);
>> >+			usb_free_urb(urb);
>> >  			break;
>> >+		}
>> >
>> >  		data->tx_in_flight++;
>> >+		usb_free_urb(urb);
>> >+	}
>> >+
>> >+	/* Cleanup the rest deferred urbs. */
>> >+	while ((urb = usb_get_from_anchor(&data->deferred))) {
>> >+		BT_ERR("%s urb %p submission failed (%d)",
> This looks very good, except for this message, which is incorrect.
>
hmm, since we already print error log when submission failed before, 
i'll remove this, thanks.