mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "KAMEZAWA Hiroyuki" <kamezawa.hiroyu@jp.fujitsu.com>
To: "Ryo Tsuruta" <ryov@valinux.co.jp>
Cc: kamezawa.hiroyu@jp.fujitsu.com, xen-devel@lists.xensource.com,
	containers@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, dm-devel@redhat.com,
	agk@redhat.com
Subject: Re: [Xen-devel] Re: [PATCH 7/9] blkio-cgroup-v9: Page tracking hooks
Date: Thu, 23 Jul 2009 21:02:13 +0900 (JST)	[thread overview]
Message-ID: <5971c26b399a97f51dd10ea497617733.squirrel@webmail-b.css.fujitsu.com> (raw)
In-Reply-To: <20090723.190253.226783703.ryov@valinux.co.jp>

Ryo Tsuruta wrote:
> KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:

>> > dm-ioband gives high priority to I/O for swap-out by checking whether
>> > PG_swapcache flag is set on the I/O page, regardless of the assigned
>> > I/O bandwidth, and the bandwidth consumed for swap-out is charged to
>> > the owner of the pages as a debt.
>> > How about this approach?
>>
>> I don't think it's reasonable. Why I/O device, scheduler should know
>> about
>> such mm-related information ? I think layering is wrong.
>
> I think that urgent I/O requests such as swap-out should be notified
> by setting a special flag in the struct bio, but there is no such
> mechanism at this time. That is why dm-ioband uses this approach.
>
>> And your approatch cannot be a workaround.
>>
>> In follwing _typical_ case,
>>
>>   - A process does small logging to /var/log/mylog, once in a sec.
>>     but it uses some amount of cold memory or shmem.
>>
>> This process's logging will be delayed _unexpectedly_ by some buggy
>> process
>> which does memory leak.
>
> Do you mean that the delay in logging is caused since the small process
> is swapped out unexpectedly by the buggy processes?
I don't write "small process", "small logging".
Buggy process does swap-out and cosumes someone else's bandwidth, then,
loggind will be delayed. Important here is throttle bandwidth consumed by
buggy prorcess, not other's.

> How about using memory cgroup to prevent the small process from swap-out?
It never be help if memcg is not configured.

My point is "don't allow anyone to use bandwidth of others."
Considering job isolation, a thread who requests swap-out should be charged
against bandwidth.

Thanks,
-Kame




  reply	other threads:[~2009-07-23 12:02 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-21 14:09 [PATCH 1/9] I/O bandwidth controller and BIO tracking Ryo Tsuruta
2009-07-21 14:10 ` [PATCH 2/9] dm-ioband-1.12.1: All-in-one patch Ryo Tsuruta
2009-07-21 14:12   ` [PATCH 3/9] blkio-cgroup-v9: The new page_cgroup framework Ryo Tsuruta
2009-07-21 14:13     ` [PATCH 4/9] blkio-cgroup-v9: Refactoring io-context initialization Ryo Tsuruta
2009-07-21 14:14       ` [PATCH 5/9] blkio-cgroup-v9: The body of blkio-cgroup Ryo Tsuruta
2009-07-21 14:15         ` [PATCH 6/9] blkio-cgroup-v9: The document " Ryo Tsuruta
2009-07-21 14:23           ` [PATCH 7/9] blkio-cgroup-v9: Page tracking hooks Ryo Tsuruta
2009-07-21 14:24             ` [PATCH 8/9] blkio-cgroup-v9: Fast page tracking Ryo Tsuruta
2009-07-21 14:24               ` [PATCH 9/9] blkio-cgroup-v9: Add a cgroup support to dm-ioband Ryo Tsuruta
2009-07-22  2:17             ` [PATCH 7/9] blkio-cgroup-v9: Page tracking hooks KAMEZAWA Hiroyuki
2009-07-22  9:40               ` Ryo Tsuruta
2009-07-23  0:18                 ` KAMEZAWA Hiroyuki
2009-07-23  6:38                   ` [Xen-devel] " Ryo Tsuruta
2009-07-23  7:49                     ` KAMEZAWA Hiroyuki
2009-07-23 10:02                       ` Ryo Tsuruta
2009-07-23 12:02                         ` KAMEZAWA Hiroyuki [this message]
2009-07-24  5:44                           ` Ryo Tsuruta
2009-07-24  6:19                             ` KAMEZAWA Hiroyuki
2009-07-24  8:48                               ` Ryo Tsuruta
2009-07-22  2:11         ` [PATCH 5/9] blkio-cgroup-v9: The body of blkio-cgroup KAMEZAWA Hiroyuki
2009-07-21 15:56     ` [PATCH 3/9] blkio-cgroup-v9: The new page_cgroup framework Balbir Singh
2009-07-22  1:20       ` KAMEZAWA Hiroyuki
2009-07-22  2:07         ` KAMEZAWA Hiroyuki
2009-07-22  8:28           ` Ryo Tsuruta
2009-07-22  8:37             ` Balbir Singh
2009-07-22  8:46               ` KAMEZAWA Hiroyuki
2009-07-22  8:39             ` KAMEZAWA Hiroyuki
2009-07-22  9:30               ` Ryo Tsuruta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5971c26b399a97f51dd10ea497617733.squirrel@webmail-b.css.fujitsu.com \
    --to=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=agk@redhat.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=dm-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ryov@valinux.co.jp \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®