From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1432787AbdDYWLr (ORCPT ); Tue, 25 Apr 2017 18:11:47 -0400 Received: from gloria.sntech.de ([95.129.55.99]:35442 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1432735AbdDYWLi (ORCPT ); Tue, 25 Apr 2017 18:11:38 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Masahiro Yamada Cc: linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org, Linus Walleij , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] pinctrl: rockchip: remove unneeded (void *) casts in of_match_table Date: Wed, 26 Apr 2017 00:11:32 +0200 Message-ID: <59735505.eYpuzA7ihW@diego> User-Agent: KMail/5.2.3 (Linux/4.8.0-2-amd64; KDE/5.27.0; x86_64; ; ) In-Reply-To: <1493156063-8446-2-git-send-email-yamada.masahiro@socionext.com> References: <1493156063-8446-1-git-send-email-yamada.masahiro@socionext.com> <1493156063-8446-2-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Am Mittwoch, 26. April 2017, 06:34:22 CEST schrieb Masahiro Yamada: > of_device_id::data is an opaque pointer. No explicit cast is needed. > > Signed-off-by: Masahiro Yamada > --- > > drivers/pinctrl/pinctrl-rockchip.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-rockchip.c > b/drivers/pinctrl/pinctrl-rockchip.c index 7813599..da1a38f 100644 > --- a/drivers/pinctrl/pinctrl-rockchip.c > +++ b/drivers/pinctrl/pinctrl-rockchip.c > @@ -2769,25 +2769,25 @@ static struct rockchip_pin_ctrl rk3399_pin_ctrl = { > > static const struct of_device_id rockchip_pinctrl_dt_match[] = { > { .compatible = "rockchip,rk1108-pinctrl", > - .data = (void *)&rk1108_pin_ctrl }, > + .data = &rk1108_pin_ctrl }, You should base your pinctrl-patches on top of Linus' branch, especially as the rk1108->rv1108 is in there: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/commit/drivers/pinctrl/pinctrl-rockchip.c?h=for-next&id=b9c6dcab265e93c47bdcd99ab7c6acda90ed669b With the above fixed: Reviewed-by: Heiko Stuebner Heiko