From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A6C73D8113 for ; Tue, 19 May 2026 07:33:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779176006; cv=none; b=lwsPMtQnrOqTfA09icyeBCfnqIvt/1Px2SBOrOvSg5nbZN5PH+8xgW6iJvzBywfu8ihJOXqqKplhEtnuKiFVZfiYWsh5pfNxIuOjoI02Ui7zYqsmB66G9Oe31zSWMYoGVsANtStkKIVaKolxkp1lmkokiywxS2js7PNlqmsAr50= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779176006; c=relaxed/simple; bh=T0guUqlCRvhj7yJ5sgNqGgFmmry7tvekfvKNYKAdEQQ=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=oNvVhuUVBTt7LPaAiMyfPgLpwoYVr81wfdgRmBgGQbIBhFoZX+bWkVccS7z7DgqDKXOx6UJ33dKM8w38hzU20BZ97eh+S5eVWWU+cy7QDu7QwLgRoD9Bh9tFyhU5L/zdNLlSKaw7H6UpGkpIJmh4Uy4YQAN9E06bBPZXqXfjQho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ss/0YChg; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ss/0YChg" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-449de065cb3so3025422f8f.2 for ; Tue, 19 May 2026 00:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779176003; x=1779780803; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=CptfMWX/OnKpQAZK1ljSyYDr+otcGVWKuHyIusA7+I4=; b=ss/0YChgdazltohZFTFNsrl6p7imMI0Ue3lirBELdWCkJz7PsWJGErf1XwQ64YQd5l TzVJHRy1+0qJjOg010uGzJpq3PotaWjP36px8tDAt7c4VarxfCCicm6dr+37rXTZj5Pz 8yhecITkqa0FlKhEAuR68rtOomfExCVn/8hBs/99VyB6ktGClN/qt+6qvJmr6F3CDlDm 9trR/BDSsudRgkRQ6o1v/++fbqT/0MS4IcZ0WDrgXAQ9KZLp3d7lnPq7C7ontyl1SN2E 1T38PNrDidw6RztKfYPR8XtHTlHaNFHdy1dtsYwIw1/pbFIl5tOkrHsgSveycStq/BrQ Yxig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779176003; x=1779780803; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CptfMWX/OnKpQAZK1ljSyYDr+otcGVWKuHyIusA7+I4=; b=XZQnMGvkCf9QgUzB1jyQwRaCqWC/s1EsXCI6UbJJc/FD7IPAlUb/AFXznrB5tS/szw zRlX7vIpvhILgYnsF0b+yWH46WEbfGyNUj3b8N2FCcS8Oa/geB6zqEUoXwBy4U5A4vO1 eUfCsBYg1q9dmUaESBqMBz3qHAydyUFPkKmNMkb2BpeGyoXrJCzd5env0Gqz0z5Lmy5o 79r0UFE8uS+8XrkK1fa3yAJ1ZHnChiZHHBw8ujA3oUuhqnXzRlHQJTOVHollAoTphjxW 6cNQrWgdc5x9YVFxhhZNQACJiO72WDs7Xsw9xLVjvQeQkjH5TJIDpxfD9KcSL7H4XCTL 2dog== X-Forwarded-Encrypted: i=1; AFNElJ/fH3DLCYm9BPtBT7RyutRyjqbsmnxn0jZQZ1GtSoMhuxiHFpH6H8kwgMvBZ+AbUFfGXLLtixJ4mBTLd3E=@vger.kernel.org X-Gm-Message-State: AOJu0YywWGxt/GCtLVQbN77EZfUOcj9NdzBgW++OczIYr34JN4xRoX0X EyNcCnPRXPT6R0WdAs4PJwVmSul7NTOdkMfxUkHRYYWl8/zHH421LSYH8FgpoNFr1QE= X-Gm-Gg: Acq92OF9J3MpRZ3i+9M3lhWtFdLj5+42143KlpuacXBw+TWhNYX5jy8ch7lIW9ksQOz OfjxGq8HVpf+clxJnZq4e84JQDc+kaptHWeLVZWgH+9IQj5uzZi6FoyTzRUlyP9XsEwVOKdDb2E cWd90xTnAPiwQsULqciZ+dnZz/tD28jLEuaE7i+Ln+dC+QNul3A9BnzZgL6qPDjTWGIweRPKgcO q2boiHBPLDx68fUxZu/9DVitLnLU17GHkgJ/R30crGQguXmfVSYN4C+iP5KN/S0LN/Khjdh2qXC MXmAjeXETSs4zG4nEEwqQ++q7MBD21K+9tOWSk1sz96+gikI6S6XyNKioVK+N4RbktZRQZx733/ mimTeGBM8+RbL9myM8alpokk+15Pqor3CYMCYVXlOap3DYy9QayAVlqXodNzd7MMZObqrmzLKgr lI7G3wF2JQfterPy9g2b/MbfPXwb2sJNY7t1f41vFnnTCGXEJ2U517o203QLbrZf2xRribUKAbz H46 X-Received: by 2002:a05:600c:a406:b0:48a:9540:1a3a with SMTP id 5b1f17b1804b1-48fe60e56abmr233108995e9.8.1779176003502; Tue, 19 May 2026 00:33:23 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:1d4b:274c:94d:a69f? ([2a01:e0a:106d:1080:1d4b:274c:94d:a69f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe537ccf5sm301918365e9.14.2026.05.19.00.33.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2026 00:33:23 -0700 (PDT) Message-ID: <59760925-a19d-460e-afc9-015dd210f193@linaro.org> Date: Tue, 19 May 2026 09:33:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH 09/13] drm/meson: dw-hdmi: Use devm_clk_get_enabled() helper To: Jonas Karlman , Kevin Hilman , Heiko Stuebner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jerome Brunet , Martin Blumenstingl Cc: dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org References: <20260518194744.2483580-1-jonas@kwiboo.se> <20260518194744.2483580-10-jonas@kwiboo.se> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260518194744.2483580-10-jonas@kwiboo.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/18/26 21:47, Jonas Karlman wrote: > Change to use the devm_clk_get_enabled() helper instead of using an > open-coded variant. > > Signed-off-by: Jonas Karlman > --- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 48 +++++++++------------------ > 1 file changed, 16 insertions(+), 32 deletions(-) > > diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c > index fcd2426af9fc..d0cf2042d41c 100644 > --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c > +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c > @@ -634,29 +634,6 @@ static void meson_dw_hdmi_init(struct meson_dw_hdmi *meson_dw_hdmi) > > } > > -static void meson_disable_clk(void *data) > -{ > - clk_disable_unprepare(data); > -} > - > -static int meson_enable_clk(struct device *dev, char *name) > -{ > - struct clk *clk; > - int ret; > - > - clk = devm_clk_get(dev, name); > - if (IS_ERR(clk)) { > - dev_err(dev, "Unable to get %s pclk\n", name); > - return PTR_ERR(clk); > - } > - > - ret = clk_prepare_enable(clk); > - if (!ret) > - ret = devm_add_action_or_reset(dev, meson_disable_clk, clk); > - > - return ret; > -} > - > static int meson_dw_hdmi_bind(struct device *dev, struct device *master, > void *data) > { > @@ -666,6 +643,7 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master, > struct drm_device *drm = data; > struct meson_drm *priv = drm->dev_private; > struct dw_hdmi_plat_data *dw_plat_data; > + struct clk *clk; > int irq; > int ret; > > @@ -716,17 +694,23 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master, > if (IS_ERR(meson_dw_hdmi->hdmitx)) > return PTR_ERR(meson_dw_hdmi->hdmitx); > > - ret = meson_enable_clk(dev, "isfr"); > - if (ret) > - return ret; > + clk = devm_clk_get_enabled(dev, "isfr"); > + if (IS_ERR(clk)) { > + dev_err(dev, "Unable to get isfr pclk\n"); > + return PTR_ERR(clk); > + } > > - ret = meson_enable_clk(dev, "iahb"); > - if (ret) > - return ret; > + clk = devm_clk_get_enabled(dev, "iahb"); > + if (IS_ERR(clk)) { > + dev_err(dev, "Unable to get iahb pclk\n"); > + return PTR_ERR(clk); > + } > > - ret = meson_enable_clk(dev, "venci"); > - if (ret) > - return ret; > + clk = devm_clk_get_enabled(dev, "venci"); > + if (IS_ERR(clk)) { > + dev_err(dev, "Unable to get venci pclk\n"); > + return PTR_ERR(clk); > + } > > dw_plat_data->regm = devm_regmap_init(dev, NULL, meson_dw_hdmi, > &meson_dw_hdmi_regmap_config); Reviewed-by: Neil Armstrong Thanks, Neil