From: "Dynetrex, Admin" <admin@dynetrex.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "PS10 PETER HONG 洪繼澤" <peter_hong@fintek.com.tw>,
mkl@pengutronix.de, mailhol@kernel.org,
linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] can: usb: f81604: fix struct f81604_int_data size mismatch
Date: Mon, 24 Aug 2026 02:14:26 -0700 [thread overview]
Message-ID: <597D8628-7241-47FA-B692-FEB66360EF3D@dynetrex.com> (raw)
In-Reply-To: <2026082433-dynamic-overspend-8f32@gregkh>
Hey Greg,
This issue was reported by me about a month and a half ago, however, I did not have an environment setup for kernel development in order to submit a patch.
I appreciate Peter taking a look at this.
Kind Regards,
Alex
> On Aug 24, 2026, at 2:08 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Mon, Aug 24, 2026 at 04:27:58PM +0800, PS10 PETER HONG 洪繼澤 wrote:
>> The struct f81604_int_data defines 9 bytes of interrupt data:
>> - Byte 0: Status register (sr)
>> - Byte 1: Interrupt register (isrc)
>> - Byte 2: Interrupt enable register (ier)
>> - Byte 3: Arbitration lost capture (alc)
>> - Byte 4: Error code capture (ecc)
>> - Byte 5: Error warning limit register (ewlr)
>> - Byte 6: RX error counter (rxerr)
>> - Byte 7: TX error counter (txerr)
>> - Byte 8: Reserved (val)
>>
>> The hardware sends exactly 9 bytes for the interrupt endpoint.
>> However, the struct was defined with __aligned(4) attribute which
>> caused the compiler to pad the struct to 12 bytes.
>>
>> This causes a problem in f81604_read_int_callback() where the short
>> URB check compares urb->actual_length against sizeof(*data). When
>> sizeof(struct f81604_int_data) is 12 but the hardware only sends 9
>> bytes, the check fails and valid interrupt messages are discarded.
>>
>> This results in the driver only being able to transmit once because
>> the TX complete interrupt is never processed.
>>
>> Fix this by removing the __aligned(4) attribute so the struct size
>> matches the actual hardware data size of 9 bytes.
>>
>> Fixes: 88da17436973 ("can: usb: f81604: add Fintek F81604 support")
>> Fixes: 7299b1b39a25 ("can: usb: f81604: handle short interrupt urb messages properly")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Ji-Ze Hong (Peter Hong) <peter_hong@fintek.com.tw>
>
> Nit, doesn't match the From: line :(
>
> Also, the first Fixes: tag isn't correct, it's the second one that
> matters.
>
> And wasn't this reported by someone already:
> https://lore.kernel.org/r/A3834A07-5639-4779-844F-C5843DFC3928@dynetrex.com
> ?
>
> And yes, this patch does look correct.
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2026-08-24 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 8:27 PS10 PETER HONG 洪繼澤
2026-08-24 9:08 ` Greg KH
2026-08-24 9:14 ` Dynetrex, Admin [this message]
2026-08-24 9:38 ` Greg KH
[not found] ` <8b816ee1-a81c-4d5d-a908-97e8640b07d2@fintek.com.tw>
2026-08-24 10:02 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=597D8628-7241-47FA-B692-FEB66360EF3D@dynetrex.com \
--to=admin@dynetrex.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=peter_hong@fintek.com.tw \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®