From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F07431E855 for ; Thu, 2 Apr 2026 08:45:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775119516; cv=none; b=AxS1dc7curedCuyiu1FcX5dm9cW84EbdmSXrOljjezJGNHYZY0XGrEOCY6ehXwDJc2/jo0cjuzljh7cfAnfnBBubASPllkkH+b6aBkqda4bwzLtEQDJKCOWOPv7o7KUsIVjSbzhKKxvGmJ2DoaGgRSOFUrt34k9uspMzuvzxUXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775119516; c=relaxed/simple; bh=dm+ndDEpOaDOtVRU1v0Ul3uMIWipHNX5gxJnl1HJfOk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZRei6xmPhBRkLynq94Fef1NxWOh/Mzb+7jJPG9fzy6Gb0d4ILPr6UMhvuOb7S2rFtwertoj4RrSIgNx+fAiu+R+d0TOE0gWDNph1j/j4gARx/X0goGNt/flx6YsvbYjDQ4GajML6gfzJJzqhyerkNL06heoXCvxtjaIu/hz6tyA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EtOJYgk+; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=hMzQV1/5; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EtOJYgk+"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="hMzQV1/5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775119514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mj5VbSaOpMIAAfwFyDpLkGHz6PUorYL3fNmYF2ZE9cA=; b=EtOJYgk+HD63uizH71S9/tDmoNSgGep/BmlMWZuGlI4ujmEifBkjrO8h4Onp8C++GH6OLb h1PBcbGDChhK/gwIM3103dxH5W0/GsWbgeQHg1RkVzYsDKpDfPJ7Z53PF+aoPHQnAqA9cK tOba9Fx8RCTNxnh4D3ygW7SKW62mDi4= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-122-BHgwYYNJNRmA5Y1uerE5Ww-1; Thu, 02 Apr 2026 04:45:13 -0400 X-MC-Unique: BHgwYYNJNRmA5Y1uerE5Ww-1 X-Mimecast-MFC-AGG-ID: BHgwYYNJNRmA5Y1uerE5Ww_1775119512 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-43d03bad787so591360f8f.1 for ; Thu, 02 Apr 2026 01:45:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775119512; x=1775724312; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Mj5VbSaOpMIAAfwFyDpLkGHz6PUorYL3fNmYF2ZE9cA=; b=hMzQV1/5Kgcgzv79ns5TBjBbIIh4OebjYKPmgaf/GTJ5+eW0R8OZnrpc1G9fq1+P36 LuzjBbz/pXgx67slP9rpE4e7LLZrEqE/fVORgk9DYXaV15sB+dJ6Wu90/1eZM8F7GMtA B4XtHby5pZA2kL1kyxmSwf+1b6FhvSPsx9LYz6nFelpy2JPO31xS1VrLLA0v4yPENZZS 4e12A/b3e8JbqVoznf0nJ3XXA6vWLvA529IOHVpm7CMTRG5QR3mFgnV25lzkpgh63GxN DKwT2ZSvJV4zZ98fDEdaj1T2a/wDZ6gb0xgeRl66rh1jVAAtvVSUXwG7bWtX9Zsbfqfy uf4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775119512; x=1775724312; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Mj5VbSaOpMIAAfwFyDpLkGHz6PUorYL3fNmYF2ZE9cA=; b=d8MqwZBZo0ND7Bpnx48Z/wXGFThLo/OMIZNIQOmbAKQvRdZZG67g9BpvMb3lOqzRTL CcevRmh6qUIb4hO+eWrB4vn8D8m/M4MknnNQcT93sYJ1l4CdodVHz+I/l9AVOj9WwemW O4GGL2Fw7eb/JSurhJ8TmAWR3r3y2U2EPkjjgS1uB0w29yiBaSz765QF4hOnXMNKoc4j 6LGo4U6/MLtbGykPcahXmsZT01KmrwO330FQCkmTS3hhfVxJdaQa2QBAeafo8sSsMGHC 89ttVadaTIGD4xu95Ltc1nvPpYExekIOVZ/mQeQjk/MocVZVGPNSBQk0xog97Ik1FFHR o8Pw== X-Forwarded-Encrypted: i=1; AJvYcCVDUX1hKPPXZF6v0YkaeSPGYQMvO0AHPchB1cHfGT6A2ybg1z7bvqNUeeDDCihBIP3M2E//LU+y/MiLbVo=@vger.kernel.org X-Gm-Message-State: AOJu0YzzV5eAP4mDhedPjVqqm4gHcDBfzGmu9aCBcCWasYW7DHFj8gSK YhXkXlVZgs2O3LU/WYvOsI5hwN6Alshq9ZVglzQxSw5FtxAbtU3MvIH8smHV3vQ2t6aVZPkxMrl EO0SsBewjQUzb36TY4y8Tf78akQFHdlJcWc+D5jT3Le6RPGsKHZPfCYYmYoISZF1n2Q== X-Gm-Gg: ATEYQzzcwiF57uqILH97OfHVKEXkyvmozDbPr/QMYiXDzgYCVMcOidaE12mE0n45cnL gHiviXbJ84jZmS6b/x8GqFA4Xq+vbP1mVDj4+eRiJ/TgMsGGuq4VjjMgKw5POvuN3hKEgDG+2YB DSlaTYdhVsHTrCqlgPG4TpusCcROzPD0Y3qMbNhtJu0HUMOU3FUqR9qLa9xSXvyI7xfJWM+azsQ N8EadLkZRW/WPgqfm/kTpVmI2z7NR2dR8fQUKemn5jXg9VOakddNwyVy4rUkaMZXirHc2V5hEON EgGcy9e4uCuEP8MZNCdg4XYfnJxJ1YOGPNmCESrM9XAWfa9n79k/a96/G7hK4yHcDBVfadbFpyO 2BF7OmTGjEIbtBW49J0Z44nIYT6zwFSHZF4SsMWkpv8F2igFPbuW4PFcDhg== X-Received: by 2002:a05:6000:2409:b0:43b:6a16:17e with SMTP id ffacd0b85a97d-43d1505b105mr12337376f8f.11.1775119512048; Thu, 02 Apr 2026 01:45:12 -0700 (PDT) X-Received: by 2002:a05:6000:2409:b0:43b:6a16:17e with SMTP id ffacd0b85a97d-43d1505b105mr12337306f8f.11.1775119511517; Thu, 02 Apr 2026 01:45:11 -0700 (PDT) Received: from [192.168.88.32] ([212.105.153.248]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e4d58e5sm7487535f8f.23.2026.04.02.01.45.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Apr 2026 01:45:10 -0700 (PDT) Message-ID: <5985db57-e992-4786-9f9a-cb863220a0ea@redhat.com> Date: Thu, 2 Apr 2026 10:45:09 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 net-next 6/6] octeontx2-af: npc: Support for custom KPU profile from filesystem To: Ratheesh Kannoth , Simon Horman Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sgoutham@marvell.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, donald.hunter@gmail.com, jiri@resnulli.us, chuck.lever@oracle.com, matttbe@kernel.org, cjubran@nvidia.com, shshitrit@nvidia.com, dtatulea@nvidia.com, tariqt@nvidia.com References: <20260325072159.1126964-1-rkannoth@marvell.com> <20260325072159.1126964-7-rkannoth@marvell.com> <20260327133036.GE567789@horms.kernel.org> Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/31/26 5:43 AM, Ratheesh Kannoth wrote: > On 2026-03-27 at 19:00:36, Simon Horman (horms@kernel.org) wrote: >> AI review flags that: >> >> npc_load_kpu_profile_from_fs() calls npc_apply_custom_kpu(), >> which returns early if the following condition is met. >> >> if (fw->kpus > profile->kpus) >> >> Does npc_prepare_default_kpu() need to be called before >> npc_load_kpu_profile_from_fs() to initialise profile->kpus, >> which is 0 by default due to profile being allocated using devm_kzalloc()? > simon, > > Thank you very much for your time. > > The v9 AI review has raised the following concern again: > https://netdev-ai.bots.linux.dev/ai-review.html?id=f29b81fe-bb3f-4902-85de-8271effbb41c > > "In the filesystem loading path, does profile->kpus need to be initialized > before calling npc_load_kpu_profile_from_fs()? > > Simon Horman raised this concern in v8 review on lore: > https://lore.kernel.org/netdev/20260327133036.GE567789@horms.kernel.org/" > > would like to clarify that npc_prepare_default_kpu(rvu, profile) is invoked > very early in the flow, and therefore applies to all execution paths > (default, filesystem loading, and firmware loading). Additionally, > if the filesystem loading fails, npc_prepare_default_kpu() is invoked again to > ensure that all values are reset to their defaults before attempting to load from firmware. > > Could you please advise on the best way to address the AI review comment? > Specifically, would you recommend: > > 1. Adding a clarifying comment in the code, or > 2. Invoking npc_prepare_default_kpu() again just before npc_load_kpu_profile_from_fs() > > to make this behavior clearer? In this case, replying in the relevant thread is enough - AFAICS the AI is allucinating quite a bit with this comment. Sometimes adding an explanatory comment nearby the relevant code would be better/more clear, but I think not in this specific case. Thanks, Paolo