From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751219AbcBJVUe (ORCPT ); Wed, 10 Feb 2016 16:20:34 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:59353 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750876AbcBJVUc (ORCPT ); Wed, 10 Feb 2016 16:20:32 -0500 From: Arnd Bergmann To: Suravee Suthikulpanit Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm@kernel.org, brijeshkumar.singh@amd.com, thomas.lendacky@amd.com, leo.duran@amd.com Subject: Re: [PATCH V2 03/12] dtb: amd: Fix DMA ranges in device tree Date: Wed, 10 Feb 2016 22:19:51 +0100 Message-ID: <5986200.Q9dxHf9bIM@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <56BBA80E.6090205@amd.com> References: <1454954357-8395-1-git-send-email-Suravee.Suthikulpanit@amd.com> <2845776.WTPtnQzg8d@wuerfel> <56BBA80E.6090205@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:+LsI4SOPHvmNL2WFqZfHIpZiMwS4XC2c/ZdmHBFB0lOFNdJJ7uo 8kLK5QdL1/pxMprcqGBPJuKrBbgVcoPhCSeDHZRw+LDCXTZWEBGVF0hfL4LK9Vq8FJiPViS znL2GHzvDkCC96fLTKnHW8A98iUXer+M+YKfVgCBKeET8FZm/k6Z88S5sXJ783326gnKRYh g+o8zcrhuw94VtY79ShQA== X-UI-Out-Filterresults: notjunk:1;V01:K0:aUy/m6AHRds=:BGoF3o3haFjJ52WI+59bz4 qY48R9DYtNkt3IGGp5nhpw5nDZxHrnG+KCTN7qNv1jbmYbru4unZpWZ2kwc+nXzEgn7b37Q/y 69ktd38P2OSfqaCbUipbUQHzPqy962z1bkW1Hz/zUFZLeeUsDlGKaCSpG5fO8SQ/bBK6f3MrT i/kVNEOpBubnByF67uA1wOWHNdJQ7hwk9yWLcS1GrK+WxfcF7B2pwZ0wFL0jvpKC5keweT76n 83SeYi0s5g1gobY4mxWH1d4cc7dh/I7PRREmaHsvkKa/DFONJGeM1CFrOpjcGEsIoA2se4aCO 3vZeJjU+pHlj40qFxMK8hrxtBSdLEr1JltbNSZnu3uVSYmxxPBS9uDOHnNY2h+Bh+BFy0DCwA 5XZEXr+hqFEolPYj1fBtJ1sqCX9agOyRBavVF6QYmz4J6WHilWp1VLCQ7Ii4/oxF3dVNFWoe/ VM0oFsusertw2fGp9ud+ItSEkQInAyPPsml2cI4P5CAt4rWkx3AIZgSWgJiva0Ep23QtyTu71 CES9Mws/UsF6kRb0o+feswoiYTisoWR9QDm+xfCHb5VU70W/26J3+joUTMnt4NKUK0Mmf0oZQ CRuQsblwK5AKY/Dt72tTcQ/0Zk4Ox6W3bumWt88yZvrDnjklI32aekStdJbVp7VNCRItBvAla YLTsTRInbhDnApfX9UkMg27GY+Sj3Mmv/nsYOALWPhQlwiUr60sxcSN79QSbwDibL7IrMb7MA XOpLGGelOicVzPOB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 11 February 2016 04:13:50 Suravee Suthikulpanit wrote: > > On 2/9/16 21:57, Arnd Bergmann wrote: > > On Monday 08 February 2016 11:59:08 Suravee Suthikulpanit wrote: > >> From: Suravee Suthikulpanit > >> > >> Fix DMA ranges of smb0 and pcie0 nodes in AMD Seattle SOC. > >> > >> Signed-off-by: Suravee Suthikulpanit > >> > > > > This could use a changelog text to explain why it's broken and how the > > fix works. > > > > Arnd > > > > So, I have not experience the breakage. However, IIUC, the GICv2m MSI > frame is also considered DMA-able. So, I think it should be included in > the dma-range specified here. Please let me know if my assumption is > incorrect. Otherwise, I will include more description in the commit log > in my next rev. No, I think this makes sense. Just put a more explanation into the changelog when those things are not obvious from looking at the change. Arnd