From: "Lu, Yinghai" <yinghai.lu@amd.com>
To: "Andi Kleen" <ak@muc.de>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
"Muli Ben-Yehuda" <muli@il.ibm.com>,
"Andrew Morton" <akpm@osdl.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86_64 irq: reset more to default when clear irq_vector for destroy_irq
Date: Tue, 24 Oct 2006 14:33:08 -0700 [thread overview]
Message-ID: <5986589C150B2F49A46483AC44C7BCA412D75C@ssvlexmb2.amd.com> (raw)
Clear the irq releated entries in irq_vector, irq_domain and vector_irq
instead of clearing irq_vector only. So when new irq is created, it
could get that vector.
Signed-off-By: Yinghai Lu <yinghai.lu@amd.com>
--- linux-2.6/arch/x86_64/kernel/io_apic.c 2006-10-24
13:40:48.000000000 -0700
+++ linux-2.6.xx/arch/x86_64/kernel/io_apic.c 2006-10-24
14:03:08.000000000 -0700
@@ -716,6 +716,22 @@
return vector;
}
+static void __clear_irq_vector(int irq)
+{
+ int old_vector = -1;
+ if (irq_vector[irq] > 0)
+ old_vector = irq_vector[irq];
+ if (old_vector >= 0) {
+ cpumask_t old_mask;
+ int old_cpu;
+ cpus_and(old_mask, irq_domain[irq], cpu_online_map);
+ for_each_cpu_mask(old_cpu, old_mask)
+ per_cpu(vector_irq, old_cpu)[old_vector] = -1;
+ }
+ irq_vector[irq] = 0;
+ irq_domain[irq] = CPU_MASK_NONE;
+}
+
void __setup_vector_irq(int cpu)
{
/* Initialize vector_irq on a new cpu */
@@ -1803,7 +1819,7 @@
dynamic_irq_cleanup(irq);
spin_lock_irqsave(&vector_lock, flags);
- irq_vector[irq] = 0;
+ __clear_irq_vector(irq);
spin_unlock_irqrestore(&vector_lock, flags);
}
next reply other threads:[~2006-10-24 21:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-24 21:33 Lu, Yinghai [this message]
2006-10-24 22:52 ` Josef Sipek
2006-10-25 3:46 ` Yinghai Lu
2006-10-25 4:02 ` Yinghai Lu
2006-10-25 4:52 ` David Rientjes
2006-10-25 6:01 ` yhlu
2006-10-25 11:30 ` Muli Ben-Yehuda
2006-10-25 16:40 Lu, Yinghai
2006-10-27 6:20 ` Eric W. Biederman
2006-10-28 5:44 ` Yinghai Lu
2006-10-28 9:18 ` Oleg Verych
2006-10-28 17:29 ` Andi Kleen
2006-10-28 20:06 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5986589C150B2F49A46483AC44C7BCA412D75C@ssvlexmb2.amd.com \
--to=yinghai.lu@amd.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=muli@il.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®