From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1035245AbcIWSUj (ORCPT ); Fri, 23 Sep 2016 14:20:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59000 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1035173AbcIWSUe (ORCPT ); Fri, 23 Sep 2016 14:20:34 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <147464371753.5090.1634919599283321856.stgit@warthog.procyon.org.uk> <147464376586.5090.14901936645927156006.stgit@warthog.procyon.org.uk> To: Sergei Shtylyov Cc: dhowells@redhat.com, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 07/15] rxrpc: Fix accidental cancellation of scheduled resend by ACK parser MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <5988.1474654831.1@warthog.procyon.org.uk> Date: Fri, 23 Sep 2016 19:20:31 +0100 Message-ID: <5989.1474654831@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 23 Sep 2016 18:20:33 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sergei Shtylyov wrote: > > case RXRPC_ACK_TYPE_NACK: > > if (anno_type == RXRPC_TX_ANNO_NAK) > > continue; > > + if (anno_type == RXRPC_TX_ANNO_RETRANS) > > + continue; > > Why not fold the above 2 *if*s together? Or use *else if* at least? I have a pending patch that adds something between them. David