From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11F6B3502A8 for ; Fri, 30 Jan 2026 08:22:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769761325; cv=none; b=eC3DMgqjO1rXE7qNW9nnZXq3J2vjfMUC4hHaph1/0JeCL3XNK9FSn2rrJLvosv87aM9h8LSKcMH0HeKz3A+ilpMCf0GZuFsBkD7GmBD6Mml2OtSzBwSrAq6cKKxZws5pgEpyqVUElp3fUw6LpEL/u/zQOJnLYKxfm6ETBmKW9uo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769761325; c=relaxed/simple; bh=J4DRfww7ucPy2nhQw/aPntBZirkdW0Scw5xAmzu42fU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cnI772/cCB5nHxvWNhiAkwy4ILhlIeCk2wsY2iEom7dU9yfEh4VnDMi/qnd2+EC1IpPVRN/0VmyR7NlKMZ2QMiekoiQji3oMlecgKkWRPcA9Xmmgqo0boniotLjBkzINld7D7Yc8/cky4ej3dp0zOwBe7mlfxXc8FW4/iLfQZTA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=F1+0BKIM; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="F1+0BKIM" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 33B3A4E4233B; Fri, 30 Jan 2026 08:22:01 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 067056075A; Fri, 30 Jan 2026 08:22:01 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 3BCA7119A8884; Fri, 30 Jan 2026 09:21:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1769761319; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=lXxHuYrh03fUzcI/Zkqg/QgX8e+Lo3imXwlEfiMCCoo=; b=F1+0BKIMCEEQVxHIfFUbH0XsABCOysbrdjT4ZUVaqej1JgD6sQ6z1a40oqdQmWHE0ECe8E XdeRnPa145UOig/TbRUDiHZwIKL6vqWIEtpTwKPl7s7CwBWqTTx9SgQTFtgDzqPASHmVfY n5YDH1EuLUcpOKpL++0f+HbGupISfHfTmaVRcMQd7hrT2WoPiqwcJDByYs6KRGxma6Pt4y 52bPbLnSAgb2+FAbePlILKFEoZ6vC92GWyse4nsTHt0pGfWLaKwUOQBmhaT+NVFQPXXoAi /Y8JNuw067UsnT6RQ81apn0vewWZcEwlqC93vqSZJw6RZl4xYubWDQZktgL0DQ== Message-ID: <598a828a-2c29-49d2-8e33-11c8748e3202@bootlin.com> Date: Fri, 30 Jan 2026 09:21:51 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 00/12] net: phy_port: SFP modules representation and phy_port listing To: Jakub Kicinski Cc: davem@davemloft.net, Andrew Lunn , Eric Dumazet , Paolo Abeni , Russell King , Heiner Kallweit , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Christophe Leroy , Herve Codina , Florian Fainelli , Vladimir Oltean , =?UTF-8?Q?K=C3=B6ry_Maincent?= , =?UTF-8?Q?Marek_Beh=C3=BAn?= , Oleksij Rempel , =?UTF-8?Q?Nicol=C3=B2_Veronese?= , Simon Horman , mwojtas@chromium.org, Romain Gantois , Daniel Golle , Dimitri Fedrau References: <20260128204526.170927-1-maxime.chevallier@bootlin.com> <20260129195955.3bbff4fd@kernel.org> From: Maxime Chevallier Content-Language: en-US In-Reply-To: <20260129195955.3bbff4fd@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi Jakub, On 30/01/2026 04:59, Jakub Kicinski wrote: > On Wed, 28 Jan 2026 21:45:13 +0100 Maxime Chevallier wrote: >> Here's V2 of the second phy_port series, this time bringing support for >> more phy_port use especially for SFP, as well as the beggining of a >> ethnl uAPI. That's a quick repost, but with the build issues and AI >> review, I think it's worth getting this version out there for review. >> >> It builds on the recent addition of phy_port representation to enable >> listing the front-facing ports of an interface. For now, we don't control >> these ports, we merely list their presence and their capabilities. >> >> As the most common use-case of multi-port interfaces is combo-ports that >> provide both RJ45 and SFP connectors on a single MAC, there's a lot of >> SFP stuff in this series. >> >> This series is in 2 main parts. The first one aims at representing the >> SFP cages and modules using phy_port, as combo-ports with RJ45 + SFP are >> by far the most common cases for multi-connector setups. >> >> The second part is the netlink interface to list those ports, now that >> most use-cases are covered. > > I'll send out the AI code review. The one on patch 9 looks plausible, > not sure about the rest. LMK if none of them in fact make sense. Thanks, I'll look carefully into that :) Maxime