From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CDD9391854 for ; Thu, 16 Apr 2026 11:55:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340525; cv=none; b=GXPTw6sT6EFk7LGVSykms2rAluUixhkPSVHKespJLcb7YqOlFnKS0oo7FEyzVGOAEl21rUlxHHhb9ugTvfPCL7CEe2Q27GUK/6PLFPsYNHVy4b30uP3NiKfaUbpiM+hCGk6d3PVrQPXGBrYAco1OFw5d9+MaXEH37qbRgatH4Ro= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340525; c=relaxed/simple; bh=s07xyFEM3K0s/4ToldgrmCA6O5xZjLxj37ncRd3W7WM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PFspQeZQ+FdKcAwvui/op6SKD4lgv7oGGNzxiDp0C84v1vep6cMvovZGioj7gxTaEqxGvyPEo8PYfuZlXDdSREAA5AkzjgFZd26CHp+jh53/Ot79BtAR0CibVLteuUDhMp9SYFgVyydkz9sIV2CNqaZBKWwIUYoA3TFpH67aIiE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cfNiYrBF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=I5t2SzNU; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cfNiYrBF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="I5t2SzNU" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63G6JNL31668220 for ; Thu, 16 Apr 2026 11:55:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= o6NEGa2bH8D4qzhZrxX1FAi3DMIdvR8dA4e0BmblBlw=; b=cfNiYrBF8hpHbgMy 6pS4OY89Fa7KN8rqsvW4dIvEPU3rW80TluzQyH6AE5uW/wwnmprHljGTWBh2LCxZ AttH9FJKY5VuyY0gR5cujYitbQYv+WOCjsiXWL4pxrD8n76HX6Q5nOPscFxUD/2t njHvo+O3VekZCFj9JZCiRXHOhHfu7mAmLibW1XtoXxmBbFioS2oclYnXoFRjPcOS +qiT/OhtZDTTGO+Z2BN5TpFFiDpK36JKa96qMdSX4NXGtOWUNnukMhvwbc1UTyI/ lMm2JKJEteB3HCOqwfdGs5W23ZsdDe7wwSeiOuaEBlSBoDsnvljNtj+nA6t3F6GZ ANVpXQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4djtd916nb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Apr 2026 11:55:22 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-35da8eb0553so701701a91.1 for ; Thu, 16 Apr 2026 04:55:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776340522; x=1776945322; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=o6NEGa2bH8D4qzhZrxX1FAi3DMIdvR8dA4e0BmblBlw=; b=I5t2SzNUHE62RlJ5BWf09pWkoQpBqJu+UCNmobXOaRDdMyDOlTIr9RE6xH+NhU7FzL l0WVAdnnzxTP4SsmGZfMq9G4XFn0goASjMaH1N3N5eoLPggkp2j8LTBzBdUI0e2+I7B/ au3SyrH0C+vD5iD+IVtg3pAbwgVTHvvjiTT/LYOdvVkaXOMAlb8QrTB/2TA4iX+QpHVV Q9PbXa4y8T4uteGOphh48TLjCdK/bs7Fkt3X1u237DBxbXxApWDDz22+CrwC9op9mWZB aadzpOciV3YH7bd+mWnUt0YLWtUghGHtONA9c4H0uqHOmUCSDDryXkmguIrZXShNBD7p 2G+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776340522; x=1776945322; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=o6NEGa2bH8D4qzhZrxX1FAi3DMIdvR8dA4e0BmblBlw=; b=qE8Rrz4ExjCJJ83jIZVXZ/KhZqloOHXulwH9PuCN2HK1nqWVE8TEeOnYobA7a9PXhv +yCVvs8AFZ7ikADmX4RB9aQmy2IyxM8JQrmwLmyhf2dT7T2adXM1cDrypiJArCFRpFXb eNObl7a5fxZ55QeFcZTlzNKXkt2FxDF1elkLtA2kpsK6q7sXUPiuRYslxnFAi6UhmaSu otHXMDhOhsfcSZ09TvS4nqiW+Q5fc3SPdsaB/LAiBAOvji5qgcxAVKvcOwxeI9Ppdc4f ZyMzcGrUchGKJ4J8It1ZCmVav3ea9cvEsU9KI5aFrO+nrmt3FYoo/aYnyBw5jRQl0gxG aDPw== X-Forwarded-Encrypted: i=1; AFNElJ82BvP86dyoLGyH3UyDPPzTINQ6Rl7ROYIu+dVlSzgEzuxYcDpybqFYtgcnu2SW1n8NThe81MONklkI9wU=@vger.kernel.org X-Gm-Message-State: AOJu0YyaojjQ0sWCSAXJaw2Z0FUOFK00ZxxTv26aZXw0PYNEfKpKP2ir GokiOGj3DAxdt2+ygsWm4lU/Whh3YOQ6m5iN6k63/Efosjgw9vRHoBXJ93ALx0MF4BuzX88OahY PTYjmx2heJHLffeMy/UaN+Mm26s0oiIHZWY043HJuzt6ICgZ3wqTVwZNDrZixuIWeSqA= X-Gm-Gg: AeBDiescEdwA2yM2VIelyAx5DV+P6Z3jbukFCl63xaVyi7pmPHwmy1uDA+lyRoYWrYV Sd52cYzxgGvtSCJa4+vhN9b9WtYo0UvDAwKQr5wUTlNmVJ10ESNwo9EJtQB5F83UfmOr4+M487x QX2/OhwSeKK400GRgjKw8E74TDBf6Hw0zdjPseewbREN6+gICnLDIqMofnQLdcWrW2r4XGSCtSK gxTfM0QgZYz77pKHXBrnE9uqdX9xCgBKHYGyUYJp5XTdTQPHckpecDf1yHWVSdyaCSbJmRpW80F C53ulnqLbRizP1XGCEQe8VhBDZSu+YQND60W4JLAuc91oEUA8VpkymbGlLr1L9/F9e35+Y1493y zaycWEt1DMqAJ3CD8oqYwjfLT39KaX1D4sRpiVHWXC5iaT3TBng== X-Received: by 2002:a17:90b:3cc7:b0:35f:bb17:39f with SMTP id 98e67ed59e1d1-3612f26da35mr3254461a91.1.1776340521977; Thu, 16 Apr 2026 04:55:21 -0700 (PDT) X-Received: by 2002:a17:90b:3cc7:b0:35f:bb17:39f with SMTP id 98e67ed59e1d1-3612f26da35mr3254431a91.1.1776340521490; Thu, 16 Apr 2026 04:55:21 -0700 (PDT) Received: from [10.219.49.106] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35fce719729sm2273435a91.0.2026.04.16.04.55.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Apr 2026 04:55:21 -0700 (PDT) Message-ID: <598c5171-3083-4122-9901-10d1812d54f8@oss.qualcomm.com> Date: Thu, 16 Apr 2026 17:25:16 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/3] ASoC: codecs: lpass-wsa-macro: Guard optional NPL clock rate programming To: Konrad Dybcio , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@oss.qualcomm.com References: <20260413121824.375473-1-ajay.nandam@oss.qualcomm.com> <20260413121824.375473-4-ajay.nandam@oss.qualcomm.com> <07c73c75-5ce8-46f2-bcfb-bb6d7fe0afca@oss.qualcomm.com> Content-Language: en-US From: Ajay Kumar Nandam In-Reply-To: <07c73c75-5ce8-46f2-bcfb-bb6d7fe0afca@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE2MDExMyBTYWx0ZWRfXyu3ACK7/IDdb r48ZywWuqNUi8F0DgkwB4oCNOAARHn6JUh998CASlztQ+ZW2Wst5krzzCbrnXS4D2ZpUdCoI3In Z58TN9TUhw+h+HTJJbFlo/+OwN5hzXy1YVEHalMDxdQu41sSNudUnuTrSIz9y2yILgDUzkqn5HT f7fcrIdIPHqtbQ0TPveR+rIitlLWn2SKo8/xOeCgir7WZYpxXNr6zy7WKSrWu0uMtSs6qaZQYJ0 pJVd21LpieTYbka2aZYRywIBTA/n+eFdgux19W8aXtMDjGMWQpAm+F/xHiCM0jXiO/Rx+JObrWD cwHAe35mKwCaAPq1iF5qnLRno4keE8vQrrBNTi+D7EEaA5H9f+hplZRaMKzlA5so7WOlDz6cFqQ HYdkCnFRARHTm21pm4BmpVNVc5EO9qnb0Tb5ME6cPK6Sk5INju98PTW3fzI4SF88M3z+ABwzWvo sE0kyxPS2v+6b0gx4Tw== X-Authority-Analysis: v=2.4 cv=avuCzyZV c=1 sm=1 tr=0 ts=69e0ce2a cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=-w0wuxjKlsJx7c5tfiQA:9 a=QEXdDO2ut3YA:10 a=ZXulRonScM0A:10 a=zZCYzV9kfG8A:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: u84Q1-opjGJG-wzfdyYlnfKctpPjvI1o X-Proofpoint-ORIG-GUID: u84Q1-opjGJG-wzfdyYlnfKctpPjvI1o X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_03,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 spamscore=0 bulkscore=0 priorityscore=1501 adultscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604160113 On 4/14/2026 2:17 PM, Konrad Dybcio wrote: > On 4/13/26 2:18 PM, Ajay Kumar Nandam wrote: >> The NPL clock is only present on some platforms. When it is absent, >> wsa->npl remains NULL, but the driver unconditionally programs its rate. >> >> Guard clk_set_rate() for the NPL clock so platforms without NPL do not >> attempt to access it. >> >> No functional change on platforms that provide the NPL clock. >> >> Signed-off-by: Ajay Kumar Nandam >> --- > > If you dig into the definition of the function.. > > --- drivers/clk/clk.c --- > > int clk_set_rate(struct clk *clk, unsigned long rate) > { > int ret; > > if (!clk) > return 0; > > So let's drop this patch ACK, will drop in next series. Thanks Ajay Kumar Nandam > > Konrad