From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752225AbdHLSDc (ORCPT ); Sat, 12 Aug 2017 14:03:32 -0400 Received: from mout.web.de ([217.72.192.78]:56955 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752060AbdHLSDa (ORCPT ); Sat, 12 Aug 2017 14:03:30 -0400 To: alsa-devel@alsa-project.org, Fabian Frederick , Jaroslav Kysela , Takashi Iwai Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] ALSA: opl3: Delete an error message for a failed memory allocation in snd_opl3_new() Message-ID: <5991f20d-dbad-a916-76be-375ade7de737@users.sourceforge.net> Date: Sat, 12 Aug 2017 20:02:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:CokV93PmgVrFQKbkUF4+JsZIbyIUXGcSloFLYiyftAiy9ba0nRD +uvcUMFfSA2P5ceg7uyLgoUGFyewDyHd8NK4tL+KjnQ/r7+gPT/0xtgwkx4hi4jXfpWG0QK QmXw6nlMFOrFe07+ooM1onkx1xkEv8zZ+4dzmWIpBTgAZYcNidtEOo/N8nXmQ3cH2KpFrR4 yb0W3J8UKL/sg1IRaqMGA== X-UI-Out-Filterresults: notjunk:1;V01:K0:vh2vyWsyNaQ=:sU+S4cm2E1GTO2V2tBzjqY 98QFCWZdvxDoY+cpWoSoZrmAE2se9RkMJsKsXhLjzvlDqwFGXhsvJtpnLV8zl/dqkM7fj54Sj j4ODUTHKY8ynwM4KC5kI+9N2tIchBZx7k0z9W6oVlngqrQlxOhK9ZWu5Ty+VMIHYZNosUL8pn qMNUxlOEYXc8cdoyY+FPXLoYyCXGdW3wsPSeC1eWY4z4gknb4WgkYkP3Yzh9ehkMAm4HgktjC 57u4zcbU+YvOwqpGQx6HnwMwmSM2DqVmvKPWpDifPpN6DkbSeUFRcfQXf2ciR+tLzh8nlKJud p7r6yaLomW+0NoN/I7BIbb86ZY3KmfzTX0A2WnYzq1HZepWYgQJIL7LXkk0r0AaoPpmZ0LTb2 4L341KYcnuJ5Peji2/lZnHuWoSRj/ZUaVwVxkv34rBe3YRbxXt2fW30PDcLJpV6NHUvZqlO8J pal4Vfp/u73xiD5+A9mQ0PovAKm7zw7Trl04VCUZfi1wfim6rVeRjYKpLRyykYqobzi/szO8O vjJJEHv1oD2I4ItkovVnhjPpIqvduG9OH/fNaD7q1OMc/gCH/I583F4ia20CWw7RujDm+7+Fj 6XGnDmZsmwGKwh8/BlGd+iVsk5ozff/NBiOp391WXwabUjTcNxhVlCABsPNlGBhuCmxN1lomR KbEoE5KGHgAHLnnIxIh2nefHz8BcrtgzCC0A4ByyZhujcIEO+ZoXfc9ewT9+K/MP8tawL2o2n E+j/N/Lj7ThJxxhl67fcFhTiuQO7ZJjQIv5LsJfuw0yN1J2Sm/kZc7Vk5VVe13PUUZ3gHKh9X VWiW4RxaAGOS4FPKX6WaU0jU6f1fJdsXfKN3DOMwvIOB+QYp9I= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 12 Aug 2017 19:54:20 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- sound/drivers/opl3/opl3_lib.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/drivers/opl3/opl3_lib.c b/sound/drivers/opl3/opl3_lib.c index d5e5b4657b4b..588963d6be28 100644 --- a/sound/drivers/opl3/opl3_lib.c +++ b/sound/drivers/opl3/opl3_lib.c @@ -355,10 +355,8 @@ int snd_opl3_new(struct snd_card *card, *ropl3 = NULL; opl3 = kzalloc(sizeof(*opl3), GFP_KERNEL); - if (opl3 == NULL) { - snd_printk(KERN_ERR "opl3: cannot allocate\n"); + if (!opl3) return -ENOMEM; - } opl3->card = card; opl3->hardware = hardware; -- 2.14.0