From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA5ABC678D5 for ; Wed, 8 Mar 2023 18:49:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230257AbjCHStp (ORCPT ); Wed, 8 Mar 2023 13:49:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230199AbjCHStc (ORCPT ); Wed, 8 Mar 2023 13:49:32 -0500 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F59FBF8C8 for ; Wed, 8 Mar 2023 10:49:30 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id o12so69585337edb.9 for ; Wed, 08 Mar 2023 10:49:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678301368; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=45PyBpg4cgEyf/MX2yYwknP8xso5JZQyHb1Ea24n/SM=; b=GUsrD8kmEoyHpT+XzkjqnEi8F6LUSevbMawimRHX98R3VxxrNOIatu9O5eMeRPRmgn Ic5jITwdRqJEFG9d5wns1kYEHPNZxidIa3v4lDnP4NYWEK/oLle6WBp4rzMoEYCpn6/R UQzLmBG9Hrursy2xj01drRTuesVtSTpMuPK+PPBGjpPeLHWRtyuLoYXa8/3NvNlH+CwN RR2fS9nleDJKsXrhF+SyL7/uTk0v8YYOzl9DrSJZJPuUvoqNldzG9bcvKrFz3wNhNBpz ChD8MnYR2zoS11xtsxVMTkVIZtsIsc/wAlcyD0i2KsgQLKpjr/Apx1hiA0ggKrAeO7rw iXyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678301368; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=45PyBpg4cgEyf/MX2yYwknP8xso5JZQyHb1Ea24n/SM=; b=SOlzv/o0ir5s2IB1N5iYU+21J0+iMCcUQQ57vspUM5SNV6Lyd+bqkKqOO2Fy795OQ/ xfzuHibd21ydpc8xkylN/bfUg6yKuVhMoO9KV4Hrwp41xZrzZAC9gAK5vv4/4/cnK5mG WldDbl9NeBgb2cDWK8cWa50Z7X9XAWTISV/m2a8bJHTuLEGE4PZkVUz2WT+rh4BetOSR CvYhNyN0V8c+7JucZRm7dnmc5VLhiE9UFmjYEXQRMlfvPG82079auq+3NgFSUGLGtpmK /4dCpIf0qb4RKF3zjXqd9yvo35N6iyzLdwuFO/GrQ+gfY0WQQWKWdmnY7NzsE7IXZ40d I6Bg== X-Gm-Message-State: AO0yUKVzqNjDUYmNid8h3+W7Bqjm6YOaiH0rtQmR9mZqq2GSS83mHOj/ PoXKJ+j9FuHCOCkdADqV6oRTmQ== X-Google-Smtp-Source: AK7set8NTawZYI1kntQ056oja2n5V6VWQ9wLhrcmliI9bJyRdIUZgPo2/LZx19zW/3BefeCesKBhqQ== X-Received: by 2002:a17:906:6d53:b0:8b1:2614:edfe with SMTP id a19-20020a1709066d5300b008b12614edfemr20769244ejt.9.1678301368660; Wed, 08 Mar 2023 10:49:28 -0800 (PST) Received: from ?IPV6:2a02:810d:15c0:828:ff33:9b14:bdd2:a3da? ([2a02:810d:15c0:828:ff33:9b14:bdd2:a3da]) by smtp.gmail.com with ESMTPSA id i6-20020a17090671c600b008b26f3d45fbsm7910217ejk.143.2023.03.08.10.49.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Mar 2023 10:49:28 -0800 (PST) Message-ID: <5992cb0a-50a0-a19c-3ad1-03dd347a630b@linaro.org> Date: Wed, 8 Mar 2023 19:49:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [net-next PATCH 09/11] dt-bindings: net: dsa: qca8k: add LEDs definition example Content-Language: en-US To: Andrew Lunn Cc: Christian Marangi , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lee Jones , linux-leds@vger.kernel.org References: <20230307170046.28917-1-ansuelsmth@gmail.com> <20230307170046.28917-10-ansuelsmth@gmail.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/03/2023 14:57, Andrew Lunn wrote: > On Wed, Mar 08, 2023 at 11:58:33AM +0100, Krzysztof Kozlowski wrote: >> On 07/03/2023 18:00, Christian Marangi wrote: >>> Add LEDs definition example for qca8k Switch Family to describe how they >>> should be defined for a correct usage. >>> >>> Signed-off-by: Christian Marangi >> >> Where is the changelog? This was v8 already! What happened with all >> review, changes? > > Did you read patch 0? > > We have decided to start again, starting small and working up. This > patchset just adds plain, boring LEDs. No acceleration, on hardware > offload. Just on/off, and fixed blink. Sure, but the patch is carried over. So what happened with all its feedback? Was there or was not? How can we know? > > What do you think makes the patchset is not bisectable? We are happy > to address such issues, but i did not notice anything. I didn't write anything like that here... Best regards, Krzysztof