From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 930DC1D6DDF for ; Mon, 7 Oct 2024 14:21:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728310882; cv=none; b=IqY24TiprmKzn+qclt3cqu9sDNpoK5LKMAYR+8FvJo5Tyo+YXN7Oy1+DMb/S3DRSn+bENHuDUg/zl4YrKZgXk9U7dlSTkl+EJyHti/UhCE6mpkt//zw/jvs7Odsq+So5LkVx8YrNfX70QgyJW7qiz6TgeikZEbaGmi7dXHq0v7o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728310882; c=relaxed/simple; bh=UfsJfKuIY3PfTumtoxik1Ea0qW7eIN7BDbe4vNZ5QTo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tv5X4Jgga9HmWo9on+YdNtyv/HhsezTSH6IqoJ5QONMP1IwlNYo64XmEzoaUUcG+16App2NHssVZnqY6+TwGlr63eCKzDchiYG8Si7qjGb8UhVzVXEEF8ChSOuiMObiXJn6/IwkjAFV/Rf/c4UPY9uP4pAWZ8cdmTxYy572ZaAw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=MtgWjhaE; arc=none smtp.client-ip=209.85.166.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="MtgWjhaE" Received: by mail-io1-f45.google.com with SMTP id ca18e2360f4ac-8323b555ae2so187681739f.2 for ; Mon, 07 Oct 2024 07:21:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1728310880; x=1728915680; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VC79KI09BOMVnLp6M0LTx88kNLWiyUtWHxQNIXByZpQ=; b=MtgWjhaERUwLDazYZf9528GmKtNqaM74AtUHFvKZ39vdbncKWTGJ0AFR2VDIdKxoVh RnodvXuezB7aszBDqAGrlgflE9RhdSc0WEqSjhya5a1MZKrNJC9dWmyFVhU7OaScDFuz 2PFc8KTjaZSa+oCVrs1tbrKJL1jyUJ//241BFvY6tGu/pAuYm4ZBE6JqR97J8JYUn2F7 0WMABHEDTPaz1m6PeGAeGxDdRgqsUhFG2wE6L7HtP6euDwOou/wQM4YTUGFEL+azeKBD jLR5IyM/QYDf/4q4O0Kb+Nz8xRDu2U2Tq+PEtP27ihypBmWPXrtPCoBkQnh3o1ZOQH4W g3oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728310880; x=1728915680; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VC79KI09BOMVnLp6M0LTx88kNLWiyUtWHxQNIXByZpQ=; b=nd0C7ViDihaVOk+E+f3MmkodHPL5a2Sev4uh9B2FHqfHTCB3qujsn5tnCOmJvlWGMv f11PydTSVuhOCaHtc7LvMl64WUEbCSqxJrUQW6HYqa1iaXcoX2eUAGd4Inw0TNzB3Q9A 7ONi/7DbY+8Gf83jjycjmDROts3rjbkwoBzZJiywPS3f7Gl+PqTRNTAp0gqpzECY4ZYD 3Luq5ClSqY6AkVAKEc9NaUrJnBcC1OAXcXuna3TDQY33kmrTe0x7sZdtDYst9/zweRYc dZR0j5uqZDJHWxq4pukY4kDQGIuLni9ZYVXGC5H0SZWQROjisPjmy7bCNWyRNPDOl2wW Zj5w== X-Forwarded-Encrypted: i=1; AJvYcCWMkhCV5gKuamC8oi/idEBH+eT8FekXtD+Fjiz637RxqWryiU+R/XwLvIvfUqewYjiZdPNL1+79gaE3hWE=@vger.kernel.org X-Gm-Message-State: AOJu0YwxjnH/snOkKh5ePbAmA+BtAvs0rTHFkRJuNSMloyJBgWiaFBsf VCGfHrleC4ZpDkZGw0WaxviTwI2k0Ksnl8fuJTXvRwAPbhmAbQyfgH448peyHtw= X-Google-Smtp-Source: AGHT+IGEdNw9YxcVJEbUjcPKtzj9rWUNLLjJTyJuMad09+Ov0EAZ2JIxxAkjp223AAfsDuP15ylO7Q== X-Received: by 2002:a05:6602:6010:b0:82a:4490:692a with SMTP id ca18e2360f4ac-834f7cb0918mr1196787639f.7.1728310879744; Mon, 07 Oct 2024 07:21:19 -0700 (PDT) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4db6eb569cfsm1182684173.67.2024.10.07.07.21.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Oct 2024 07:21:19 -0700 (PDT) Message-ID: <5995b8d7-a94a-4c5d-8bf6-e19998c0ac72@kernel.dk> Date: Mon, 7 Oct 2024 08:21:18 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5.10] block, bfq: remove useless checking in bfq_put_queue() To: George Rurikov , stable@vger.kernel.org, Greg Kroah-Hartman Cc: Paolo Valente , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, Yu Kuai , Jan Kara References: <20241007140709.1762881-1-g.ryurikov@securitycode.ru> Content-Language: en-US From: Jens Axboe In-Reply-To: <20241007140709.1762881-1-g.ryurikov@securitycode.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/7/24 8:07 AM, George Rurikov wrote: > From: George Ryurikov > > From: Yu Kuai > > commit 1e3cc2125d7cc7d492b2e6e52d09c1e17ba573c3 > > 'bfqq->bfqd' is ensured to set in bfq_init_queue(), and it will never > change afterwards. No point pushing this to stable, so no from here. -- Jens Axboe