Re: [PATCH] acpi/video: lcd_get_level_current doen't return current level

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Saturday, March 30, 2013 05:01:41 PM Artem Savkov wrote:
> acpi_video_device_lcd_get_level_current() called acpi_video_bqc_value_to_level()
> with "*level" as a second argument, resulting in level being returned based on
> initial input, not current brightness, breaking backlight controls.

This looks like a valid fix, but (1) is the problem being fixed a regression
and if so, which was the last working kernel and (2) do you have any pointers
to bug reports/BZ entries related to that?

Also, do I assume correctly that you've tested it?

Rafael


> Signed-off-by: Artem Savkov <artem.savkov@gmail.com>
> ---
>  drivers/acpi/video.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> index 3cdd047..68a777b 100644
> --- a/drivers/acpi/video.c
> +++ b/drivers/acpi/video.c
> @@ -505,7 +505,8 @@ acpi_video_device_lcd_get_level_current(struct acpi_video_device *device,
>  				return 0;
>  			}
>  
> -			*level = acpi_video_bqc_value_to_level(device, *level);
> +			*level = acpi_video_bqc_value_to_level(device,
> +					device->brightness->curr);
>  
>  			for (i = 2; i < device->brightness->count; i++)
>  				if (device->brightness->levels[i] == *level) {
> 
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.