From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753335AbbBRVDV (ORCPT ); Wed, 18 Feb 2015 16:03:21 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:58902 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751809AbbBRVDT (ORCPT ); Wed, 18 Feb 2015 16:03:19 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Russell King - ARM Linux , gregkh@linuxfoundation.org, Yoshihiro Shimoda , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Felipe Balbi Subject: Re: [PATCH] usb: renesas: fix extcon dependency Date: Wed, 18 Feb 2015 22:03:06 +0100 Message-ID: <5999511.VS28SAB4Q0@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150129114158.GY26493@n2100.arm.linux.org.uk> References: <2167400.bYh9r60XLF@wuerfel> <20150129114158.GY26493@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:1tl0K5bcM0Kinp/vR03HfdrN5MA6W7FCG9D/XaCKWfrFqdZ8mep e+x3IT/SewBFOCSPUi61eGEwSP8gf7Wm3Vzd/XctNbfNetngo2Dfc+N56zHxo+0yuejj4qq Fb+BS8eMSnAtaVByqeXZ6qXEmh1lVr2soMmsYF1/EvMHtkdLEYObtnovSwpS0vk4NXt04al 06qW+cRJSajP7i8LbMv7w== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 29 January 2015 11:41:58 Russell King - ARM Linux wrote: > On Wed, Jan 28, 2015 at 10:47:18PM +0100, Arnd Bergmann wrote: > > The renesas usbhs driver calls extcon_get_edev_by_phandle(), which > > is defined in drivers/extcon/extcon-class.c, and that can be a > > loadable module. If the extcon-class support is disabled, usbhs > > will work correctly for all devices that do not need extcon. > > > > However, if extcon-class is a loadable module, and usbhs is > > built-in, the kernel fails to link. In order to solve that, > > we need a Kconfig dependency that allows extcon to be disabled > > but does not allow usbhs built-in if extcon is a module. > > > > Signed-off-by: Arnd Bergmann > > > > diff --git a/drivers/usb/renesas_usbhs/Kconfig b/drivers/usb/renesas_usbhs/Kconfig > > index de83b9d0cd5c..0ea9040b9f10 100644 > > --- a/drivers/usb/renesas_usbhs/Kconfig > > +++ b/drivers/usb/renesas_usbhs/Kconfig > > @@ -6,6 +6,7 @@ config USB_RENESAS_USBHS > > tristate 'Renesas USBHS controller' > > depends on USB_GADGET > > depends on ARCH_SHMOBILE || SUPERH || COMPILE_TEST > > + depends on EXTCON || !EXTCON # for module build if extcon is > > The comment doesn't make much sense on its own (and when I read it before > reading the above description, it was down right confusing.) Maybe a > longer comment would be a good idea? > Sorry for the late reply. We have a lot of these dependencies, and I never know what a particular maintainer expects. Let me try to come up with something better. Arnd