From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dixit Parmar <dixitparmar19@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: iio: magnetometer: document Infineon TLV493D 3D Magnetic sensor
Date: Mon, 4 Aug 2025 08:16:36 +0200 [thread overview]
Message-ID: <5999ba4a-79ec-45b1-9d91-0252669917fe@kernel.org> (raw)
In-Reply-To: <6b691092-f931-4140-8097-0ad67d02bde9@kernel.org>
On 04/08/2025 08:03, Krzysztof Kozlowski wrote:
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d.yaml b/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d.yaml
>>>> new file mode 100644
>>>> index 000000000000..ebcf29067a16
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d.yaml
>>>
>>>
>>> Filename should match compatible. Otherwise a1b6 is just confusing.
>>>
>> Idea behind having a1b6 is that the TLV493D is sensor series and this
>> a1b6 is one of the models. As this driver is intended, developed and
>> validated on a1b6 I kept it in compatible, though the file name contains
>> only the sensor series. In my undertanding, this same file & driver can
>> be reused for other drivers from same family with new compatible fields.
>> Does that make sense?
>
> No, because I did not speak about drivers at all. Please follow
> kernel/DT conventions.
>
And now I see this wasn't ever tested. :/
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-04 6:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-02 6:44 [PATCH v2 0/2] iio: magnetometer: add support for Infineon TLV493D 3D Magnetic Sensor Dixit Parmar
2025-08-02 6:44 ` [PATCH v2 1/2] iio: magnetometer: add support for Infineon TLV493D 3D Magentic sensor Dixit Parmar
2025-08-02 11:43 ` Jonathan Cameron
2025-08-02 13:25 ` Andy Shevchenko
2025-08-04 3:18 ` Dixit Parmar
2025-08-05 16:32 ` David Lechner
2025-08-10 18:34 ` Jonathan Cameron
2025-08-06 16:27 ` kernel test robot
2025-08-02 6:44 ` [PATCH v2 2/2] dt-bindings: iio: magnetometer: document Infineon TLV493D 3D Magnetic sensor Dixit Parmar
2025-08-02 7:45 ` Krzysztof Kozlowski
2025-08-04 2:44 ` Dixit Parmar
2025-08-04 6:03 ` Krzysztof Kozlowski
2025-08-04 6:16 ` Krzysztof Kozlowski [this message]
2025-08-04 13:36 ` Dixit Parmar
2025-08-03 16:20 ` Rob Herring (Arm)
2025-08-04 2:41 ` Dixit Parmar
2025-08-05 16:35 ` David Lechner
2025-08-02 8:53 ` [PATCH v2 0/2] iio: magnetometer: add support for Infineon TLV493D 3D Magnetic Sensor Andy Shevchenko
2025-08-02 11:15 ` Jonathan Cameron
2025-08-02 13:17 ` Andy Shevchenko
2025-08-04 2:52 ` Dixit Parmar
2025-08-04 9:03 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5999ba4a-79ec-45b1-9d91-0252669917fe@kernel.org \
--to=krzk@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dixitparmar19@gmail.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®