From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7161B24A07C for ; Tue, 24 Feb 2026 03:44:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771904649; cv=none; b=B/8SDTz07OvV19RQ3EfCNIQqG9Q2SYiwf2Nc+Z4hOFwc7914QsA6NAfyXZPey7CvPJ56AwUU9bgr+98/w0GUVEX8/kmk8aP/2fgZOTioxhdm5+JsFkn4lHxHi9IUXdCpd9kSgZfryy+zBPm1g1oucFLtOcnGWqWI92MQS6E0dac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771904649; c=relaxed/simple; bh=6uS4OLKcNp2gVPiuOOLClGukG2UF6E+enaVTy/Af7GE=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=GBjsnuiyFtc/WA+70/R7GWN/Bspgdy4xytCvRvBtCCjFg4eH6gRB5miwEBknb02zCNOQ2MAp1wWWK+OK6tPYJlBGkxB+azd8MjURig6TnaD0SK8wY3s1lBjoJ2kUQMTn5fuxpezb1vgTLPfGdZYTXkwGdn2n2UVI5vHSJFoVUE4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BGEPxkZO; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BGEPxkZO" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-8217f2ad01eso4904002b3a.2 for ; Mon, 23 Feb 2026 19:44:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771904648; x=1772509448; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=Tg28i2guOUUfs5z9kKCzxt5IH57XwZXvv1yeywJRxW8=; b=BGEPxkZOJu5xVXgnFTATPcX5hpfsLk9R6B/MkTRh1cVIhDn2ZrwNfQx8+DHvFU3oPV 0zR2rePH6niIUKaT+a/i3N3rfejW0903iTAzPFZqmdOSgHqcIzsQWEhdyhArXRmoP/My HLFgR2HW4/vtCGOWSixw8ITZ4UGYMSY0N7O/rv44C9wkpDDTv3bN0eHjjMfwyng5fEZ9 ipQUoulQFF1T49XbxKVcZTXKGjTXq5ayNaTyV151weiqDO2ALyizc7l7X8jV6IvnwGCV 6EM86orrcE6OhDg8h9mbMayA92aRP8aANSTDa8xZP0TdC3Ad9ReElXfWhDoxwaJgKdVM 5jXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771904648; x=1772509448; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Tg28i2guOUUfs5z9kKCzxt5IH57XwZXvv1yeywJRxW8=; b=LsYb3Uv390VGt9WDWZP/bq0CS6ecCvJtAj5THHYUT4zOk0s8NL5BdCbMD+DPYGqQJC YapIupQ/K7u6Ggusausi4j93kiXEMfRvY3qcCpR3lqF1xIoAbHTguJcYS39Aj4XWXGd2 4fhMY2WKctrt9CAxiiBG5LHqFof7y8zw3U1fOvuevIjIf7J9h7KHrXLctKH4e3Ab9buO rNzBaT4gGE+jLMnDyyyy6vmGMCaiXQy8z44SBIuD2f38TdUxM5qIO8mJ2OSqvVU3m5gS lKPO5n9YM5PBDGp0CrDdKa6vFwZZs/RiYkuzcJn917agJs5nQHZ6/a2GO7ga4ZSUjJGk F4fQ== X-Forwarded-Encrypted: i=1; AJvYcCVw9F8dkigAG10CqUY+lxNFRQydQhm6Jss9QYlI2g0/EWQtwtNXRJCQyfdajYZg8NKw5G2+QZQmiR/tJgA=@vger.kernel.org X-Gm-Message-State: AOJu0YzLlorfd/ShDpMYTswAxX3URg9KmRm8FIykuDhbL9dMiTjKfZhO ImzuYL9rVtVkeD/FkRp+QxF2umT1zsklXjznLgv5Klnh76gLg68PhK+XghKvZg== X-Gm-Gg: ATEYQzyc4UDFaKi9lCiD61nD5vGyHhbeKXd87xb3HqreAcExwVvKfT48g+LhMv7PCel qoeRunaXVN+knG/w23nx+EEY2UG8Z+49yCOOuN9gb2zKzEimzrWN1FeGrJIf4KHrl2mo0voNMkL rDCC17NwslZ97pG+6dkStq+a5C1zAuw1mp6eNY/G+cDYt2jFApAXLeSr5Uob1SNiy2wUJ5Er9rk G4cjvKSDkadYzDEZpcY154nhzwHjJ/tZuLWp6g0xfRJ6j4dUbYkH347+SLD7QK0OGvKSvF7PhWz ODa4IOjUExs64SgrgRdPP90FFqVlQQHn9dJvU9jjwVAj66WxKLcbCehrSt2m0jKpm7r7u2AL0+p XxjqCxmWHryOTHVr29++9YGuoHSyi9AYX6xbDn0UTsASIp1CAPT1GkX8C5xcvxxvvu7ar9MxrlL l9WLmqdVdjOL4R1Wukjn3Mu+yo8/pTcLNe6Q== X-Received: by 2002:a05:6a00:99e:b0:81f:31c3:2e34 with SMTP id d2e1a72fcca58-826da8f4e6amr8446085b3a.25.1771904647639; Mon, 23 Feb 2026 19:44:07 -0800 (PST) Received: from ehlo.thunderbird.net ([2401:4900:78f0:4f05::e27:3519]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-826dd86c4a1sm9613947b3a.37.2026.02.23.19.44.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Feb 2026 19:44:07 -0800 (PST) Date: Tue, 24 Feb 2026 09:14:03 +0530 From: Sanjay Chitroda To: Matthew Wilcox CC: Vlastimil Babka , Andrew Morton , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/slub: drop duplicate kernel-doc for ksize() User-Agent: Thunderbird for Android In-Reply-To: References: <20260220124243.3264133-1-sanjayembedded@gmail.com> Message-ID: <599A72EE-58A7-47C0-9F0B-03A908D2AC5F@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 23 February 2026 8:46:42=E2=80=AFpm IST, Matthew Wilcox wrote: >On Fri, Feb 20, 2026 at 06:12:43PM +0530, Sanjay Chitroda wrote: >> The ksize() API is already documented in the public header, and >> Documentation/core-api/mm-api=2Erst pulls that canonical doc into the >> book=2E The kernel-doc block added to mm/slub=2Ec by commit >> fab0694646d7 ("mm/slab: move [__]ksize and slab_ksize() to mm/slub=2Ec"= ) >> introduced a second definition for the same symbol in the generated >> docs, which makes Sphinx emit: >>=20 >> WARNING: Duplicate C declaration, also defined at core-api/mm-api:521 >> Declaration is '=2E=2E c:function:: size_t ksize(const void *objp)' >>=20 >> Remove the redundant kernel-doc comment from slub=2Ec so only the > >Usually we keep the kernel-doc comment with the implementation, not with >the prototype=2E I agree with you, Kernel-doc comment should be present with implementation= =2E I have observed that multiple kernel-doc comments are there in slab=2Eh wi= th prototype, would you suggest to replace all possible at once ? Or with reference to reported warning; we can keep kernel-doc with impleme= ntation and remove from prototype and rectify commit message to highlight i= deal kernel-doc practice along with existing commit details so context woul= d be better clear and relavent=2E