mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: arvindY <arvind.yadav.cs@gmail.com>
To: abbotti@mev.co.uk, hsweeten@visionengravers.com,
	gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: comedi: dt282x: release irq on dt282x detach
Date: Fri, 6 Oct 2017 22:51:45 +0530	[thread overview]
Message-ID: <59D7BBA9.4040904@gmail.com> (raw)
In-Reply-To: <748fce08720473cd8124b10690cf4661688bb925.1507307537.git.arvind.yadav.cs@gmail.com>

Sorry for noise, ignore this patch.

On Friday 06 October 2017 10:06 PM, Arvind Yadav wrote:
> free_irq() should be called on driver 'dt282x' detach.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>   drivers/staging/comedi/drivers/dt282x.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/drivers/staging/comedi/drivers/dt282x.c b/drivers/staging/comedi/drivers/dt282x.c
> index d5295bb..a132f60 100644
> --- a/drivers/staging/comedi/drivers/dt282x.c
> +++ b/drivers/staging/comedi/drivers/dt282x.c
> @@ -1057,6 +1057,8 @@ static void dt282x_alloc_dma(struct comedi_device *dev,
>   	if (request_irq(irq_num, dt282x_interrupt, 0, dev->board_name, dev))
>   		return;
>   
> +	dev->irq = irq_num;
> +
>   	/* DMA uses two 4K buffers with separate DMA channels */
>   	devpriv->dma = comedi_isadma_alloc(dev, 2, dma_chan[0], dma_chan[1],
>   					   PAGE_SIZE, 0);
> @@ -1070,6 +1072,9 @@ static void dt282x_free_dma(struct comedi_device *dev)
>   
>   	if (devpriv)
>   		comedi_isadma_free(devpriv->dma);
> +
> +	if (dev->irq)
> +		free_irq(dev->irq, dev);
>   }
>   
>   static int dt282x_initialize(struct comedi_device *dev)

      reply	other threads:[~2017-10-06 17:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-06 16:36 Arvind Yadav
2017-10-06 17:21 ` arvindY [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59D7BBA9.4040904@gmail.com \
    --to=arvind.yadav.cs@gmail.com \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome