From: jeffy <jeffy.chen@rock-chips.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-kernel@vger.kernel.org, seanpaul@chromium.irg,
briannorris@chromium.org, heiko@sntech.de,
gregkh@linuxfoundation.org, dmitry.torokhov@gmail.com,
dianders@chromium.org, tfiga@chromium.org, broonie@kernel.org,
thierry.reding@gmail.com
Subject: Re: [PATCH] driver core: Move device_links_purge() after bus_remove_device()
Date: Thu, 19 Oct 2017 09:11:40 +0800 [thread overview]
Message-ID: <59E7FBCC.4070201@rock-chips.com> (raw)
In-Reply-To: <2591080.ki3098E8CB@aspire.rjw.lan>
Hi Rafael,
On 10/19/2017 07:36 AM, Rafael J. Wysocki wrote:
> Why don't you write something like the following:
>
> "The current ordering of code in device_del() triggers a WARN_ON()
> in device_links_purge(), because of an unexpected link status.
>
> The device_links_unbind_consumers() call in device_release_driver()
> has to take place before device_links_purge() for the status of all
> links to be correct, so move the device_links_purge() call in
> device_del() after the invocation of bus_remove_device() which calls
> device_release_driver()."
that looks much better, i'll use it and your signed-off, thanks :)
prev parent reply other threads:[~2017-10-19 1:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 11:28 Jeffy Chen
2017-10-18 23:36 ` Rafael J. Wysocki
2017-10-19 1:11 ` jeffy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59E7FBCC.4070201@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=briannorris@chromium.org \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=seanpaul@chromium.irg \
--cc=tfiga@chromium.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome