From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752114AbdJ0HdC (ORCPT ); Fri, 27 Oct 2017 03:33:02 -0400 Received: from regular1.263xmail.com ([211.150.99.138]:57861 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750790AbdJ0Hc7 (ORCPT ); Fri, 27 Oct 2017 03:32:59 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: briannorris@chromium.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: <774996e8a87e0229963d13884b4d3812> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <59F2E124.5060209@rock-chips.com> Date: Fri, 27 Oct 2017 15:32:52 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Brian Norris CC: linux-kernel@vger.kernel.org, bhelgaas@google.com, linux-pm@vger.kernel.org, tony@atomide.com, shawn.lin@rock-chips.com, rjw@rjwysocki.net, dianders@chromium.org, linux-pci@vger.kernel.org Subject: Re: [RFC PATCH v8 7/7] PCI / PM: Add support for the PCIe WAKE# signal for OF References: <20171026132840.20946-1-jeffy.chen@rock-chips.com> <20171026132840.20946-8-jeffy.chen@rock-chips.com> <20171027055529.GB85582@google.com> In-Reply-To: <20171027055529.GB85582@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Brian, On 10/27/2017 01:55 PM, Brian Norris wrote: > One reason this series is failing for me: the above is failing with > -EINVAL -- it seems like no one set the 'can_wakeup' flag for the > Marvell Wifi card I'm using. It seems like we probably*should* be > calling device_set_wakeup_capable() from your new setup method, to say > that we're capable of wakeup. The PCI PME code does this already, which > seems to make sense. There are also some network drivers that do it too > (e.g., ath10k), but not all. > right, thanks for noticing, will fix it in the new version... and Sinan suggested to separate of code and wakeirq handling, would it make sense to rewrite this as pci-wakeirq.c(platform_pm_ops based on irq), and move of parse code into drivers/of/(maybe into of_irq_parse_pci()'s PCI interrupt parsing code)? > Brian >