From: "guanghuifeng@linux.alibaba.com" <guanghuifeng@linux.alibaba.com>
To: "Jörg Rödel" <joro@8bytes.org>, "Vasant Hegde" <vasant.hegde@amd.com>
Cc: suravee.suthikulpanit@amd.com, will@kernel.org,
robin.murphy@arm.com, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org, ming.shu@amd.com
Subject: Re: [PATCH 0/2] Fix illegal access in IOMMU debugfs
Date: Tue, 31 Mar 2026 22:58:27 +0800 [thread overview]
Message-ID: <59a44055-1541-4c98-8768-3ff91ed3a984@linux.alibaba.com> (raw)
In-Reply-To: <yrbucydywdvk5zsvbnmxvz5dtmomw5p5vmnbs7prarffqsmgn5@3twhzcpcyxlv>
I am very willing to participate in the upstream community feature review.
Thanks.
在 2026/3/27 16:29, Jörg Rödel 写道:
> On Thu, Mar 19, 2026 at 03:37:52PM +0800, Guanghui Feng wrote:
>> In AMD IOMMU debugfs,
>> 1. set the device, address, and other information to be accessed
>> 2. After verifying the legitimacy of the device, address, and other
>> information in step 1, access and obtain the information
>>
>> However, before actually accessing the device, invalid device or address
>> information might be set again after the legitimacy verification in step
>> 2, thus triggering an unauthorized access issue.
>>
>> Guanghui Feng (2):
>> iommu/amd: Fix illegal device-id access in IOMMU debugfs
>> iommu/amd: Fix illegal cap/mmio access in IOMMU debugfs
>>
>> drivers/iommu/amd/debugfs.c | 63 ++++++++++++++++++-------------------
>> 1 file changed, 31 insertions(+), 32 deletions(-)
> Applied, thanks.
>
> Vasant, this patch-set fixes pretty serious issues. Can you please further
> review the AMD IOMMU debugfs code to make it more robust and secure?
>
> -Joerg
prev parent reply other threads:[~2026-03-31 14:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 7:37 Guanghui Feng
2026-03-19 7:37 ` [PATCH 1/2] iommu/amd: Fix illegal device-id " Guanghui Feng
2026-03-30 9:03 ` Vasant Hegde
2026-03-19 7:37 ` [PATCH 2/2] iommu/amd: Fix illegal cap/mmio " Guanghui Feng
2026-03-30 9:10 ` Vasant Hegde
2026-03-27 8:29 ` [PATCH 0/2] Fix illegal " Jörg Rödel
2026-03-31 14:58 ` guanghuifeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59a44055-1541-4c98-8768-3ff91ed3a984@linux.alibaba.com \
--to=guanghuifeng@linux.alibaba.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.shu@amd.com \
--cc=robin.murphy@arm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=vasant.hegde@amd.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®