From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 035EEC433F5 for ; Sat, 2 Oct 2021 15:38:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D076961002 for ; Sat, 2 Oct 2021 15:38:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233518AbhJBPkX (ORCPT ); Sat, 2 Oct 2021 11:40:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233413AbhJBPkW (ORCPT ); Sat, 2 Oct 2021 11:40:22 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 166E8C0613EC for ; Sat, 2 Oct 2021 08:38:36 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id g193-20020a1c20ca000000b0030d55f1d984so2582067wmg.3 for ; Sat, 02 Oct 2021 08:38:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=N1Aj2OywXyCVGc5VDMRLgqzC/RqrKIKrJwr01hz70jc=; b=LIwOO/8oWlry6PTKkW5wAdU92GqbhhbTwgMbHrk/qWtIlWVCjW3qKQDPG7sQkCJkRd FVzLlEtBM+Odabu0WHFiOJJC4S3p32k7z2w9uPJ0ijxjRYmWZyND8PG95sWehpnjZSCJ ZKqidXLFgKNjkBiYMpU+KRWH+x3SXQdJv9uoMIdFS4fK8TE8lncHkwJejEpq8bnukelw AUK1i6fAwPlxeQ0/8Ukaxea7RkW1YALXado4U55oMNiFmQY6bjSw/DRuV/gjk6Zi5Gba ty7O7+4+BsZDPGH3aGoGLK92ht/Ec//RD223T5BI+qaIkOy5fZ862QgFc8B7DQpH+9M8 rJrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=N1Aj2OywXyCVGc5VDMRLgqzC/RqrKIKrJwr01hz70jc=; b=63iNjxRk+2qutn+th3lvWR0TbWAjyMzmGCEuM9ELCKTHdc8Q6lsHBtqBo7ApBY+pGN iypPwjEmfFrT1t4GyVME2n/vzmbFoL+cw6nbWfVPo0Zwy4y2p15WK9tT8kZhDAMUyP99 Jj2bb/hMeTiQSF7mRVTQWSJ6BQ+KuKu7aUferyaOeNZyC4hcC5gU5ZH2Gm3ImDJL7rDK kM3NNPqTbq2UmfUHm0cDQ46r+ZNXCKxJh7cU12r9FfV+WJ7gSTdTqdwOpDNdRaHHBmVb Hfwc2/whTKYjQXuln8XWg68686Qf+h/S2ONLxZaRHGHiK7Bys5x4BpTHxmfSt46G4HkT eO3g== X-Gm-Message-State: AOAM533weokPUrHlAuILN84XZLu+jaks3nwSkSFdspeq8YIK4yT7GWp3 BOvsKDw11ncIPlZU4pIFQOM= X-Google-Smtp-Source: ABdhPJz+2ZTuQKZwiRnzGr1fWSdkcOAh1MpGBxpj/UNMTIpngjic660VZAqVdn3NUifKHk+YJp63gA== X-Received: by 2002:a05:600c:4fd3:: with SMTP id o19mr10135726wmq.134.1633189114500; Sat, 02 Oct 2021 08:38:34 -0700 (PDT) Received: from ?IPV6:2a02:8108:96c0:3b88::5d0b? ([2a02:8108:96c0:3b88::5d0b]) by smtp.gmail.com with ESMTPSA id j11sm4897347wru.11.2021.10.02.08.38.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Oct 2021 08:38:34 -0700 (PDT) Message-ID: <59ac1835-2afd-cd7a-d073-5c5d2bb02805@gmail.com> Date: Sat, 2 Oct 2021 17:38:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Subject: Re: [PATCH] staging: r8188eu: core: remove unused variable pAdapter Content-Language: en-US To: Saurav Girepunje , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: saurav.girepunje@hotmail.com References: From: Michael Straube In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for you patch Saurav, just some minor style issue. On 10/2/21 17:13, Saurav Girepunje wrote: > Remove unused variable pAdapter in Efuse_Read1ByteFromFakeContent. > > Signed-off-by: Saurav Girepunje > --- > drivers/staging/r8188eu/core/rtw_efuse.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_efuse.c b/drivers/staging/r8188eu/core/rtw_efuse.c > index 801887f497cf..d33a5b3b4088 100644 > --- a/drivers/staging/r8188eu/core/rtw_efuse.c > +++ b/drivers/staging/r8188eu/core/rtw_efuse.c > @@ -28,8 +28,7 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0}; > #define REG_EFUSE_CTRL 0x0030 > #define EFUSE_CTRL REG_EFUSE_CTRL /* E-Fuse Control. */ > > -static bool Efuse_Read1ByteFromFakeContent(struct adapter *pAdapter, > - u16 Offset, > +static bool Efuse_Read1ByteFromFakeContent(u16 Offset, > u8 *Value) There is no need for a line break here. ^ Other than that looks good to me. Thanks, Michael