From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58CAA367286 for ; Tue, 2 Jun 2026 09:57:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780394264; cv=none; b=CBeUF/bNM2AqwXdaiVAj7SAxb5luL9IF+Uycyqu51409AkuE4rG4+ZPREr/ioU4vsUZwmBVsknB46F2vIyefPL9w+Z53ePy9oPbfiV/et/mW2QsI5DAKrU/69j7aLwPo7furPivanhhr/QgH92jlcuV5HOLdM+XCkuO38nwAdRQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780394264; c=relaxed/simple; bh=FaoGWORjfmLsGMc7hDkNh5+9Vx8EZp+wsnO6iKrytRg=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=EpROPnMWX7pZhYFD6XckHB8l82cmicaZMg3gileHigCZLxqtBvlWdRgWTBcljcbzNyv0JKKlBMHGoiFIRRJMrJFTk63c6KonzyYvuOQ72dktZMlYzKlvtXpI7U4+Ajs11IgITgKaPdKTEkgeAmEqkgAw82jQRJAUav4Ill6l68k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ml0VidQa; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fOQOxioh; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ml0VidQa"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fOQOxioh" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6525ioZs1316228 for ; Tue, 2 Jun 2026 09:57:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gKrFZuQAG0a3aCq2kSwLA6HFHDfSA7RjUUcLjgAHyTk=; b=Ml0VidQalj29yJsu yjtrGcwJfFwI4bUKkiGPkA64nbJfMJPF7txo6qLnsHeKQRxXb/1WesRQl6mKOMbg S3ZZ0uUzvjIoHxHwATSbrl4fxCBZow+sBhWoHIQMYY6t1QHKleEVYnHHX4Fmsg2h HjGvTIYxiOUilZ3t9NJQR49EZF7epF8pYG3PBmdJxyRPLirUUMtSzPxcAfi49FQ8 lxjK+YLD92qCnNjbrWY8fttXN1oWlOvhV7/6DGiaxr6jirzJWgePxVPvkPX8cjr1 DtEobXlQ3CfNufWByrUTt4Qz+Um/WUJS5ILhPKgbeD9lwsxsJAEyIKqQEQhWihGR R1OQnA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ehs9vs1c8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 02 Jun 2026 09:57:42 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5174a236220so49479461cf.3 for ; Tue, 02 Jun 2026 02:57:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780394261; x=1780999061; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=gKrFZuQAG0a3aCq2kSwLA6HFHDfSA7RjUUcLjgAHyTk=; b=fOQOxiohX6243eZF7mJyRC8Y0bAWQGhvPqACyujLqzBK6TwoeRGdFUNWV99GU4dzgu KvXN0sETaRKRpt8YBftPBr4m109FIznwk11a8XgBwj6EEgkZwd7wTYfxbdI39OEyhzWJ j2XjsXv4zMLCrR27nnpIJ2JwhUyH7zBsHw0quPOudGK5EapjR3/jLACCcInB0FKWqf/F zpn/BHWIWNXTTgGRiqzVhic5YBUOoiUHiA8MR03SBnO6R90r0WxZHOquFlG03GuDjaiu AUUz8avQLqBppFNogGzdeOepGsGcnEVkmy70J7lPAoJc1GjjX9ijdAKtV9fZny1IzTgV v+Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780394261; x=1780999061; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gKrFZuQAG0a3aCq2kSwLA6HFHDfSA7RjUUcLjgAHyTk=; b=itHPeBhfGZnBvV3Lab13nMk1vC3peq28dXDtRRzpbIfFik4rUel/sZDDvDbvT0lfdM zrhYty/g+/y6KhtWgLfc8J20tWLTW6OULOW2nZmdabPGinVIjLuOZoyZXBIw00U2KxUe XHkQUF5wIHS8U+iukXRK6Edi6fwnkcBtiSb3LUv40LXgdD7fQLaGi4YFzGPKq0zkaAfy MpCaU8izsPT+gq+BOq5uuAHbfeiU/fVaS9/GqW3MhEl2447Ov5K3c1GRBD58JQbjHCQj IMPqQTjPVcwySw0suufXjJgDpAK7Goz/H0EKRM8pphDMgSmhI6vi7Qd0uAYp8VcKvDPI ZbTA== X-Forwarded-Encrypted: i=1; AFNElJ9PipWuSG782JJc5vyS+ecpnJ+FPr+PArZcZZg6afChONwBSPdEH4c9pouOflOXw+KcHq3nci1s9RyFoXE=@vger.kernel.org X-Gm-Message-State: AOJu0YxroYXCBFDvWQjXIdQp6k+v89Q3Hrlf6/nuBX/5MJM+kWeVf40V rBQQDXKQTmfn/1KhpxMqn3Q2tULACW6X/mo+n3LsWNom1SR/9fGBdrLdRIo3Dr9fXxg2afZt4O1 ScEcl4H0EiOXjCCPCeJGlO3/UfFsjPAwvTSP4V2fP1tBNEBnmjO+gxTcX1mUOO5Ed9x4= X-Gm-Gg: Acq92OFZrs2fok4+8UVM5/xlAq78xmP3bL/MCqrwO2BPsIKlqtP53Xc2LDQUAvAhBeQ 5IEjicHa141ZBWn0oB+UG6adjKjQU69Y+DPrTJ6wimLZ6AQ+GTyHds15ojLG7+q03q+5HGbDoJL b5GrkNFQ/U2RWqB3UXx3jcvkRHJrLXBEuPLqYX6VHuLRrVqptwuIEON+HVoyQTfzz2sSy9cJQyB rkWLSUnPbW047NzcoiR8xU/ZvgTiX0LIyzT+CXtMQHAnW2YqChODrLX0j4i8DfyLhzgsQDqfScx KOwEJk6pMac0RjbdoJX0k+AGwzxI2YqhXU7BFnOppkt8xh6PXiGp6WVV3KJjyGsfdvNUY9CQjVp UUudtwdJyoNxCT00DvtKYvbpw5ydFH45OdlAAfwwIyaa2YPqxC/zlD9l7wd3AWibrNn60zO9370 mw X-Received: by 2002:a05:622a:790e:b0:516:e033:f5a8 with SMTP id d75a77b69052e-5173a8daddcmr155758471cf.59.1780394261424; Tue, 02 Jun 2026 02:57:41 -0700 (PDT) X-Received: by 2002:a05:622a:790e:b0:516:e033:f5a8 with SMTP id d75a77b69052e-5173a8daddcmr155758251cf.59.1780394260962; Tue, 02 Jun 2026 02:57:40 -0700 (PDT) Received: from [192.168.2.1] (146725694.box.freepro.com. [130.180.211.218]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490af0babdcsm37044295e9.0.2026.06.02.02.57.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jun 2026 02:57:40 -0700 (PDT) Message-ID: <59afecd4-7749-4be5-a261-a850634178b1@oss.qualcomm.com> Date: Tue, 2 Jun 2026 11:57:33 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] firmware: meson: sm: add stub functions when CONFIG_MESON_SM is disabled From: Daniel Lezcano To: Ronald Claveau Cc: Guillaume La Roque , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Mark Brown , kernel test robot , Neil Armstrong , Daniel Lezcano , Zhang Rui , "Rafael J. Wysocki" , Lukasz Luba References: <20260531-fix-missing-meson_sm-symbol-v2-1-1def8c3c169f@aliel.fr> <8c11a91b-cfbf-4b9c-a46f-907989bf8305@oss.qualcomm.com> <12d74340-0213-4f7e-a494-10ce147844ad@aliel.fr> <0c5033f7-1535-49e8-a502-426e54333496@oss.qualcomm.com> Content-Language: en-US In-Reply-To: <0c5033f7-1535-49e8-a502-426e54333496@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: t5d6jfknDukt7-aY9QLU63qZqA3LwsqB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAyMDA5NCBTYWx0ZWRfX6FdNbFZtB2kS vBWuH/klB2v8bx/0iFuebWTAi4RFxcrPs8IPlrR1r3/7DS9Iv+p1iu/1UwnXaT0SStU/6zYqabn 8/dzPt7StcacaUF/8qd/yUmgpcXBbd/bVbyrHMk+AuA5tAsHxo4fBz5IRq+YbYWxFCfMHhjTjut vRT3QUUDqf810uPrU8VqPmZJegOE/P3Qn8ZusFsRhjgbpeOs0xhzlcdDDjfH8MVCDIXOy0KxcN9 m6yagNob7779nonW6UEItturUP1g7nfvXRctcdAdMlPODkd8VLfOwxsxviXCiS6wM7pCdzECFI5 ZtjVi85t/iOEL1DWEwJwe4VFVvjmhBNvKy72KqJrnKb/NHQ09Ts7qcSnOd99PJABrFhav+w6xZU 9YfiFexaPcpASO+VCY1hZYLrw/tSAXzsTer/3WgrCbrXYBXsbQS+o2OsU7fgkSjPDdEOtPAL0Aq DCs2ilCr0jcYS18FPXA== X-Authority-Analysis: v=2.4 cv=NYfWEWD4 c=1 sm=1 tr=0 ts=6a1ea916 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=uw/3876vWhRnNVL35W6mqQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=Fuur4Mi3Lvfw3V_heQcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: t5d6jfknDukt7-aY9QLU63qZqA3LwsqB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-02_01,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 phishscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606020094 On 5/31/26 21:58, Daniel Lezcano wrote: > On 5/31/26 19:49, Ronald Claveau wrote: >> On 5/31/26 10:41 AM, Daniel Lezcano wrote: >>> On 5/31/26 09:51, Ronald Claveau via B4 Relay wrote: >>>> From: Ronald Claveau > > [ ... ] > >>>> +#if IS_ENABLED(CONFIG_MESON_SM) >>>> + >>>>    struct meson_sm_firmware *meson_sm_get(struct device_node >>>> *firmware_node); >>>>    int meson_sm_get_thermal_calib(struct meson_sm_firmware *fw, u32 >>>> *trim_info, >>>>                       u32 tsensor_id); >>> >>> Do you really want to compile meson_sm as a module ? >>> >>> >>> >> >> I don't want, but if I send a patch to change tristate to bool, it will >> raise a warning because 'm' is not valid. >> If it is accepted to ignore this warning, I can send another patch. > [ ... ] > Compiling the firmware as a module means it must be loaded before the > amlogic thermal driver, right ? Where is the dependency declared in the > module ? > > If the sm_meson is in the platform, it should be selected as part of the > platform's component. No need to have an option for that, no ? The questions remain and PR is approaching ...