mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Willy Tarreau <w@1wt.eu>
Cc: Zhangjin Wu <falcon@tinylab.org>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	thomas@t-8ch.de
Subject: Re: nolibc patches, still possible for 6.5 ?
Date: Thu, 8 Jun 2023 09:40:11 -0700	[thread overview]
Message-ID: <59affcbb-94e0-49ee-bd53-7aa69fbe3929@paulmck-laptop> (raw)
In-Reply-To: <ZIGPpYSDQAHaDZP0@1wt.eu>

On Thu, Jun 08, 2023 at 10:21:57AM +0200, Willy Tarreau wrote:
> Hi Zhangjin,
> 
> On Thu, Jun 08, 2023 at 04:13:37PM +0800, Zhangjin Wu wrote:
> > > I rebased the branch on top of 6.4-rc5 and got the same. I'm building
> > > with gcc-11.3.0 from kernel.org. I'm not sure whether this comes from
> > > my build environment or recent changes to the kernel, but I'm sure I
> > > haven't seen that error during 6.3-rc cycle. However, given that
> > > Zhangjin seems to have successfully built it for riscv, there might
> > > be something odd on my side.
> > >
> > 
> > Sorry, The reason is that to speed up the kernel build+nolibc tests, a
> > local small config was customized for the first report,
> 
> You don't have to be sorry for this! The more diversity in configs, the
> more bugs are discovered before they hit users.

And I couldn't agree more!  Again, thank you both!

							Thanx, Paul

> > it may not
> > trigger the above issue, in the later report about the v4 rv32 compile
> > support [1], I did test 'run' target with the default defconfig and
> > reported the same failure as bove, this is the note I pasted there:
> > 
> >   ---
> >   Did compile test for aarch64, rv32 and rv64, include run-user and run.
> > 
> >   Note, this is required with the default config from the
> >   20230606-nolibc-rv32+stkp7a branch of [5]:
> > 
> >     diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
> >     index ce02bb09651b..72bd8fe0cad6 100644
> >     --- a/kernel/rcu/tasks.h
> >     +++ b/kernel/rcu/tasks.h
> >     @@ -1934,11 +1934,13 @@ void show_rcu_tasks_gp_kthreads(void)
> >      }
> >      #endif /* #ifndef CONFIG_TINY_RCU */
> > 
> >     +#ifdef CONFIG_TASKS_RCU
> >      struct task_struct *get_rcu_tasks_gp_kthread(void)
> >      {
> >             return rcu_tasks.kthread_ptr;
> >      }
> >      EXPORT_SYMBOL_GPL(get_rcu_tasks_gp_kthread);
> >     +#endif
> > 
> >      #ifdef CONFIG_PROVE_RCU
> >      struct rcu_tasks_test_desc {
> >   ---
> 
> Indeed, I initially didn't make the connection regarding this, because
> you mentioned the fix but not the problem, so I didn't remember to take
> any particular care about this.
> 
> > I have seen Paul have known the cause of the above issue in your later
> > discussion and you found a better solution to avoid such failures,
> > congrats!
> 
> Yes apparently Paul is aware of it so that's all what I wanted to make
> sure of.
> 
> Thanks!
> Willy
> 
> PS: I'll hopefully check your other series later today

  reply	other threads:[~2023-06-08 16:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-04 13:20 Willy Tarreau
2023-06-04 22:57 ` Paul E. McKenney
2023-06-05  3:26   ` Willy Tarreau
2023-06-07 21:03     ` Paul E. McKenney
2023-06-07 21:22       ` Willy Tarreau
2023-06-07 23:06         ` Paul E. McKenney
2023-06-08  4:32           ` Willy Tarreau
2023-06-08 16:37             ` Paul E. McKenney
2023-06-07 21:19   ` Willy Tarreau
2023-06-07 22:58     ` Paul E. McKenney
2023-06-08  4:36       ` Willy Tarreau
2023-06-08 16:39         ` Paul E. McKenney
2023-06-08  8:13     ` Zhangjin Wu
2023-06-08  8:21       ` Willy Tarreau
2023-06-08 16:40         ` Paul E. McKenney [this message]
2023-06-05 10:44 ` Thomas Weißschuh
2023-06-06  4:48   ` Willy Tarreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59affcbb-94e0-49ee-bd53-7aa69fbe3929@paulmck-laptop \
    --to=paulmck@kernel.org \
    --cc=falcon@tinylab.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=thomas@t-8ch.de \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®