From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753642AbdARQVj (ORCPT ); Wed, 18 Jan 2017 11:21:39 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:58228 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751713AbdARQVg (ORCPT ); Wed, 18 Jan 2017 11:21:36 -0500 Subject: Re: [PATCHSET v4] blk-mq-scheduling framework To: Paolo Valente References: <1481933536-12844-1-git-send-email-axboe@fb.com> <7A8A5078-E9B8-4EBF-BAB1-9E8EEBF3A043@linaro.org> <37570439-97C8-4009-B143-C5E78789A137@linaro.org> <2028A64C-40E5-403D-B5E9-05863E94B4C5@linaro.org> CC: Jens Axboe , , Linux-Kernal , Omar Sandoval , Linus Walleij , Ulf Hansson , Mark Brown From: Jens Axboe Message-ID: <59b134de-5d2d-5f16-3118-bdc16bc6e36b@fb.com> Date: Wed, 18 Jan 2017 08:21:20 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <2028A64C-40E5-403D-B5E9-05863E94B4C5@linaro.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [2620:10d:c090:200::2:76d6] X-ClientProxiedBy: YTXPR01CA0067.CANPRD01.PROD.OUTLOOK.COM (10.165.216.35) To DM5PR15MB1194.namprd15.prod.outlook.com (10.173.209.12) X-MS-Office365-Filtering-Correlation-Id: bcd66e33-eedc-423d-d3bf-08d43fbe0f63 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DM5PR15MB1194; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;3:7OafK7DojDzyhaEXF+jIfnLYM7NJJ6zH9M0TF2Sgm33yRZZ6lQGTmxg4wMquYmzqjBLNgwDB9aIUpozW3VFo2hUxeKU6qwVQUXSkJ7D0F0QMqIAUtVQ2DdRRppjjFeKpEWdxpN1nfaM+uLq80hTtbYeAEj3F+x4Oyt98MLMVbcjFcb44nvjlFoUw4e3lekAZFUHWso4bwSizCdYbl3IA3eZUAQvyQboSwtVRO5pLMXIhBzv24JlruVdJg3Z6WJeUIo7Dxy3+M/ZOc9X5NE6OOQ==;25:zqUsV9oZAsrMv6hsUmkC8kwWJg9kgBdtOxh/GtT0ej7jB7POybQn2mtjY8SQWkkh6FNOQdIMalFSWVC43eeQx8bDvBEl0PT6oJJ7o+hU2nA4RdBucdHIXsukBT5GsBuNnPb1SiMFVN8sS3c7t9SHhHO+bLdHcZXxHqVD9sHAt7r/O1cTyaMeTc+yD9+1XL5H5A0zSwELFHZuR2WQx28jq5RZZPG61txEkwZK3XPh3a7NQmXZsLTq7yO5lWJF1RbdOpho9BOfXJwq+yZ1NFy6WEPn1Rq1Zud9V//n86qlvkM9R25PcJZSR4D7OqMaWds5wq5gnuQj71F32v+6GP4GpCo+jDWVTODHdozCm5aOxC2E12Us4nFwfjLB+n3LRgw9n9a30vQ59VEhfp9JjzioqDUzZavS6h5CRn/VJBul/CWbEvjP/opfjEldTCv2STuF+9KTpDDo9y2P50FIEbBpAg== X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;31:Onoh0JgN75oRElySCo5u1NyVtLgmA4w6eHUZeEnxBp6POrwgmqYdppZu4qg1wgWOe/slS+bPNfyjK/roKVGgq7W9X1pwCaLC+YalTTRIKsQr1WoTYAKrzyPOKV+oUHd/7Md2hCL9A8TqAdusz0hg3JITSAKAyFkhiGyjuc+qGUB2j6OFPZqUw+y5OMRT+4PMFTU5yiiaKb5hGv//SThfHY8AI2swr/oYXhVtJo7Zo70v6yyEheUL60VVoXHQsIzZ/hse5SCc+tv0E4+zR9TlFA==;20:Wvuz8guT+gnffKMReoiUzrQFU0+nIqki72gSXwntHTXshBU1y7Eseete0GYzzCQD92lulO5EMaQpibbC4CFu5RGNyJvBVqLlZO13+QxLASz5hKqtDhdvrSFH4+adXG00HvsOr3ItsIueX1hOOGB6j0lGeHNJ+dKh4vspIvhhC/U0VHo4A8kx5ptLiKQ/RX2EQVFlQBR+idvKL9smwckDvPP1arjzWqkfqFUPBuUqVLOzLrlvOEx+U5t4bTFasDOQEldyXzX6EmiUmr6RwE20RxjtMRaIr+rgKiqnY9/lyhMsTPTbK7jOpcaerg08QQ23+rK0DFubiVaGIDWWslfWQUDLPT72PFAFWh+V1jzxWFKQVQ1vgWtRDiPyOqYLU6i0K3NhAbgsWSOjwOgXWJCNDrGHhAPjH44vCaoG+ok6pbxHQd7Gmg76tU5I6F0qtBpUED7kLxDXMqwOe2cvZ8PefS04iUx0I13tY5ug02sGLg/yBwoA2h2gggVcbHmN952b X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123560025)(20161123564025)(20161123555025)(20161123562025)(6072148);SRVR:DM5PR15MB1194;BCL:0;PCL:0;RULEID:;SRVR:DM5PR15MB1194; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;4:0xBfl7afghEhfUb0C6B/CAqLREE4f83n9gMFD6BYa9e3eylI7EUWNgqPfU94hfjSQPkDdpZlUOcIiXfk8uL4ZxEDJTpo4c+X8nE4cS3Tlq2el+hFqvSLaOpUjDqNhGfGifszKHmzU0zY7tjxUgiYldC2z9CJ4Wjh66TaNDoyAaqIT60qcolxBKAb2UGMq6XxFfc3W8hb2qctsVaf2E3gBVtsZ5NhAN2qpdyC++8Uz/v9wsVb7K7sQI5lJcUwP890zoPGolTLOo4c+Wq9Zf196sFk6PCNiZ+jz8iT+Iif6SuIIBq2RCKAeoUlXzOnQRjD1FDcSuNwVzGHep5iqM3Ccq2M2d7SSFYT7TJ5YUYahx96tGxebA9HvhK/5nCCyPu1N4KCOncIVnrprEEY8CEEMMvFgx015YeAqZFb9zBQf+0e4op3iTkixykJxqosnqoVEMQ3dCA2Q7sOv/QrXJ1LVvvMUSX/p0eGgFBpJYW0nlQvfY7MKxcvljXxwbtPOHhSnxvBvrCRThIVtrqO5+3v0NgLx1hAJ3MHcggnmjoq7b5DbV+UP8RN+TFATTEULyclZVbLOzWu5U2DuBS+TOw4Uw== X-Forefront-PRVS: 01917B1794 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(39410400002)(39830400002)(39450400003)(189002)(24454002)(199003)(377454003)(93886004)(7736002)(50466002)(54906002)(38730400001)(92566002)(305945005)(81156014)(6116002)(83506001)(33646002)(8676002)(47776003)(25786008)(54356999)(68736007)(64126003)(50986999)(81166006)(76176999)(229853002)(6486002)(23746002)(230783001)(65956001)(31696002)(5660300001)(2950100002)(65806001)(65826007)(110136003)(6666003)(230700001)(53936002)(2906002)(6916009)(4326007)(101416001)(86362001)(31686004)(189998001)(4001350100001)(36756003)(42186005)(1706002)(106356001)(105586002)(97736004);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR15MB1194;H:[IPv6:2620:10d:c082:1055:7b1:e7d7:fd6a:7d8f];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM5PR15MB1194;23:FWN2qJMSZU91V5wtb5OsZ7tzzR1j1S8elj3bh?= =?Windows-1252?Q?0Z7F+qGXqqta1NP4WDZ5rwWohd406LvrS6c3thBsXnh3oF50aXUD0sek?= =?Windows-1252?Q?XGIqonESFegdO2mDt647FboLEUfkhS6V00rojb5n13j2KupLF5LaFJ+I?= =?Windows-1252?Q?3C+h6gwVsM0UFdZHMDBXoAVWDqZPodlT0/O8Z2U22Ab+KnyTclcM/bht?= =?Windows-1252?Q?tOhULtUOIEe7hLKpYTsKMv1Kfai7hrbC3jy9zqPh1LKG8VDe8N5a8ktP?= =?Windows-1252?Q?tAUb7k4bps/QgeNAhHyUotkkU2SAqiAWiRjkCfHIkuGgh0+SLOAunKms?= =?Windows-1252?Q?FrUnhVGbUwGGWJAZ50e5Y4VpVnB8hZaVoQwsv7fKA45V3RSlAD8MY1X1?= =?Windows-1252?Q?Xy/6PFSSmZFBdjypp9h558hvw3gZNT97E/CwmKEJwnjmIukSH3My+HVA?= =?Windows-1252?Q?xlidJuCEtkCgi9TGsk5xHBIeEjL5dB+C0HnrG0q/UvxDtQu5BN3nPMsT?= =?Windows-1252?Q?YPOXKsLUewDD0fNONNUbdP6XQxBakRbUl+7sFM/bssGI0DZV2rK5gDKf?= =?Windows-1252?Q?lrRO5xOqaMalNJshZHtl1ulydhyNp3EZh7+C4qwjzw/ieyjc1hF5b4RP?= =?Windows-1252?Q?PtHuOllyBjA3XrgnwqgPrmu74rbfVGP+I6MKdiHSzoFhvDcWg0OUVJzj?= =?Windows-1252?Q?jWoZKFaXWHXGpOWzVHuh/h6kaGCzI3DKQjyrBBecOtKvbnLGk+QcqSIr?= =?Windows-1252?Q?ryDR6tVPC9eg3wDtB4la8ukjEf4vFpIVeUVvg0sM5lFowkBHkMSKIg1+?= =?Windows-1252?Q?zolxYSA3K277y32j//6/zlbn+y0ty6GvDAJOPWTLpsxwnkMKQgIbz2mG?= =?Windows-1252?Q?0ueaYIxBCL/Gk2s6XJ5z2A1J5fbo1FaybXo1dwez8H2rhCku+iuFjnj2?= =?Windows-1252?Q?+3npc4ARY/U2udfsYN233r99AcqMiZ2WUEXHUr/ihqvhs0xif8liNd53?= =?Windows-1252?Q?dJKRzAndbF0u5dFyIMa7LsZIZttGIBds6Pcx+mu3DfwSMQFKqHJgYRIi?= =?Windows-1252?Q?yRMk66e6O60ItGxT3fPui0Wk45gxK0NAB2PZ0sD1zmJBuyomXAdX60gc?= =?Windows-1252?Q?hFUZPDnmAbGiazu9Uc8Ct7NuKieqle7NX4HuNXD8jdOVWL/cBIPDKOCk?= =?Windows-1252?Q?1jP0zPxqq3OIdeq2TA867B2kKv6Y7hjJqTw0K5lOQGZXMH56VER3fAsc?= =?Windows-1252?Q?ULJ1VqW77ifbvVgsQHAX7WgHOXdlBx7kDBGz8I6tyj0DBNnHnMRvzNYK?= =?Windows-1252?Q?NCVh/kiKESwaB40soPtCaS1bmLKbXnsFtZbVmDlpHEHtDyLH5eO9lIpJ?= =?Windows-1252?Q?Jy4re4XEOLHxDETUjXzOxa7IdOtMomcKUbxh5IQe2X016+zrsZtxWe7W?= =?Windows-1252?Q?q8h2Q+iZILJ21loXV8VTWC/hX9iZ/f0jqzoQHAPVekB+AQYFRPUosGpL?= =?Windows-1252?Q?DuCv5hHsP1JlVn3jZ9Nx8HBtCGF?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;6:tN9RkBR1gdAILbVIBB4/l8MY5oy8ylsUNaec1UG69piapwkIZyNJxFRwM9UeEmxGmNKFu/OVEXYscFX+gXqiB6VkVezT37VhbZ3aQAguO7gd9sr4tLIxgXqLXOPKSjbPNv4gHkufUByD93B7lLrOURxsz2QmoverfukgXt6AOHLeH/2IRqJwRcu1PpkJoQJhd31rC78G/pzGEqjViSoX/4+LMw7bpn8OeY7hXEGs/4dzKMKjcp8qhM+DJOQp+XHR6+dTQZQ/5+9WarxhTicfn9fA69AfRiPfE2L8nFrlp7ttfmZxPdaSUSLjbKUcq2Hzwn2gt/NTpXGic/kJjN1pKzSvecXfiiGHRpJXbo5Xsbxv0dvewqCh/OPeQ0vgM26nTUyyh9rreDM8HK+Sums6JsGHs2fiUAum/3ZfNvTBMQI=;5:LazOhIB9Qk7gJYQG6AcsjJl0hWmtSpinDHNR8ei7j+Jah64fPHi80DqvA3H85fCA0jLciS7M1Z0WMwxx5zAGocF6u+PYQDELNzS7q0MpAfWQG0UlSlFEvQoiXuXg8nM836lbTioj2+96B12eZ0qvCAUNXRNGCfICZ5dp5oG3tOo=;24:TIU5N3R++Aj2Fjg1vK9Zj65SaMHUXfcyfURQXdNnrg9Ipo95T2I/oJ9ISXoZvvqGcPbwGn8Rw4ElEpQ/BZt4ptJk1JUw7YhR26mrxDu2xzE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;7:xJvk8f2zmPa84wAZ3AVTInfVdNQHmHxEhkVfnpuQIjQrDChFTWLw4hunoB/mWVsiVR+UJDFuwWb5AkikdyAeQ6K6PVLaP4texXPv0HN/nVF0+WF7f/YEQ0BLJ/HzmWLIe8KNoViAo5K06bIquzTukE0jUJhPTK77jCGf9tD9M7G5ue31Cv1zAAqxT44Q6Gg0UYcsDBg5qNOuTAfDzTwpD2F9ImNHU9V50NxBwLGEptwcjUxK5s2xtP4gdSCUtdPZSiMogxWnxakVqxMAHmX+R2iBr2thiyF8j10eDfmeJe/W1YhaEYYdiNBF5u+zOXdaeJbow3kXtvYAV/6CBf7McEaWI1J2ai9jZk1Yu9zgOaFsJKuG5r5pUGmOpEmoKV7EUIdg5JfMUwGQTuPQt+BdUHVVEM0dm/SxnhI1kuFXNeQMk9OtZ3mOS93dm1gvsnxCO0Y1AEFTmHdLNj36OedOxw==;20:wsIKKUREkMmJOykAuFnImK4hgg8x5qbfbN/ymzBRDwgRdF43TfeRPR7eHtmT9bvvO8pVqJsCfUaA9NEQvxuXKU7ESXLv4xIXxvsjUdUaKOFk3t300z0SctCSZrPcA7tDX3tAYjlqMg/7Ln1gf3DyMM488sprv23xr34J2s47aHo= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2017 16:21:24.9856 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1194 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-18_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/18/2017 08:14 AM, Paolo Valente wrote: > according to the function blk_mq_sched_put_request, the > mq.completed_request hook seems to always be invoked (if set) for a > request for which the mq.put_rq_priv is invoked (if set). Correct, any request that came out of blk_mq_sched_get_request() will always have completed called on it, regardless of whether it had IO started on it or not. -- Jens Axboe