From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6021C433F5 for ; Fri, 20 May 2022 07:53:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346666AbiETHxb (ORCPT ); Fri, 20 May 2022 03:53:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239607AbiETHx1 (ORCPT ); Fri, 20 May 2022 03:53:27 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50458EBA98 for ; Fri, 20 May 2022 00:53:26 -0700 (PDT) Received: from dggpemm500020.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4L4JpS3ZrRz1JC4J; Fri, 20 May 2022 15:52:00 +0800 (CST) Received: from dggpemm500013.china.huawei.com (7.185.36.172) by dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 20 May 2022 15:53:24 +0800 Received: from [127.0.0.1] (10.67.108.67) by dggpemm500013.china.huawei.com (7.185.36.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 20 May 2022 15:53:24 +0800 Message-ID: <59b140a2-fd9d-f5a7-85e0-9ff712e468df@huawei.com> Date: Fri, 20 May 2022 15:53:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v4] ARM: module: Add all unwind tables when load module Content-Language: en-US To: "Russell King (Oracle)" CC: , , , , , References: <20220401131534.241205-1-chenzhongjin@huawei.com> From: Chen Zhongjin In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.108.67] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500013.china.huawei.com (7.185.36.172) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/5/17 22:19, Russell King (Oracle) wrote: > Hi, > > On Fri, Apr 01, 2022 at 09:15:34PM +0800, Chen Zhongjin wrote: >> struct mod_arch_specific { >> #ifdef CONFIG_ARM_UNWIND >> - struct unwind_table *unwind[ARM_SEC_MAX]; >> + struct unwind_table unwind_list; > > Why is this not a: > > struct list_head unwind_list; > > because, from what I can tell, the _only_ member that is used in this > struct unwind_table is the "mod_list" member - so everything else is > entirely unused and redundant. > > Thanks. > Thanks for review! I have updated it to v5 with two other fixes. Also updated it on patch tracker. Best, Chen