From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Potin Lai <potin.lai.pt@gmail.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Patrick Williams <patrick@stwcx.xyz>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Cosmo Chou <cosmo.chou@quantatw.com>,
Potin Lai <potin.lai@quantatw.com>
Subject: Re: [PATCH] ARM: dts: aspeed: catalina: update catalina dts file
Date: Wed, 08 Jan 2025 11:17:36 +1030 [thread overview]
Message-ID: <59b47269065db207c2f0f8268d958b3f647fe05b.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20250103-potin-catalina-dts-update-20250102-v1-1-b0b7a523c968@gmail.com>
Hi Potin,
On Fri, 2025-01-03 at 09:42 +0800, Potin Lai wrote:
> Update device nodes list below for driver binding.
The devicetree describes the hardware. I prefer we keep references to
drivers out of the commit message here.
>
> - Add IOB NIC thermal nodes (TMP421)
> - 24-001f, 26-001f, 36-001f, 38-001f
> - Add FIO Remote thermal node (TMP75)
> - 23-001f
> - Add Power sensor node (MP5990)
> - 16-0022
> - Add main source fan controllers (MAX31790)
> - 18-0021, 18-0027
> - Add 2nd source fan controllers (NCT7363)
> - 18-0001, 18-0002
> - Add 2nd source HSC nodes (XDP710)
> - 20-0013, 20-001c
> - Remove all ina238 nodes, move to userspace
> - 16-0041, 16-0042, 16-0044, 17-0041, 17-0043
This seems to reflect the patch itself, which isn't terribly helpful.
The commit message should explain _why_ you're making the changes.
Can you please rework it?
Andrew
prev parent reply other threads:[~2025-01-08 0:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 1:42 Potin Lai
2025-01-08 0:47 ` Andrew Jeffery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59b47269065db207c2f0f8268d958b3f647fe05b.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=cosmo.chou@quantatw.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick@stwcx.xyz \
--cc=potin.lai.pt@gmail.com \
--cc=potin.lai@quantatw.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome