mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>, mathias.nyman@intel.com
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: xhci: dbc: Don't decrement runtime PM counter if DBC is not started
Date: Mon, 25 Jun 2018 11:25:59 +0300	[thread overview]
Message-ID: <59b5789b-a33d-6a61-af53-dc6feba8951f@linux.intel.com> (raw)
In-Reply-To: <20180625052004.15298-1-kai.heng.feng@canonical.com>

On 25.06.2018 08:20, Kai-Heng Feng wrote:
> pm_runtime_put_sync() gets called everytime in xhci_dbc_stop().
> 
> If dbc is not started, this makes the runtime PM counter incorrectly
> becomes 0, and calls autosuspend function. Then we'll keep seeing this:
> [54664.762220] xhci_hcd 0000:00:14.0: Root hub is not suspended
> 
> So only calls pm_runtime_put_sync() when dbc was started.
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Thanks, nice catch.
Adding to queue

-Mathias


      reply	other threads:[~2018-06-25  8:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-25  5:20 Kai-Heng Feng
2018-06-25  8:25 ` Mathias Nyman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59b5789b-a33d-6a61-af53-dc6feba8951f@linux.intel.com \
    --to=mathias.nyman@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®