From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A41D326945 for ; Tue, 28 Apr 2026 16:40:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777394411; cv=none; b=sCKfG40bk7XWLcEePkmsUNyfFGjwnbwHo02pm3pQ0tCAnhrSLihJXUJcX0H6Nl2i5ny6Q6LYHYXbtOanU8p6JplfiHELuMBaLmVRmqTMtjvC1r2EylovQ6gifGzo2/GBqynsHGlZB2SqUEpW2GhyH7UOHQSjVp8BdoyR2Vw7Oxo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777394411; c=relaxed/simple; bh=gKOXVeias1jedSZPTgvhaZ/9ErYEG/haW6BO6Usnqlg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iPdQqbZsvkdaNmK1cHViCNT9w6ayIuFgcad1N4P3Jpo6WTCojtwg3kAMlxPel0QmeMqoW1+ocm9k+PRQgJ/or4oGdiFHOUDR/rZ23/5Xp8ODNVy3K2h/OTPVV92TWHseiAerFtG76uIWBKvH8wrpfq2TAdKkV71fQNpDpMlkKYg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dZycoP5E; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RSvt3TUU; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dZycoP5E"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RSvt3TUU" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63SFslbX682663 for ; Tue, 28 Apr 2026 16:40:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jSwLJ8qoJ4k0g3ywERijbSEuPMU7O1XadiH6FINTJ3o=; b=dZycoP5EZv6A2AA0 VQ8Adz/TjFW+tgpAWctWG0d+1Su/2mqSOk9NmtaMfCd7slusLFt04ZOkYqGRs3qc nEpucIDhrx2mJHnNjfK9kF8Yr5+0TmPeDY2ucB/jj5qraMieBg1xYUQWy3lSpY7Y Xe+wgUKYnF5oHnHmXD6nvfvBsJcV1zmN9w9zwEGc/T7BZ1kY2FXDNTt1/hpLdMJj oRoIDgzKAC7U+GLLFCaXkoPE0B35gGjjxb/ilAP6gL018njd9IMurlJBQveEHM2z 5nPAfwZPUgZt9g5lEpEe10B38Qq8+9ivNEib58ZpfUAZ+2nDOzfegRBWwz54U4Bl YqCTBA== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dtdmbmjw7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 28 Apr 2026 16:40:08 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-82f71437218so7727926b3a.2 for ; Tue, 28 Apr 2026 09:40:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777394408; x=1777999208; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jSwLJ8qoJ4k0g3ywERijbSEuPMU7O1XadiH6FINTJ3o=; b=RSvt3TUUTGlXZP8L8nDSKr+9ZtBE1GrM7usBmYvK/uQKXy221g02A/nJ4XRog8Ei9W pxDrKcVku+bxDD5fBKcdM2q6s6WbvKYlXL/NtmeKZG0UnhZV1qhYR1M9ZLT7X3ZCOgjF L95cLjB1vZOJoOGBAFH3T3BVJTrQqLB3pn/e66eLCGkHEYystG4JK3W23q+n8jlCbX1d pwPMSpc1HRjMhjtCPkLWtNxL4Rn1FJOAmqknS/IIUivJ8C9ogH6BbuEKIvbbR4FU9vVc AjnD6mHqhoMRlNIXMq2Obr9ASqgQ24yoEsknzE+mP3Uv3rfL+2IsEpWbT2YIm9fwo8ZG Yv6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777394408; x=1777999208; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jSwLJ8qoJ4k0g3ywERijbSEuPMU7O1XadiH6FINTJ3o=; b=jAfFUCJSgeMgBeVyuzzUnv07cvqWnYo06eu+2NZEREABHYPVPfGXPIB4NM8aVcyuGx Rwqky0cA7Qylr5HoRw62ES5zoWIGlZbTcpe374A+6H/OYM/4i9YCtM/rgdg4hWpGGQ3Z ++y3QgXBGv7Oe4XJYXkVNmyr9AqXFg4lXsVoAkidGIup2b1LNlGvl3osg3FMB5kMOukD B0ccbo1lKcm6Dh98wx8IEULihmSO+V0qyo2qYcadDjuk5N5xLc57HVkUMx052zdeRUDL I1iDUQQwKGe5UfOFFlEIhlOUI97u8JauZgcEyKHkplEb7vPl4mdlPO+nwIj5Ljzak/0V xenQ== X-Forwarded-Encrypted: i=1; AFNElJ+dN54snVT1LrPSeAVwcgig1A/a6Unx9Bhn1A+Q4uhHaNiCKfs3MYtrqLzZDMu81ik+aRUE1Kq6Kuq2TwA=@vger.kernel.org X-Gm-Message-State: AOJu0YwKBSpObFiyIf9RpJZd7UPUMzvKjVFrlHw2kaYXN4inhq7kzteo UV7W6JDu3y1JRWQ4T410QLJc437KQ1mzVoy+oSoCk9F4ReacpiWPKJQrsPjjQ1VOSESnGlZ+V2K w4NCRL+K3XvcsV14LOLl/vr4Lf4HErK/0y3hqDQNaYkJgWPXfo19GUANuf8jnNpK+WpI= X-Gm-Gg: AeBDiesKi5kPSkkufetZMtrFLZlcf4BFmC05IEjLbG+bWk8q1ExwNc9yndtXlDQavBd zzi9cSW+x5j5Cqx0U9c63b2apeaYoy1djsBTTPWZDn1v0lSStQitcZEN35KkqoiITZB++uk6bVo F1mCYlxUV+ehau4h3MbNgHGGD/dAs9/Pe5itD7Bp8JT3yVKtndJrmJzck/3tJjcgYkNFtXYUXaO v9lE3uww3CpZKrd1EUWy8sktH4lmvk3VzXYgCM39BDKpz4JWdsiq9oi5iicyoHUjW7Y82fCG0OB b5ZMU+QRdOZdY9x9CuvFwxT9zROiNV4tPhJ64+X8KIoJTGqqZ5bzumRL6vZJqElsKxJ9JiPQdVe cOA1kR32VNHTbUs7p5SyndmhIsM6ZGBfEzD0HyfFA8A/3HyH0P2do0Q== X-Received: by 2002:a05:6a00:12c1:b0:82c:eb46:acb9 with SMTP id d2e1a72fcca58-834ddbec5d7mr3739920b3a.24.1777394408075; Tue, 28 Apr 2026 09:40:08 -0700 (PDT) X-Received: by 2002:a05:6a00:12c1:b0:82c:eb46:acb9 with SMTP id d2e1a72fcca58-834ddbec5d7mr3739883b3a.24.1777394407479; Tue, 28 Apr 2026 09:40:07 -0700 (PDT) Received: from [10.91.112.28] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-834dae00e40sm4009175b3a.12.2026.04.28.09.39.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2026 09:40:07 -0700 (PDT) Message-ID: <59bd0773-5c12-44d1-99b3-9ddfac8b1a4a@oss.qualcomm.com> Date: Tue, 28 Apr 2026 22:09:57 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm: Don't use UTS_RELEASE directly To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= , Rob Clark , Dmitry Baryshkov , David Airlie , Simona Vetter , Kees Cook , Andy Shevchenko Cc: Markus Schneider-Pargmann , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Konrad Dybcio , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260428144553.1103785-2-u.kleine-koenig@baylibre.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: <20260428144553.1103785-2-u.kleine-koenig@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: 2kBC8ykkbwQ0hEwt-SGyL2Kr0I1Ah2iv X-Authority-Analysis: v=2.4 cv=PcrPQChd c=1 sm=1 tr=0 ts=69f0e2e8 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=IpJZQVW2AAAA:8 a=EUspDBNiAAAA:8 a=7nqr_66b8YCbs3nQVBwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 a=IawgGOuG5U0WyFbmm1f5:22 X-Proofpoint-ORIG-GUID: 2kBC8ykkbwQ0hEwt-SGyL2Kr0I1Ah2iv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI4MDE2MCBTYWx0ZWRfX8f6GVxnEaFMg HOzlQg6JR6y8vnynHYq7/OxqV/k6G03hzLMXdmmlV8eq3jSDTZW4W6N6TnFYQdjhX9XENxqQnjI R5DPa5yQiznlCnTYqG21asABYMl53pvcrJivqL+U0778A46UX+cVCQBn+PZm9TnAnHbTzxvALMy RGzedgOPo+Wat9SBbvcIFs8BUEDWoZQMkj/x2KPY3a/OtPzK74ANl7KBUvuXDqGybJaDn+Nf4Jk mKiIF3SCdNVxOI8rBRjxziZHrsaBOE4/QT3IyRvGZ8e0FvZxGjy0bmoGPowJoQuIBkzQQf3PXgK k4XkKZrUqT5dH+wYBu/coHtgfmGc4IhuIPi8eWlnQixwnseUvSSgElgGYGGtJJSv7Giz350YYNM WuFnHsrptSkwcst12C6dMoxo7YeRNBpyhXpWJkiPVK+1GnR2d4uvkVi+aS4DMh/rRBbm00SLxFo GruC6+lQ05v2rzrbyIQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-28_05,2026-04-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 malwarescore=0 adultscore=0 priorityscore=1501 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604280160 On 4/28/2026 8:15 PM, Uwe Kleine-König (The Capable Hub) wrote: > UTS_RELEASE evaluates to a static string and changes quite easily (e.g. > uncommitted changes in the source tree or new commits). So when checking > if a patch introduces changes to the resulting binary each usage of > UTS_RELEASE is source of annoyance. > > Instead of using UTS_RELEASE directly use init_utsname()->release which > evaluates to the same string but with that a change of UTS_RELEASE > doesn't affect msm_disp_snapshot_util.o or msm_gpu.o. > > Signed-off-by: Uwe Kleine-König (The Capable Hub) Reviewed-by: Akhil P Oommen -Akhil. > --- > drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c | 4 ++-- > drivers/gpu/drm/msm/msm_gpu.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c b/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c > index 427d3ee2b833..c6eda3cf2e62 100644 > --- a/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c > +++ b/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c > @@ -5,7 +5,7 @@ > > #define pr_fmt(fmt) "[drm:%s:%d] " fmt, __func__, __LINE__ > > -#include > +#include > > #include "msm_disp_snapshot.h" > > @@ -79,7 +79,7 @@ void msm_disp_state_print(struct msm_disp_state *state, struct drm_printer *p) > } > > drm_printf(p, "---\n"); > - drm_printf(p, "kernel: " UTS_RELEASE "\n"); > + drm_printf(p, "kernel: %s\n", init_utsname()->release); > drm_printf(p, "module: " KBUILD_MODNAME "\n"); > drm_printf(p, "dpu devcoredump\n"); > drm_printf(p, "time: %ptSp\n", &state->time); > diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c > index 930e54d1b0a7..3f3925b11eea 100644 > --- a/drivers/gpu/drm/msm/msm_gpu.c > +++ b/drivers/gpu/drm/msm/msm_gpu.c > @@ -13,11 +13,11 @@ > #include "msm_gpu_trace.h" > //#include "adreno/adreno_gpu.h" > > -#include > #include > #include > #include > #include > +#include > > /* > * Power Management: > @@ -196,7 +196,7 @@ static ssize_t msm_gpu_devcoredump_read(char *buffer, loff_t offset, > p = drm_coredump_printer(&iter); > > drm_printf(&p, "---\n"); > - drm_printf(&p, "kernel: " UTS_RELEASE "\n"); > + drm_printf(&p, "kernel: %s\n", init_utsname()->release); > drm_printf(&p, "module: " KBUILD_MODNAME "\n"); > drm_printf(&p, "time: %ptSp\n", &state->time); > if (state->comm) > > base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731