From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13616227B94 for ; Thu, 8 Jan 2026 03:42:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767843779; cv=none; b=Wg/sWoSUhwJAeUfMvVSqatqpTYEuuFuPJEayL6sLSDQgBbbf3/sbjTT6fnIGMRX8FsXDR3DPILZAImCMO965ZGsdiK9Qg6q6FCZ5I9L29d1pUl0wACKCcIO7sBvfeXEXrJlaYbbLzV/LEEG8bUkZ6joGQiacJQnSsprcnF8AlZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767843779; c=relaxed/simple; bh=NctJ8MPpll2bE+ZY5Z5JQ7iUEuw5Cp2KDSNIagPzCBw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=A+k4gQDQqc4LGEAOkL4QEgGn9QVupc6XT9d3liHJ9IRy4rOat52wH3GhneUeo479TGyKd+brAlF930Knu7IddmXIEXas41DmmodVIU541MGI3+dZtcS/kSYkpsHv5mlaF600iDEto4KBJSMaM8XDA6NT0adYpyvAw1K3q9gfVwk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pykfSlC/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=h+EDlvbV; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pykfSlC/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="h+EDlvbV" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 607H5U3p2453884 for ; Thu, 8 Jan 2026 03:42:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sU2Sk/joZdHWNbXOxz+NFQy9EA44nouEcmpGbgOYYBs=; b=pykfSlC/H0UqZGKC fwjQeUPoASsEXdEnuc0fifWNiQFr58KCxJlM9LZIRXzCXsGjDc3L6kxjZ9ggyvyG msyuA6lAcgkA5Hk3cAjK5jvdyq9uYjjIK2DcLlIEfcd9kngOQk8A7aFAAtRUzLGq 7LZjZfU9AIehJVg2/tiA1O6mSmgQ9srpeoNKsaU17OZAgJjDPUfB58yCQIZzL8pe 2gq0837HevwIjmHwK39cqW8/ww0ayMPM69MhRSmFzIQCc23aD+1wAQc5XcVVoTPa UfL4mUt26GWjmBYHb169dvmapcRsNmxApZEaWST9VVZO7BxmwOqD44XTH6MRUx/z eZ3FHA== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bhmnbk79t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 08 Jan 2026 03:42:56 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-7aa148105a2so2358053b3a.1 for ; Wed, 07 Jan 2026 19:42:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767843775; x=1768448575; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sU2Sk/joZdHWNbXOxz+NFQy9EA44nouEcmpGbgOYYBs=; b=h+EDlvbVKbUH+Jm8Dgu+6/L6PmKqwPm19/01XAaDNid90Jt7XpyhgwTECGh/3TbpPA EQhIepv6oY9gV69prqpEVmffhhOq3xhL81ThXKF82FptAwy8I1X31La8js+P2sr+iHHg 08SJf9dEuM6w86SvVgINd57zaLCTKcuP+1VedaH9yes9FnNmZKvpGD30iaIWyfJ0bRup RsWeklZ3IOBgaN3ELMNorelTdWvrItIEZ1j1Gg5787Ly/fnC8k70bcGAi3nIXYTBamxo YVf3qzozzg2YRd+2WX4BMdUF94wtQvDymPDNnsqs+GQCBadjijxvEG5PRYA6/hAagUci iWKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767843775; x=1768448575; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sU2Sk/joZdHWNbXOxz+NFQy9EA44nouEcmpGbgOYYBs=; b=ejD2ma1quc5vVSxBemtCbFXIPsOWSho7zwpqrTPR+4lj6Js83S4jtRGAhAiaNDw/4C vPSa6AjSijZ3l/tiGQVds608EPTa9mpBoIooo3dYrXGi3QAsRg92/r34PvzOraMVy+kj Chzxc1rChfolCTv1y/vU6dDlFzl7rSFZSbmAJbUtjnC0bc3YmNKHDg8WBt805whveo9Y bmGM16itQsT+IkHys7aKO+jUgPK3sP908rCo6AQb7e/ARwthvvLwQPdIn3eIoiZLlVL5 4rUJs2DKP22YZLcXSVcc17dTyIY0aatCCSdct9JthlZ7LuILVRWquprZkwN0rm1kcVFp TlrA== X-Forwarded-Encrypted: i=1; AJvYcCWVqFSt9QCLMC4l6nV7bPy6qIld26KJx0AhKncH/cxS49Tk6crGcagCVmYiA2D44jNWcfeGfv6f3Sw5KrU=@vger.kernel.org X-Gm-Message-State: AOJu0YwEOZbXw2NLLfqWkAGJ2q2EpJRt61N+CNMYPZ5njtYfoxm8zd3e IUtdeuVL3cY2Xn+NX1+9rVruYwlcQrvoVPJRhdsqIvOraYFrnDxLaKN97Z7ecTifzwKqc6DtrwT pxsXKB1W5+KMKBgBDS5vy1L+3WVRprHbYK+8/cExxwvMxNvHRh5wLTDCXjqc1smmbqG0= X-Gm-Gg: AY/fxX476BUaON5uorGHYsKwP/zUvGQHgST5U2vktQ+ujBt0kRsQF26/e/dLixxSt1C rjxDUaKrXIkIDLpfP7a7EwzhMdsGI+k9WIZKoVpfNc0PR3Hz1XbwrQ3PrKbr+O/ucpbV7UK2WLf IF1UvJfKsvHr6g6S5ybD1v7CO60jqmCw++VvN7lzVaTueuBGeaUpCGcz6oWHsfPj5WX1zJxN0sm ENTGYWncoiIJB+svu5h6JxgsP0KhyBfBER48Mb+tRhhDxEReRg1iuM+d7DRqCLvEIcW1Q6Ef9Vp Hncappj4PGQceIY9DJzOhfpeAHeJvOoM5y3W3lYNbH6P2cooboGUhzFrx6DoPG5Ec8XqR6zYILb CUr47RUE/IPt440jMdhNLGB/MHJSdByG0RYescasS X-Received: by 2002:aa7:9e0c:0:b0:81c:96b7:7fb6 with SMTP id d2e1a72fcca58-81c96b79317mr1202688b3a.35.1767843775547; Wed, 07 Jan 2026 19:42:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IF5UcW7dtR5CuRWrHBzONACXx8SFxOD4Rlopg1hIDigD6UL/526+Xs2slaNmtNS8CMz0wiGnA== X-Received: by 2002:aa7:9e0c:0:b0:81c:96b7:7fb6 with SMTP id d2e1a72fcca58-81c96b79317mr1202664b3a.35.1767843774883; Wed, 07 Jan 2026 19:42:54 -0800 (PST) Received: from [192.168.1.2] ([49.204.107.20]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-819c5de655bsm6175281b3a.60.2026.01.07.19.42.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jan 2026 19:42:54 -0800 (PST) Message-ID: <59be6427-1163-407e-9cfb-61fa258010e7@oss.qualcomm.com> Date: Thu, 8 Jan 2026 09:12:49 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] serial: qcom_geni: Fix BT failure regression on RB2 platform To: Dmitry Baryshkov Cc: Greg Kroah-Hartman , Jiri Slaby , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, bryan.odonoghue@linaro.org, andersson@kernel.org, psodagud@quicinc.com, djaggi@quicinc.com, quic_msavaliy@quicinc.com, quic_vtanuku@quicinc.com, quic_arandive@quicinc.com, quic_shazhuss@quicinc.com, quic_cchiluve@quicinc.com References: <20260107162610.1582626-1-praveen.talari@oss.qualcomm.com> Content-Language: en-US From: Praveen Talari In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA4MDAyMyBTYWx0ZWRfX7wKfsteDu5+z Q0dF3BnjozyT1MzLqjjITueSFExFgxZIIQy+jXSCcGyT/stzyW1KggBP4Uwys1LNDmnfo2jgcE9 auc9hOTkxGfyBZvtVOpHpCP64OGxsa5UkwVTGcQQLBi2/Qk9Oi4wtJ30t3qtZaBKfXtO3PPV+sX 9Tbq8LeeEFOF156qCprF7DNYGxq0amXknmAiiy8602MeK3IjAL3EYfceiSwb49I67Keb20ft+xh V/DHU/NG9vwN3GCVBXd/7zO8YYOZHDWenwO0+XbZOhReiDjnV1E/ZVu57fXYLPNnLIm0o8KGdtG ET/fyfYnwHcIWHg9nDekQhQsqIWiMLS8UIzqh1IcBtfTFe6E+3hLqoreJDWZ4cSexbrkBh7D+Ns ZxSU0213U7p+ne+2kY0H7O/oPEBHRpJ0bhcBDCXKxTKASub1oGZVdDhAje/GbW+InhDWWQwkSgC /+kEcbilHCKDcbqPelQ== X-Proofpoint-GUID: 5VzrxQR0Rwzy9Ao0aeMooteC76BnBxar X-Authority-Analysis: v=2.4 cv=eIkeTXp1 c=1 sm=1 tr=0 ts=695f27c0 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=+gEgXnvjvgnLECGlQBulyQ==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=WXs9VOiMqbt5e-qogh8A:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-ORIG-GUID: 5VzrxQR0Rwzy9Ao0aeMooteC76BnBxar X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-07_05,2026-01-07_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 malwarescore=0 suspectscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601080023 Hi Dmistry, Thank you for your inputs. On 1/7/2026 11:11 PM, Dmitry Baryshkov wrote: > On Wed, Jan 07, 2026 at 09:56:10PM +0530, Praveen Talari wrote: >> Commit 10904d725f6e ("serial: qcom-geni: Enable PM runtime for serial >> driver") caused BT init to fail during bootup on the RB2 platform, >> preventing proper BT initialization. However, BT works correctly after >> bootup completes. >> >> The issue occurs when runtime PM is enabled and uart_add_one_port() is >> called before wakeup IRQ setup. The uart_add_one_port() call activates >> the device through runtime PM, which configures GPIOs to the "qup_x" >> pinmux function during runtime resume. When wakeup IRQ registration >> happens afterward using dev_pm_set_dedicated_wake_irq(), these GPIOs >> are reset back to the "gpio" pinmux function, which impacts the RX GPIO >> and leads to Bluetooth failures. >> >> Fix this by ensuring wakeup IRQ setup is completed before calling >> uart_add_one_port() to prevent the pinmux function conflict. >> >> Tested-by: Dmitry Baryshkov >> Reported-by: Dmitry Baryshkov >> Closes: https://lore.kernel.org/all/20251110101043.2108414-4-praveen.talari@oss.qualcomm.com/ >> Fixes: 10904d725f6e ("serial: qcom-geni: Enable PM runtime for serial driver") > > The order of tags is odd. How can it be tested before being reported? > I'd suggest the following order: > - Fixes > - Reported-by > - Closes > - Tested-by > - Reviewed-by Thank you for your inputs. Will do it in next patch. Thanks, Praveen Talari > >> Signed-off-by: Praveen Talari >> --- >> v1 -> v2 >> - Updated commit text. >> - Added Tested-by in commit text >> --- >> drivers/tty/serial/qcom_geni_serial.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> > > With the tag order fixed: > > Reviewed-by: Dmitry Baryshkov >