From: "Arnd Bergmann" <arnd@arndb.de>
To: "Daniel Palmer" <daniel@thingy.jp>,
"Lukas Bulwahn" <lukas.bulwahn@gmail.com>
Cc: "Romain Perier" <romain.perier@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
soc@kernel.org, linux-arm-kernel@lists.infradead.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: mstar: remove unused config MACH_MERCURY
Date: Tue, 21 Mar 2023 10:30:21 +0100 [thread overview]
Message-ID: <59c05b36-3370-4d7b-b8cc-39d6dc36cdd0@app.fastmail.com> (raw)
In-Reply-To: <CAFr9PXmKsequA3V7QWC2fKQYZgaNRj+q3q=UOBLmg6wxYKiVYg@mail.gmail.com>
On Tue, Mar 21, 2023, at 09:33, Daniel Palmer wrote:
> Hi Lukas
>
> On Tue, 21 Mar 2023 at 12:38, Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>>
>> Commit 312b62b6610c ("ARM: mstar: Add machine for MStar/Sigmastar Armv7
>> SoCs") adds the config MACH_INFINITY and MACH_MERCURY. The MACH_INFINITY
>> config is used in the gpio-msc313 driver, but the MACH_MERCURY config is
>> never used to configure anything in the kernel tree.
>>
>> Remove the unused config MACH_MERCURY.
>
> Because work is still on going to push that stuff.
>
> nak from me.
The symbol has been unused three year though, and will
show up every time someone runs a script to look for
orphaned Kconfig entries.
I'd still prefer removing it now and only bringing it
back when you actually add the code for it.
Arnd
next prev parent reply other threads:[~2023-03-21 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 3:38 Lukas Bulwahn
2023-03-21 8:33 ` Daniel Palmer
2023-03-21 9:29 ` Dan Carpenter
2023-03-21 9:30 ` Arnd Bergmann [this message]
2023-03-21 11:21 ` Daniel Palmer
2023-03-23 7:26 ` Romain Perier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59c05b36-3370-4d7b-b8cc-39d6dc36cdd0@app.fastmail.com \
--to=arnd@arndb.de \
--cc=daniel@thingy.jp \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukas.bulwahn@gmail.com \
--cc=romain.perier@gmail.com \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®