mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Peter Kaestle <peter@piie.net>,
	Hans de Goede <hdegoede@redhat.com>,
	Mark Gross <markgross@kernel.org>
Cc: "open list:ACER ASPIRE ONE TEMPERATURE AND FAN DRIVER" 
	<platform-driver-x86@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: acerhdf thermal question
Date: Thu, 16 Feb 2023 09:57:43 +0100	[thread overview]
Message-ID: <59c24c3d-eb1e-cdee-3d2e-aa1dda5a96fe@linaro.org> (raw)


Hi,

the polling interval is specified and modified via a kernel module 
parameter [1]

The value is used to change the polling interval of the thermal zone, 
implying that is accessing the thermal zone device structure internals 
directly [2]

In real use case, is the interval changed at runtime? Or just when the 
module is loaded? If the latter, the interval can be passed to the 
thermal zone at init time without doing a polling change rate after the 
thermal zone started. In this case, we can remove the 
polling_delay_jiffies change in the code and fix the structure leakage 
in this driver.

Otherwise, I can add accessors to this field but I would like to prevent 
adding them if they are not really necessary.

Thanks
   -- D.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/tree/drivers/platform/x86/acerhdf.c?h=thermal/bleeding-edge#n792

[2] 
https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/tree/drivers/platform/x86/acerhdf.c?h=thermal/bleeding-edge#n359

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

             reply	other threads:[~2023-02-16  8:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16  8:57 Daniel Lezcano [this message]
2023-02-16  9:08 ` Hans de Goede
2023-02-16  9:11   ` Hans de Goede
2023-02-16 11:45   ` Paul Gortmaker
2023-02-18  0:18   ` Peter Kästle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59c24c3d-eb1e-cdee-3d2e-aa1dda5a96fe@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markgross@kernel.org \
    --cc=peter@piie.net \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®