mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Antoine Bouyer <antoine.bouyer@nxp.com>
To: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Cc: julien.vuillaumier@nxp.com, alexi.birlinger@nxp.com,
	daniel.baluta@nxp.com, peng.fan@nxp.com, frank.li@nxp.com,
	laurent.pinchart@ideasonboard.com, mchehab@kernel.org,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: Re: [RFC v1 07/11] media: Add meta formats supported by NXP neoisp driver
Date: Wed, 4 Feb 2026 15:04:38 +0100	[thread overview]
Message-ID: <59c53104-b120-467b-b232-81c2519e2da5@nxp.com> (raw)
In-Reply-To: <aYNK_fmqsDX_e8cd@zed>

Hi Jacopo

Le 04/02/2026 à 14:36, Jacopo Mondi a écrit :
> 
> Hi Antoine
> 
> On Wed, Feb 04, 2026 at 02:31:47PM +0100, Antoine Bouyer wrote:
>> Hi Jacopo
>>
>> Le 03/02/2026 à 18:11, Jacopo Mondi a écrit :
>>>
>>> Hi Antoine
>>>
>>> On Fri, Jan 23, 2026 at 09:09:34AM +0100, Antoine Bouyer wrote:
>>>> This patch adds new v4l2 meta formats definitions and descriptions used by
>>>> neoisp driver for the parameters and statistics buffers:
>>>>    - `V4L2_META_FMT_NEO_ISP_PARAMS` used for the legacy fixed-size
>>>> parameters buffer structure.
>>>>    - `V4L2_META_FMT_NEO_ISP_EXT_PARAMS` used for the generic v4l2-isp
>>>> extensible parameters structure, supporting a non-fixed-size buffer and
>>>> changeable ISP configuration blocks.
>>>>    - `V4L2_META_FMT_NEO_ISP_STATS` used for the legacy fixed-size statistics
>>>> buffer structure.
>>>>    - `V4L2_META_FMT_NEO_ISP_EXT_STATS` used for the generic v4l2-isp
>>>> extensible statistics structure, supporting a non-fixed-size buffer
>>>> and changeable ISP statistics blocks.
>>>
>>> Uh interesting, you have existing userspace that needs legacy formats ?
>>
>> Yes we do have some available here (version with extensible formats will be
>> the next one):
>> https://github.com/nxp-imx/libcamera
>>
>> Not in mainline, thought.
> 
> I see.
> 
> However I don't think the mainline driver should support both formats.

ok.

I'm fine with starting from a fresh version, extensible-format-only, in 
mainline. That would also simplify the patch series then, so as 
Documentation, and maintainance.

> 
> And looking at your libcamera branch, it seem it already supports the
> extensible version.
> 

Oh yes you're correct. I thought it started from 6.18, sorry for 
confusion. One more reason to move to extensible-format-only in mainline 
then: it is verified since a while without any regression compared to 
legacy.

BR
Antoine

> 
>>
>> BR
>> Antoine
>>
>>>
>>>>
>>>> Signed-off-by: Antoine Bouyer <antoine.bouyer@nxp.com>
>>>> ---
>>>>    drivers/media/v4l2-core/v4l2-ioctl.c | 4 ++++
>>>>    include/uapi/linux/videodev2.h       | 6 ++++++
>>>>    2 files changed, 10 insertions(+)
>>>>
>>>> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
>>>> index 37d33d4a363d..c797cf11be38 100644
>>>> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
>>>> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
>>>> @@ -1471,6 +1471,10 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
>>>>         case V4L2_META_FMT_C3ISP_STATS:         descr = "Amlogic C3 ISP Statistics"; break;
>>>>         case V4L2_META_FMT_MALI_C55_PARAMS:     descr = "ARM Mali-C55 ISP Parameters"; break;
>>>>         case V4L2_META_FMT_MALI_C55_STATS:      descr = "ARM Mali-C55 ISP 3A Statistics"; break;
>>>> +     case V4L2_META_FMT_NEO_ISP_PARAMS:      descr = "NXP Neo ISP 3A Parameters"; break;
>>>> +     case V4L2_META_FMT_NEO_ISP_EXT_PARAMS:  descr = "NXP Neo ISP ext 3A Parameters"; break;
>>>> +     case V4L2_META_FMT_NEO_ISP_STATS:       descr = "NXP Neo ISP 3A Statistics"; break;
>>>> +     case V4L2_META_FMT_NEO_ISP_EXT_STATS:   descr = "NXP Neo ISP ext 3A Statistics"; break;
>>>>         case V4L2_PIX_FMT_NV12_8L128:   descr = "NV12 (8x128 Linear)"; break;
>>>>         case V4L2_PIX_FMT_NV12M_8L128:  descr = "NV12M (8x128 Linear)"; break;
>>>>         case V4L2_PIX_FMT_NV12_10BE_8L128:      descr = "10-bit NV12 (8x128 Linear, BE)"; break;
>>>> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
>>>> index 848e86617d5c..5f4992452c66 100644
>>>> --- a/include/uapi/linux/videodev2.h
>>>> +++ b/include/uapi/linux/videodev2.h
>>>> @@ -889,6 +889,12 @@ struct v4l2_pix_format {
>>>>    #define V4L2_META_FMT_MALI_C55_PARAMS        v4l2_fourcc('C', '5', '5', 'P') /* ARM Mali-C55 Parameters */
>>>>    #define V4L2_META_FMT_MALI_C55_STATS v4l2_fourcc('C', '5', '5', 'S') /* ARM Mali-C55 3A Statistics */
>>>>
>>>> +/* Vendor specific - used for NXP NEOISP sub-system */
>>>> +#define V4L2_META_FMT_NEO_ISP_PARAMS         v4l2_fourcc('N', 'N', 'I', 'P') /* NXP NEOISP Parameters */
>>>> +#define V4L2_META_FMT_NEO_ISP_EXT_PARAMS     v4l2_fourcc('N', 'N', 'E', 'P') /* NXP NEOISP Ext Params */
>>>> +#define V4L2_META_FMT_NEO_ISP_STATS          v4l2_fourcc('N', 'N', 'I', 'S') /* NXP NEOISP Statistics */
>>>> +#define V4L2_META_FMT_NEO_ISP_EXT_STATS              v4l2_fourcc('N', 'N', 'E', 'S') /* NXP NEOISP Ext Stats */
>>>> +
>>>>    #ifdef __KERNEL__
>>>>    /*
>>>>     * Line-based metadata formats. Remember to update v4l_fill_fmtdesc() when
>>>> --
>>>> 2.52.0
>>>>
>>>>
>>


  reply	other threads:[~2026-02-04 14:04 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-23  8:09 [RFC v1 00/11] Add iMX95 " Antoine Bouyer
2026-01-23  8:09 ` [RFC v1 01/11] media: uapi: v4l2-isp: Add v4l2 ISP extensible statistics definitions Antoine Bouyer
2026-02-03 16:15   ` Jacopo Mondi
2026-02-04 11:07     ` Antoine Bouyer
2026-02-04 13:14       ` Jacopo Mondi
2026-02-09 23:00         ` Laurent Pinchart
2026-03-02  9:41           ` Antoine Bouyer
2026-03-03  8:48             ` Jacopo Mondi
2026-04-03  8:19   ` Jacopo Mondi
2026-04-07  7:37     ` Antoine Bouyer
2026-01-23  8:09 ` [RFC v1 02/11] media: v4l2-isp: Add helper function to compute extended stats size Antoine Bouyer
2026-01-23  8:09 ` [RFC v1 03/11] media: Documentation: uapi: Update V4L2 ISP for extensible stats Antoine Bouyer
2026-02-03 16:58   ` Jacopo Mondi
2026-02-09 23:16     ` Laurent Pinchart
2026-01-23  8:09 ` [RFC v1 04/11] media: Documentation: Add NXP neoisp driver documentation Antoine Bouyer
2026-01-23  8:09 ` [RFC v1 05/11] dt-bindings: media: Add nxp neoisp support Antoine Bouyer
2026-01-26 17:12   ` Frank Li
2026-02-05  9:43   ` Krzysztof Kozlowski
2026-02-16 13:16     ` Antoine Bouyer
2026-02-16 13:38       ` Krzysztof Kozlowski
2026-01-23  8:09 ` [RFC v1 06/11] media: v4l2-ctrls: Add user control base for NXP neoisp controls Antoine Bouyer
2026-01-23  8:09 ` [RFC v1 07/11] media: Add meta formats supported by NXP neoisp driver Antoine Bouyer
2026-02-03 17:11   ` Jacopo Mondi
2026-02-04 13:31     ` Antoine Bouyer
2026-02-04 13:36       ` Jacopo Mondi
2026-02-04 14:04         ` Antoine Bouyer [this message]
2026-01-23  8:09 ` [RFC v1 08/11] media: uapi: Add NXP NEOISP user interface header file Antoine Bouyer
2026-02-09 23:29   ` Laurent Pinchart
2026-01-23  8:09 ` [RFC v1 09/11] media: platform: Add NXP Neoisp Image Signal Processor Antoine Bouyer
2026-02-04 14:16   ` [RFC 9/11] " Markus Elfring
2026-01-23  8:09 ` [RFC v1 10/11] media: platform: neoisp: Add debugfs support Antoine Bouyer
2026-01-23  8:09 ` [RFC v1 11/11] arm64: dts: freescale: imx95: Add NXP neoisp device tree node Antoine Bouyer
2026-02-05  9:44   ` Krzysztof Kozlowski
2026-01-26  9:44 ` [RFC v1 00/11] Add iMX95 neoisp driver Michael Riesch
2026-01-28  8:17   ` [EXT] " Antoine Bouyer
2026-01-28 23:00     ` Michael Riesch
2026-02-03 18:37       ` Jacopo Mondi
2026-02-04 17:12         ` Jacopo Mondi
2026-02-04 18:30           ` Antoine Bouyer
2026-02-05  9:40             ` Jacopo Mondi
2026-02-09 13:19               ` Anthony McGivern
2026-02-10  0:20                 ` Laurent Pinchart
2026-02-10 12:20                   ` Anthony McGivern
2026-02-10 16:02                     ` Laurent Pinchart
2026-02-12  8:43                       ` Anthony McGivern
2026-02-10  0:03               ` Laurent Pinchart
2026-02-12 17:38                 ` Julien Vuillaumier
2026-02-23 12:38               ` Julien Vuillaumier
2026-02-23 16:52                 ` Jacopo Mondi
2026-02-24 19:01                   ` Julien Vuillaumier
2026-02-25  8:44                     ` Jacopo Mondi
2026-03-20 16:29               ` Antoine Bouyer
2026-03-23 13:18                 ` Jacopo Mondi
2026-03-24 17:44                   ` Antoine Bouyer
2026-03-25 13:23                     ` Jacopo Mondi
2026-02-06 20:51 ` Michael Riesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59c53104-b120-467b-b232-81c2519e2da5@nxp.com \
    --to=antoine.bouyer@nxp.com \
    --cc=alexi.birlinger@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=frank.li@nxp.com \
    --cc=jacopo.mondi@ideasonboard.com \
    --cc=julien.vuillaumier@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®