mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Julian Braha" <julianbraha@gmail.com>,
	"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, cjd@cjdns.fr
Subject: Re: [PATCH] mips: econet: fix unmet dependencies for ECONET
Date: Sun, 02 Aug 2026 19:41:45 +0200	[thread overview]
Message-ID: <59c5582d-6fc1-48d0-a5df-b3b6f58aa227@app.fastmail.com> (raw)
In-Reply-To: <20260802161555.491549-1-julianbraha@gmail.com>

On Sun, Aug 2, 2026, at 18:15, Julian Braha wrote:
> ECONET selects EARLY_PRINTK_8250, SERIAL_OF_PLATFORM, and SERIAL_8250
> without ensuring their dependencies, EARLY_PRINTK and TTY are met. This
> causes unmet dependencies:
>
> WARNING: unmet direct dependencies detected for SERIAL_8250
>   Depends on [n]: TTY [=n] && HAS_IOMEM [=y] && !S390
>   Selected by [y]:
>   - ECONET [=y]
>
> WARNING: unmet direct dependencies detected for EARLY_PRINTK_8250
>   Depends on [n]: EARLY_PRINTK [=n] && USE_GENERIC_EARLY_PRINTK_8250 [=y]
>   Selected by [y]:
>   - ECONET [=y]
>
> WARNING: unmet direct dependencies detected for SERIAL_OF_PLATFORM
>   Depends on [n]: TTY [=n] && HAS_IOMEM [=y] && SERIAL_8250 [=y] && OF [=y]
>   Selected by [y]:
>   - ECONET [=y]
>
> Let's select the necessary dependencies, TTY and EARLY_PRINTK, as other
> similar architecture options do.
>
> These unmet dependencies were found by kconfirm, a static analysis tool for
> Kconfig.

I think this platform has too many 'select' that are not helpful here
and should be removed instead.

> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index a06f24317306..2423a6050088 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -397,8 +397,10 @@ config ECONET
>  	select BOOT_RAW
>  	select CPU_BIG_ENDIAN

CPU_BIG_ENDIAN is automatically set here because of the
missing SYS_SUPPORTS_LITTLE_ENDIAN

>  	select DEBUG_ZBOOT if DEBUG_KERNEL
> +	select EARLY_PRINTK
>  	select EARLY_PRINTK_8250

There is no need to force EARLY_PRINTK_8250, you should be
able to build an ECONET kernel without any console at all.

>  	select ECONET_EN751221_TIMER
> +	select TTY
>  	select SERIAL_8250
>  	select SERIAL_OF_PLATFORM

No need to select SERIAL_8250 or SERIAL_OF_PLATFORM either,
both can be turned on in the defconfig.

     Arnd

  reply	other threads:[~2026-08-02 17:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-02 16:15 Julian Braha
2026-08-02 17:41 ` Arnd Bergmann [this message]
2026-08-03 13:12   ` Thomas Bogendoerfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59c5582d-6fc1-48d0-a5df-b3b6f58aa227@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=cjd@cjdns.fr \
    --cc=julianbraha@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®