From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lelvem-ot02.ext.ti.com (lelvem-ot02.ext.ti.com [198.47.23.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8722983A14 for ; Tue, 28 Jan 2025 05:57:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.23.235 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738043869; cv=none; b=oXquSfVIwR01lJ2iC9vva4Yo2uBjHwp36buQ7n0RRpV1N3/sJ5bmdSB9HYvs9NLXKNfCMOT8dzQYL2yppv/ixlpgS/qH5rrWhW4LGL2aETQCqd3qLrW9rjctKyYWgJkiLfJRa8F6EAkhTFBvXmdF9Fuhqlkj/iPLYVp28MVoYzQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738043869; c=relaxed/simple; bh=iMSOiUwfU+FLXi3bJuuiFtZTq51i6Ye2xoJUXM4O12w=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=qU8njZe2KpHnERZAds4/wuYpcWm0tfKZj6ShdQPIC4/oLJ2wMolJuu1UI+EHwXVWWbhn4WOtilPhZm9X0G2wQ6sURPalACkyCmKHHzE2X+BnBX5RgdpGE/Pf7/rM28kmbsJyGMt6EoooS1lKfr52YZGV6ZpMiWzniVx13EpWkp8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=KL5qjXvV; arc=none smtp.client-ip=198.47.23.235 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="KL5qjXvV" Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelvem-ot02.ext.ti.com (8.15.2/8.15.2) with ESMTPS id 50S5vN3Z1135210 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Jan 2025 23:57:23 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1738043843; bh=GRHN9naLj2rJ4nGo9FOnkbnTUItG3F+RSSngWidQHmY=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=KL5qjXvVeFA5RsI+3QLslXtRJ9ySUiNiCrr3XW62Ht1dUBj3nFdtmFls5vNSfCxmW OZMzvx0rchnxEHai+Ozt0ReU8xI02ybg/mrXBD2sGltDOw3Y8lUgmVgFkl2gJDU/94 VrHHSzUHEDW4Y/tXLGdboyjQXu1a3PdTLJnmW0hc= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 50S5vNmf068607 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 27 Jan 2025 23:57:23 -0600 Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 27 Jan 2025 23:57:22 -0600 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 27 Jan 2025 23:57:22 -0600 Received: from [10.24.68.181] (jayesh-hp-z2-tower-g5-workstation.dhcp.ti.com [10.24.68.181]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 50S5vHMq045270; Mon, 27 Jan 2025 23:57:18 -0600 Message-ID: <59c66b9a-9ced-434e-8e6d-626a1fa70abf@ti.com> Date: Tue, 28 Jan 2025 11:27:16 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] drm: bridge: cdns-mhdp8546: Fix possible null pointer dereference To: Alexander Stein , , , , , , , CC: , , , , , , , , Tomi Valkeinen References: <20250116111636.157641-1-j-choudhary@ti.com> <9431081.CDJkKcVGEf@steina-w> Content-Language: en-US From: Jayesh Choudhary In-Reply-To: <9431081.CDJkKcVGEf@steina-w> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea Hello Tomi, Alexander, On 24/01/25 13:38, Alexander Stein wrote: > Hi, > > Am Donnerstag, 23. Januar 2025, 17:20:34 CET schrieb Tomi Valkeinen: >> Hi, >> >> On 16/01/2025 13:16, Jayesh Choudhary wrote: >>> For the cases we have DRM_BRIDGE_ATTACH_NO_CONNECTOR flag set, >> >> Any idea if any other platform than K3 is using this driver? tidss >> supports DRM_BRIDGE_ATTACH_NO_CONNECTOR, so if K3 is the only user, we >> could drop the legacy !DRM_BRIDGE_ATTACH_NO_CONNECTOR case. Which would >> remove quite a bit of code, I think, and make the driver a bit more easy >> to understand (although I think it could use a major cleanup...). > > FYI: Not directly using it, but patch series [1] is at least touching > this file. I can't see any other platform using this. No one uses compatible "cdns,mhdp8546" and only K3 devices uses the wrapper compatible "ti,j721e-mhdp8546" Let me post next RFC version with legacy !DRM_BRIDGE_ATTACH_NO_CONNECTOR dropped. And the mentioned series only touches mailbox access function to move then to a common helper file. (So independent change) > > Best regards, > Alexander > > [1] https://lore.kernel.org/all/cover.1734340233.git.Sandor.yu@nxp.com/ > Warm Regards, Jayesh