From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32A4DC433DB for ; Tue, 26 Jan 2021 10:42:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF1A9230FD for ; Tue, 26 Jan 2021 10:42:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404087AbhAZKm3 (ORCPT ); Tue, 26 Jan 2021 05:42:29 -0500 Received: from out30-45.freemail.mail.aliyun.com ([115.124.30.45]:52867 "EHLO out30-45.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730965AbhAZCEM (ORCPT ); Mon, 25 Jan 2021 21:04:12 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R131e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=3;SR=0;TI=SMTPD_---0UMvltN6_1611626603; Received: from 30.21.164.77(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0UMvltN6_1611626603) by smtp.aliyun-inc.com(127.0.0.1); Tue, 26 Jan 2021 10:03:23 +0800 Subject: Re: [PATCH] mm/filemap: Remove redundant variable's assignment To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <08dc7237b44b9455ab095b44dc6969a1607b08db.1611544316.git.baolin.wang@linux.alibaba.com> <20210125152237.d3cfebac78907fb50ae5cbbc@linux-foundation.org> From: Baolin Wang Message-ID: <59c68a70-4938-709c-77f4-2a2aea5e269d@linux.alibaba.com> Date: Tue, 26 Jan 2021 10:03:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210125152237.d3cfebac78907fb50ae5cbbc@linux-foundation.org> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2021/1/26 7:22, Andrew Morton дµÀ: > On Mon, 25 Jan 2021 11:20:02 +0800 Baolin Wang wrote: > >> We've already set the variable 'i' 's initial value before using it, >> thus remove redundant previous assignment of variable 'i'. >> >> ... >> >> --- a/mm/filemap.c >> +++ b/mm/filemap.c >> @@ -2472,7 +2472,6 @@ ssize_t generic_file_buffered_read(struct kiocb *iocb, >> if ((iocb->ki_flags & IOCB_WAITQ) && written) >> iocb->ki_flags |= IOCB_NOWAIT; >> >> - i = 0; >> pg_nr = generic_file_buffered_read_get_pages(iocb, iter, >> pages, nr_pages); >> if (pg_nr < 0) { > > Matthew's patch series "Refactor generic_file_buffered_read " > (https://lkml.kernel.org/r/20210122160140.223228-1-willy@infradead.org) > changes all this code - I dont think the patch is relevant after that, > so I'll skip it. Ah, right. Thanks for letting me know.