From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Lukasz Luba <lukasz.luba@arm.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, sboyd@kernel.org,
nm@ti.com, linux-samsung-soc@vger.kernel.org,
daniel.lezcano@linaro.org, rafael@kernel.org,
viresh.kumar@linaro.org, krzysztof.kozlowski@linaro.org,
alim.akhtar@samsung.com, m.szyprowski@samsung.com,
mhiramat@kernel.org
Subject: Re: [RESEND][PATCH v2 4/4] soc: samsung: exynos-asv: Update Energy Model after adjusting voltage
Date: Tue, 26 Mar 2024 12:20:01 +0100 [thread overview]
Message-ID: <59d37960-cf19-4b10-802f-59d42496c133@arm.com> (raw)
In-Reply-To: <20240322110850.77086-5-lukasz.luba@arm.com>
On 22/03/2024 12:08, Lukasz Luba wrote:
[...]
> @@ -97,9 +98,17 @@ static int exynos_asv_update_opps(struct exynos_asv *asv)
> last_opp_table = opp_table;
>
> ret = exynos_asv_update_cpu_opps(asv, cpu);
> - if (ret < 0)
> + if (!ret) {
> + /*
> + * When the voltage for OPPs successfully
> + * changed, update the EM power values to
> + * reflect the reality and not use stale data
At this point, can we really say that the voltage has changed?
exynos_asv_update_cpu_opps()
...
ret = dev_pm_opp_adjust_voltage()
if (!ret)
em_dev_update_chip_binning()
...
dev_pm_opp_adjust_voltage() also returns 0 when the voltage value stays
the same?
[...]
next prev parent reply other threads:[~2024-03-26 11:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 11:08 [RESEND][PATCH v2 0/4] Update Energy Model after chip binning adjusted voltages Lukasz Luba
2024-03-22 11:08 ` [RESEND][PATCH v2 1/4] OPP: OF: Export dev_opp_pm_calc_power() for usage from EM Lukasz Luba
2024-03-26 2:51 ` Viresh Kumar
2024-03-26 8:29 ` Lukasz Luba
2024-03-22 11:08 ` [RESEND][PATCH v2 2/4] PM: EM: Change the em_adjust_new_capacity() to re-use code Lukasz Luba
2024-03-26 10:51 ` Dietmar Eggemann
2024-03-26 20:36 ` Lukasz Luba
2024-03-22 11:08 ` [RESEND][PATCH v2 3/4] PM: EM: Add em_dev_update_chip_binning() Lukasz Luba
2024-03-26 10:09 ` Dietmar Eggemann
2024-03-26 20:32 ` Lukasz Luba
2024-03-27 12:55 ` Dietmar Eggemann
2024-03-28 7:21 ` Dietmar Eggemann
2024-03-28 7:30 ` Lukasz Luba
2024-03-22 11:08 ` [RESEND][PATCH v2 4/4] soc: samsung: exynos-asv: Update Energy Model after adjusting voltage Lukasz Luba
2024-03-25 19:17 ` Krzysztof Kozlowski
2024-03-26 8:28 ` Lukasz Luba
2024-03-26 11:20 ` Dietmar Eggemann [this message]
2024-03-26 20:12 ` Lukasz Luba
2024-03-27 12:56 ` Dietmar Eggemann
2024-03-27 13:39 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59d37960-cf19-4b10-802f-59d42496c133@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=alim.akhtar@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=m.szyprowski@samsung.com \
--cc=mhiramat@kernel.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=sboyd@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®