From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1453158DA3 for ; Fri, 23 Jan 2026 17:39:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769189976; cv=none; b=Dy6spHvhePD7MkI7IPwA4byBVx2Lfjz44fxoXwSQTCMqsZ9sRmfgAvzsC3KUUGXWRvwvSN3D/ew/aUgfCByXD0Icrj0e0NlXjRUsMkRUpAmw3e1GesWl9Nz33fVG2ap0Lxw8q8erm8UKMVdmX8ZH9u/Taq4AOfCuJY/KAd6Yewo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769189976; c=relaxed/simple; bh=CtpBtEO531brHlTMl63p6vtgngWpWBQuxL3UXW1xcho=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WlzF3tTqkG5i7SUbxrBEC2GTONKmXhqFBdQE7ZRjWLA1rzWaDGvPvjP4hSRsdS9DkPkqpqADpZdot+fmDyxPw3Dteog90g/IeITN5cqfckDHYBfRBTza4olRmq3ZwO60Tun5AdeItkoSuLJvspfL+6zty2azeGGRVPszJLvOB/U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KYQgRrRs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TX8dTbFs; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KYQgRrRs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TX8dTbFs" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60NCrTJR1327308 for ; Fri, 23 Jan 2026 17:39:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8ByX8t5DOEZeBqvSgYjGH9zeJDq9CCU8Sa/IMepH+e4=; b=KYQgRrRsaNdqZnKo 9ApFejkSKbbaSx5mMtG5DXqBXlVtGvobuFgRAItmo0XL5zaksRWsUJz3mErPPwKN Ay71B0JRifpde4lt4DFdsWN/0qJILh2xZwedO1YwOlm81MVlCd1mnNxecyok7rw6 t4LNA1AxMEUoqk7TN2DlNQNoONXYAqaFa59/8yC8j3dSgecDYSfasQ5a/IdA5W7S jCOGWZmSOuyCVsd0dD1CIIZtvbugPUAnNhk0a/sKCQjgVEcPHtsY4eX8U7+VVw1L K7G0qScAfFKQHta4kPqAZfxUoRQhHfH4P8nesmPLxDNlNGQnRGerh7lF7L+VN2fu U7VyPg== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bv44ca7d9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 23 Jan 2026 17:39:34 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-2b74aff34efso1228267eec.1 for ; Fri, 23 Jan 2026 09:39:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769189973; x=1769794773; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8ByX8t5DOEZeBqvSgYjGH9zeJDq9CCU8Sa/IMepH+e4=; b=TX8dTbFsCFrgA25O2iX9Fc988D9DKftMd9LcdFS9FKWeoo6RNlJ/Sa77YrWomM34sF 3Wdba5jmCEERtyVWDVGTm1l1w2Cjc7nJzMgdKKHdStj6YgOGmILDB8Z15odJIROrfsEC mpvyko9YpO3g2fKJNw4wLOOcibcnDNrwxVzmGeSj9GniTC+oU3QIEbjLDgGqOSMewouJ DByiwTX2w/tMMaLGfGRvFq55IBKP9kmL8Nu2ZQIEYQ3B83o1PTIgVfP+oOxQnX1MXyuH VigwvFbDkRbbxyhbMMxbTR5oBu+Djc08zlpX3SNxYA3j4zKEyFbvViJTiCtIP01LExSl FIhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769189973; x=1769794773; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8ByX8t5DOEZeBqvSgYjGH9zeJDq9CCU8Sa/IMepH+e4=; b=LNZ666BnrsiBlAIEFApu1bMhlv5/O3MGzpcvlzWqNdLvc2yT9T9HrFOWKOAj5kA6sn 6lAzCm167MtE4Fj1QO8v/aIKzBeL9jyqaMe+XMXU/LoThwVl/2CzbtHelFG85bFjIpTE +/UMACM49jb3Z58T8hTucZC62JY98CylzgZD3E0ChkZ40pq99HvQiVupnQnuFvjZ4HT8 3z2yTeL7NG8UYLGGk0xBnGFwh4EjICaOtFwjtdJBPMmwipe2lZK4hrLtyCYETL6sc8KH 9SpvwaTrRdCaJ9Hg2bLux9pshnGiBH7A+5k1UsNeg7PaVn+QnCDYF17bHo6J60ofWcuG vj9A== X-Forwarded-Encrypted: i=1; AJvYcCVCYUKUr2QzzLKRuwXdPO0Vh+VAA7W7H4Yu2DcOg2rbM6I/ldoLqlIMzDEAJMKBwQhXwBIXh+LqM9NiCrA=@vger.kernel.org X-Gm-Message-State: AOJu0YxlHEYrpvfAknGk3OX+LBywP/+tlfqphWkQ3IUogARlj1U029A+ HFt2B56oH5CFuQXPblVKuSybi8ustmiUjGuJU4sJpQk78e6PuenQNQ+FI/z1ZqK5CZ8jmCBr4eZ O3vHAI7tx+z0lR++IiHbs+W0g0BtO4pf0BDE1SqVXyqDmwZZx/O/CEMz1B+x1wMJFVP5Ru21Va+ Q= X-Gm-Gg: AZuq6aLLax3i+IaETYyIaTZL/HUxDr0BaI+PWMEwmcJUS/Vlzi1NmHqGT/SRVWUsOwN GjlvzWD8CPaMkXpygYODfWKK/aik+mX/HHF7QSffqMdQ+MCX5WMOq/frUmtEq+vTu1yz2sHAhYr 62/8xmDzNKGQIIVcIEb+6td+N9QX6XwfZAWC095jtBEaygIjS9jLQ7lYakdVsdaxgPB5mVx9Eug ongCRTy2XlM9CmvIrYonCq8socMJ2sFLQV07WVB2IEkCiOkcQbgeRi4zs6R9yasbcIu+U0FpOlT O+DEULp2OPD2AnBN6bMu04JranA51vyJeochZtg5r+JGoIbH1Ew/ei0TBznvlbw6a4XpFNVOnFO k6V6leYjWOhT8TjsylBKL8/TbIb04jXt+MNnRtg+5/6yyJSxHtd40Tx4kQdPIfeD/XRu8ary0zT OT X-Received: by 2002:a05:7301:1697:b0:2ac:14e1:c67f with SMTP id 5a478bee46e88-2b739998979mr1464271eec.10.1769189972923; Fri, 23 Jan 2026 09:39:32 -0800 (PST) X-Received: by 2002:a05:7301:1697:b0:2ac:14e1:c67f with SMTP id 5a478bee46e88-2b739998979mr1464263eec.10.1769189972427; Fri, 23 Jan 2026 09:39:32 -0800 (PST) Received: from [192.168.1.3] (c-24-130-122-79.hsd1.ca.comcast.net. [24.130.122.79]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b73aa03ecasm3765297eec.27.2026.01.23.09.39.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jan 2026 09:39:31 -0800 (PST) Message-ID: <59dcb7dd-11fe-445f-a5af-6d46768203ce@oss.qualcomm.com> Date: Fri, 23 Jan 2026 09:39:31 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: ath10k: fix lock protection in ath10k_wmi_event_peer_sta_ps_state_chg() To: Ziyi Guo Cc: Jeff Johnson , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260123160244.262225-1-n7l8m4@u.northwestern.edu> Content-Language: en-US From: Jeff Johnson In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=TLdIilla c=1 sm=1 tr=0 ts=6973b256 cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=Tg7Z00WN3eLgNEO9NLUKUQ==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=h4soWA5Jhnv_6aMFX8gA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=Cr3pM4QKBJ0A:10 a=6Ab_bkdmUrQuMsNx7PHu:22 X-Proofpoint-GUID: 5Qx1isbhmrnO_np6n8-aOfUknjIySFrq X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIzMDEzMiBTYWx0ZWRfXxUJG+XtfaILW a6AnNvg9iCj8M+YldVfX3czdHChJcffRSZzrtdZnOjtpVYRit+54d3pxIEZgNqSrRDWr97YjNuq cL/btoa3qgMTGCnJYyYtEKq+Ttw355Ne+l8Up8gfjHGiG2B1z3JnS7Gku+HTLPn+WMSgpYhPcaE zpgV85//8CHckTMtKFhW9oHQMQDkljzbYULNQuO5r0dLBZSQzjlXFiQgEtHO8CiSpZJYRAq5uma jYe/VT8RI8BPeEpC8GYWc6f3Y+vh0PFfWotzA7LtAvEhGq2Qh/k2ivpwFYBMfrYAWfRqGFiE8Zv f93mkjATR4Z2t0pVkh43nvdwz7JOMayg4BewGRaUnYnmxbwnpS5xiTDONFKF5XXJDnlx+bf3WOq TF84NDnsVSdP4vq6W26kfS0WIMzsiQImlvDbNKFfyu97P23xX7ETqVL2UDJ64wQbYbskMWqEU24 cZ8L2qzYNSACHVFifNQ== X-Proofpoint-ORIG-GUID: 5Qx1isbhmrnO_np6n8-aOfUknjIySFrq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-23_02,2026-01-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 phishscore=0 impostorscore=0 spamscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601230132 On 1/23/2026 9:34 AM, Ziyi Guo wrote: > Hi Jeff,  > > Thanks for the review. I will adopt the second approach: remove the | > lockdep_assert_held()| and add the |spin_lock_bh()| protection. > > I will send a v2 patch shortly.  > > Best regards,  > Ziyi Please follow linux kernel e-mail etiquette: Don't top post Don't send HTML e-mail. https://subspace.kernel.org/etiquette.html