From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f225.google.com (mail-vk1-f225.google.com [209.85.221.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37D543FF885 for ; Wed, 20 May 2026 18:46:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.225 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779302767; cv=none; b=hQjqDCbYVVQUHjihdjcWMGTgki839NI2/Ki6aMFh6xayr3Lk8bzVVbEG7HbvH1DTP0eRaaork3EA0tOFYG8ayo6PRhqoE7SK+7sqaGyHhfvEUD4ejAejeXLjgIHCS/PV1tSC+K9v4V0AllmlBKMNp3/pDj8R1nI+RDc5J5UDpHY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779302767; c=relaxed/simple; bh=IEgOhX5mSlGgMwF6CJs9QGBb5c//pY837CoFBbgWLjI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LgKvk0FHgbshhy9MyMIxciqRJFQcGrnk4bWyBVRaBR9r6XV9SsEsvJ/iyuJ/XQgDthZoQV8Miu+NuB8k4Uplef7oR9dmLnQC3d4WETTDafwMKyUYrctCxZvYK3h3TE+PNTdgCGnPP/too5u/Ouasxie0co0R7LOn9b7Sk3hYxms= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=ctTuXHwj; arc=none smtp.client-ip=209.85.221.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="ctTuXHwj" Received: by mail-vk1-f225.google.com with SMTP id 71dfb90a1353d-5751a9020faso3971463e0c.1 for ; Wed, 20 May 2026 11:46:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779302762; x=1779907562; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=yz8WNPTLivvf8aO0NCQc1Y4S+bsvggq3/xlwaBZWzOA=; b=hCYK+FP1FyhtpXtAjpDKkbFZPBNAhshngjE4jB/t+zW67D55eeRzfZXwPXkAtDeuc8 NDnxwHZCvhTpGcZ8XlgGWBPCx29Hfoo8OHXYs05l4QrFJwQl9johxsRa1K1afWb9wk/A gQd8EEc3p/vMHHNlhyR80w+USUJWtpxC3999YdQX4LqKqlT60yYttIw7uPRw0fDZ38WD oyJTVss5CC4Hj1q80utGY5zVpVEHSMKCXZlqaadUaeNIikehQLLB37JfECW7zKAIJGSE caMtV5pGz5bpU7XCMR6QgZ3CL14j3hvCfOPxiSVTQ8XXEr3kX4GOxGlS78hIhRTB6VQL 2O9g== X-Forwarded-Encrypted: i=1; AFNElJ9cyLE9Nn8eFwAPuk68l+e3fREP7Snbhk0CgZ0SdHlDOq/UtkaabRJihFjto0/FQrTFk+Eyrossk61DNBo=@vger.kernel.org X-Gm-Message-State: AOJu0YyR16YUQoGyFD9fgmH0NNrl8uFw8zslI1IQ1VOLJPqUR1OehWF/ /txkycM8SqOkSdy7SnV+ZVFNyo2z3chTDYKFX9NE4vyxOI1OC966HTdGoz4es8iC3MGFIOgoQ9x IYtfMTjsG/4K11bztFj/kaTag+PpW2rLEhJPT7ioEYzggnO8poxgiUFd5SsbSNQ6gmB+Xq2Qyxa kX3uEFaRLbkKYYO2gJygvnSs02wSEFO6kGTewnJ0Nw0gmm6CtvVze+KbGYnJRAlAaiXH+U6voFU WabYHSUIntt+5a+IBjQzzgH X-Gm-Gg: Acq92OEJx8tmEZj4FM5a26f4QhQC/Ilkhgt61zdny2FAI/xE7/bv6QGs/aCCiz7FgUJ gDMzxecNJg75geV/37sW2UGLpkO8Kk5L1wxkEaSwkmrOEOCzt1NojBkHIdPGwQZgzwi1XIc0Jb0 hnOl39WwG/jKveqk9v/eVL1K/7q1Hbv07/b4XBggVuwFxDVeIBKOSrEn5w7EB643hHT9HHh9HYq 3Hqrj3vpt2+684p90+fPEKk4lNSj83twmbNpPLRfi9wkM8seqIw/SeJtq5qAQsAj2aAw2eu6U8j 5xFF6W2OV/UYcYm7omXHcHNXqkgSnTphiC2JWJlPPbqTa6CkDZC3Dwo4isiq5L4Ksvg+J6G8f7I 6d9AqFtzC2oEgy3rVbIf5rv+YGGiKMoHs/WeOtaVcS1WmaCqfQDuw99cAedxXWkWc19/XnJZDSw p6NDKhV4lVdYDnN162jvyiPwD3veunQeVHzFyXDv2Ptc6Ut0QjkNSp9p2Xs1UuXg== X-Received: by 2002:a05:6122:e16b:b0:57d:801b:f8b8 with SMTP id 71dfb90a1353d-57d801bffbamr6250913e0c.9.1779302762470; Wed, 20 May 2026 11:46:02 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-24.dlp.protect.broadcom.com. [144.49.247.24]) by smtp-relay.gmail.com with ESMTPS id 71dfb90a1353d-5760f5750casm1399794e0c.2.2026.05.20.11.46.02 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 May 2026 11:46:02 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-2ee1da7a13fso6411976eec.1 for ; Wed, 20 May 2026 11:46:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1779302761; x=1779907561; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=yz8WNPTLivvf8aO0NCQc1Y4S+bsvggq3/xlwaBZWzOA=; b=ctTuXHwjiEwLHDYK0cmw9W7MsHzoHq4SxYuF5718RCg8h53xzdyt/KVbgW6a1kQcx6 qGnfUo8n7YKn+WfJU2qFuQO4hc6sOoRfuNhG3mCJ6zX37xqMDW66iouGNWQSyxv10UQW 9kBkPvCxjAYEoHl4REQvFEhY7EwVxv7taDxxM= X-Forwarded-Encrypted: i=1; AFNElJ/whTbnChYfiy+sksM+av2RsVf0O+0hcljerfijs94cKimEZPh8lyIjllw005yLklNIL9lT7W8w5S1zTsg=@vger.kernel.org X-Received: by 2002:a05:7300:5b88:b0:300:255:22cf with SMTP id 5a478bee46e88-30398652e7emr12183198eec.28.1779302761025; Wed, 20 May 2026 11:46:01 -0700 (PDT) X-Received: by 2002:a05:7300:5b88:b0:300:255:22cf with SMTP id 5a478bee46e88-30398652e7emr12183176eec.28.1779302760431; Wed, 20 May 2026 11:46:00 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-304052f79ecsm6188546eec.11.2026.05.20.11.45.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 May 2026 11:45:59 -0700 (PDT) Message-ID: <59df32fc-59eb-429e-aca1-2c5a64c988fc@broadcom.com> Date: Wed, 20 May 2026 11:45:57 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] net: bcmgenet: keep RBUF EEE/PM disabled To: Nicolai Buchwitz , opendmb@gmail.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: justin.chen@broadcom.com, phil@raspberrypi.com, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260520184320.652053-1-nb@tipi-net.de> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20260520184320.652053-1-nb@tipi-net.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 5/20/26 11:43, Nicolai Buchwitz wrote: > Setting RBUF_EEE_EN | RBUF_PM_EN in RBUF_ENERGY_CTRL breaks the RX > path on GENET hardware once MAC EEE becomes active. RX traffic stops > flowing while the link stays up and the usual descriptor/RX error > counters remain quiet. In that state the MAC still accepts frames > (rbuf_ovflow_cnt keeps climbing) but RBUF no longer forwards them to > DMA, so rx_packets is no longer incremented at the netdev level. On > some boards the corruption ends up as a paging fault in > skb_release_data via bcmgenet_rx_poll on an LPI exit. > > Reproduced on Pi 4B (BCM2711 + BCM54213PE) and confirmed by Florian > Fainelli on an internal Broadcom 4908-family board with the same crash > signature. RBUF_PM_EN is not publicly documented. > > This shows up more often now that phy_support_eee() enables EEE by > default, but it also affects older kernels as soon as TX LPI is > turned on via ethtool, so it is not specific to recent changes. > > Always clear RBUF_EEE_EN | RBUF_PM_EN in bcmgenet_eee_enable_set so > the bits stay off across resets. UMAC and TBUF setup is left alone so > TX-side EEE keeps working. > > Link: https://github.com/raspberrypi/linux/issues/7304 > Fixes: 6ef398ea60d9 ("net: bcmgenet: add EEE support") > Cc: stable@vger.kernel.org > Signed-off-by: Nicolai Buchwitz Reviewed-by: Florian Fainelli Thank you Nicolai! -- Florian