From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753218AbdEENmy (ORCPT ); Fri, 5 May 2017 09:42:54 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:36599 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751837AbdEENmw (ORCPT ); Fri, 5 May 2017 09:42:52 -0400 Subject: Re: [PATCH v8 00/10] Qualcomm video decoder/encoder driver To: Hans Verkuil , Mauro Carvalho Chehab References: <1493370837-19793-1-git-send-email-stanimir.varbanov@linaro.org> Cc: Andy Gross , Bjorn Andersson , Stephen Boyd , Srinivas Kandagatla , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org From: Stanimir Varbanov Message-ID: <59e18457-118f-94fe-58c5-7a0567bcde15@linaro.org> Date: Fri, 5 May 2017 16:42:44 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hans, On 05/05/2017 03:44 PM, Hans Verkuil wrote: > Hi Stanimir, > > It looks good to me. I do think that patch 01/10 shouldn't go through > media. This might mean that we have to drop the COMPILE_TEST dependency > on the media driver until this firmware driver patch gets merged, which > is fine with me as long as this is clearly stated in the commit log for > the media Kconfig. Let me know what you want to do with this. OK, the best I can do is to drop COMPILE_TEST for Venus driver in this patch set and work separately on qcom_scm firmware driver patching. Thus I will repost v9 version next week. > > I also saw some comments for patch 05/10, but I'm not sure if that would > block merging this driver or can be fixed afterwards. I will prefix the exported symbols from venus-core driver as pointed by Sakari in next v9 version plus fixes for few signed-unsigned compare warnings. -- regards, Stan