From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30D5ADDCD for ; Tue, 16 Jun 2026 03:12:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781579534; cv=none; b=sE4U15jGg/+EvxNztgHS4bnBwn9B2Mh/ga/3OXJr5KschYNn9vK4dfPvpsBDeW9azmJ787lmtgDv8SUhrCGmLNtFYBtQQN1lUFvCH18KM808dhsL5AgTsWfBlZGbHiKVxX77vJm3iAEYUzrzpNfQoxmYtxMEP+5amO4NYjYfvHY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781579534; c=relaxed/simple; bh=JOXh2mZcIf8FA3J0bXLycxTL55zFawmQvef7Q2IJpTU=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=gTZboK+VDzcqZl+msXQUsvzzQ505/M4ZkgISHztaq/yDlQ4Nkkmf/rYQiaXUiyWUBpzlxYvAKX76+nLI/M43dLJ3z+SGMQ2G5D+XGCbcKaEWYR8Sf/Tc32+NZ79K7E94K5u2lJlaBB1jdVUeLVlpdnDj8T1ZuN0pImJ2sSUM3TY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=crbIPo0P; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="crbIPo0P" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F2D71F000E9; Tue, 16 Jun 2026 03:12:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781579533; bh=1daviKBTe3I0BPjWbMQ93JmV9BZKckBx+2gdvFdWuZ0=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=crbIPo0P/cZQ0OthV0YoAyt0hE1jsMkN9RnsNZekW5jl7ZWVi0CPb25OewlNf58KD IznUCGeCCKJSfw0KKnQr39s4Gmiuw+YvFOovPrcUGb5+qHEdpuWB2AaCEIrM7LG04/ MaDkBXc/CIzioURGWn8/i2VitUu2VhjxwGumqI5fksH4LaRjFWeB9R2vT8BpToBdzL B0PU4gS8FNrYrGfJHxmzwm5Wma498FzFRAKZenC+Ortze9UhIWqwvgxuFNpLLM5jpl OU9fzwCpk0JI8bMbDFhyI9UBoUVJpdWW3OQrgWuaQcW+2G6lV1tixZuBzad9ZCnE+r 1jeWMaXguJXNg== Message-ID: <59e4eeb8-ff3e-434b-844c-08038e1883a5@kernel.org> Date: Tue, 16 Jun 2026 11:12:10 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 4/6] f2fs: avoid unnecessary fscrypt_finalize_bounce_page() To: Jaegeuk Kim References: <20260615130822.2576088-1-chao@kernel.org> <20260615130822.2576088-4-chao@kernel.org> Content-Language: en-US From: Chao Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/16/26 06:14, Jaegeuk Kim wrote: > On 06/15, Chao Yu via Linux-f2fs-devel wrote: >> fscrypt_finalize_bounce_page() should be called only if we use fs layer >> crypto, let's avoid unnecessary fscrypt_finalize_bounce_page() in error >> path of f2fs_write_compressed_pages(). >> >> BTW, fscrypt_finalize_bounce_page() will check mapping of bounced page >> before retrieving original page, so, previously it won't cause any issue >> w/ fscrypt_finalize_bounce_page(), but still we'd better avoid coupling >> w/ any logic inside fscrypt_finalize_bounce_page(). >> >> Signed-off-by: Chao Yu >> --- >> fs/f2fs/compress.c | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c >> index caf522d667d6..aaa0813eabcd 100644 >> --- a/fs/f2fs/compress.c >> +++ b/fs/f2fs/compress.c >> @@ -1455,10 +1455,12 @@ static int f2fs_write_compressed_pages(struct compress_ctx *cc, >> out_destroy_crypt: >> page_array_free(sbi, cic->rpages, cc->cluster_size); >> >> - for (--i; i >= 0; i--) { >> - if (!cc->cpages[i]) >> - continue; >> - fscrypt_finalize_bounce_page(&cc->cpages[i]); >> + if (fio.encrypted) { >> + for (--i; i >= 0; i--) { >> + if (!cc->cpages[i]) >> + continue; >> + fscrypt_finalize_bounce_page(&cc->cpages[i]); >> + } > > Applied as: > > --- a/fs/f2fs/compress.c > +++ b/fs/f2fs/compress.c > @@ -1455,6 +1455,9 @@ static int f2fs_write_compressed_pages(struct compress_ctx *cc, > out_destroy_crypt: > page_array_free(sbi, cic->rpages, cc->cluster_size); > > + if (!fio.encrypted) > + goto out_put_cic; Looks fine to me. Thanks, > + > for (--i; i >= 0; i--) { > if (!cc->cpages[i]) > continue; > > >> } >> out_put_cic: >> kmem_cache_free(cic_entry_slab, cic); >> -- >> 2.49.0 >> >> >> >> _______________________________________________ >> Linux-f2fs-devel mailing list >> Linux-f2fs-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel