From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F153A38E8B9 for ; Tue, 4 Aug 2026 09:32:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785835978; cv=none; b=NROJiO3mJ9WHRF5tsmfjg56fF904z6Hjwa3Td+vipC0k79w7vhR0wrutVabdfclII7db+pEozqGT+3IpFG+7qohD6Eie60+m4F49xtAUOtF77VCHN59YVO6OgaPy8VoizfZ/yFK48lIHsNB1KyF1c6A54Yf2xbe7PD963kfhFkg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785835978; c=relaxed/simple; bh=f6m+MjVluBwQOrBV+UlvyZlagmeScpeMJrIr2qlK2Gk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ODnSN5V+q5ellUpVJRbjbCaNl76wXCPFnk6UIDtVuamoeKrBoMcnquKtY8u3ZrgPuQ4+w+L6mm6QoIwBQJ+e1vNIJrYWjKdh50Coc30YY89BdGOLZUBTOrhXqLJJUDO1E2HCW5MCSmIbn6cenG8r4dwYYkp+IIrv9i5dHlu60do= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TniK7qS1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CLQu6Iqu; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TniK7qS1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CLQu6Iqu" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6748CGvT3034428 for ; Tue, 4 Aug 2026 09:32:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= f0/ffgDEcjjXA9y0j+W4lkEJvU8/s6OfIKNmngJqTvs=; b=TniK7qS161cDijBC +/VsFiCX/QIww927cY52Dv75rOR1qRhJzyTDwy7gno2ZfC4OEF0sGTyiiwPv8gw0 wV00fR1DMdeXah0RYGvbzLcTk5JID82MR09mpkqkGPxzwrDWzbWqVcWWv6IgnxGC R+wLXrD1GlgqIBwEAgUD7YiJAMBZfdNDewPYcPEwwsVS9QOySSr+JjPWkxNAwLog bXIoahS9Nlwb4FG0TTjvb8Z9aF/1jwwPb+/wJ/lj/bwVKJQ0ug2CAKOrBLzZlEcl pz/FASWVtVn6hGvpfcKr4m4Ioh8ArHIRcCUFgdOjTgOA3cqEz84ad3pH0PwZc1XX mzFFSQ== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fty3qkmrs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 04 Aug 2026 09:32:55 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-848860def2cso5243473b3a.2 for ; Tue, 04 Aug 2026 02:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785835975; x=1786440775; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=f0/ffgDEcjjXA9y0j+W4lkEJvU8/s6OfIKNmngJqTvs=; b=CLQu6IqubUhL0BtDm3Q+jMj8SuVGoufR+VefzjSwZiD6k+uQtYdcNVvniHDHD6CStn EQqZ9GJdtDf77zx4VNvwNTLwUyU7Xf5s4qVg1GIhzj8bbJ0QNhA3lKpM92l7hyWKy2pn TYvr8yTwa44lfeyJHhalTMVxz3uUHt93dEPaH1QFzY4stCBlIWMFg8zT7VcOT6IoaXgd 3G0qb4r5ZK3Y34f6t/CWRl+UgXT+AqHtP8ZsVOJm2yN5BfjcXSJyoJ5Q3INHUuCRsqET nBsc6YQuMGZS4Xp2nVNnROa++fNN5LbD3AfvSBGn/VD0c6Rxnkr7OzI7IaD2y+gNFxSO dmqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785835975; x=1786440775; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=f0/ffgDEcjjXA9y0j+W4lkEJvU8/s6OfIKNmngJqTvs=; b=jC+oYFLJzN5qYD4cEujcQ5YydKWR7MaNvPiZWGLm/DsCEzIHhyJQg6WVyUx7SJvsES hs6qHPI3n4/j1eO72h4mE27pDaJSWNOtUv5R0SntpbrRjpli/NkzgkJNNlkcqNhqq6HG 1qQVLEU/OYFro002KqRjBVyo/3QEvlTdk+p6yPHb4/e4RcAv+aZeaZV9Sot8KPjlGUdD A0pbphbMtwA3cY3keaUr088L0eZBMVH332zOZyBWQUBZjOZbtOuh89stKkNQbDT7RUYt m6wVS7CJzGcL562CcdZWuarWjuIwvnD4hjA3sZqt6vNC2tx41/O1Ezi0a244EzWetgWm uzzA== X-Forwarded-Encrypted: i=1; AHgh+Rq9RvPaIc7/dHDWHGlVxZgZ/9Ii9oKmaqgE9f/TujWveNXCbsEY/lL+U4FYyOlubFeZ40FCWY1sLxmkWkA=@vger.kernel.org X-Gm-Message-State: AOJu0YyGsJ3HeL+FqxAqTsPyKqPZZv92UmG9zhJSUKR8LjVb/mFhgsDj sUyUs6Wr+Z6GIk1UWCpQxtyVZ9qFVFoQjkDqg8R+2x1sTAqFs0OIlw6k68nD2LJ6R5HCLWU0MHq usKBs6ksnFb4a7yW9zWpYUqNkYSAFz4BMbzhQLeVdgzg1JW8LI5u7IjxgmT6YYYbKiJy0mEbnZW k= X-Gm-Gg: AR+sD12qtX6WsayDDm1FlzOVI7BwI1os+87wDrBpyG7irbhwA5xgGNdwj7QcXrPmX7I ZLUBgR5qd2kVo4iMr+qA8Fi3k4zA9bKQsotM6tzt/uFKSZ0NQ5B6s5bwdDdZm+MsFQ6/JNDdyPU 2vhY93gVzIQd1g+mHKPbLZ2laXJjScMDQyBJBPPza8k2T+aoxcy/N7BxIzWW2GqohhQEOIY+0a1 cRekcMUUja0Qr4FoGN7sVmFLLuuYyi0nDsA7JF60VEA5/Qa+NBvt3ecBTPT9+hr9ej7iPCGBLL0 tzixW2/U/yomtnN16xLIsBHx3qUKPwsvy9QcJhQd9JXoZo+tiuYUNh7btv7zAAHz+S3fEHtSw4O 62euS0Y8pfR6FHslhVhW6oVsa1h5H X-Received: by 2002:a05:6a00:12da:b0:847:5ec4:9a1d with SMTP id d2e1a72fcca58-84ee4995414mr11427143b3a.62.1785835975377; Tue, 04 Aug 2026 02:32:55 -0700 (PDT) X-Received: by 2002:a05:6a00:12da:b0:847:5ec4:9a1d with SMTP id d2e1a72fcca58-84ee4995414mr11427107b3a.62.1785835974964; Tue, 04 Aug 2026 02:32:54 -0700 (PDT) Received: from [10.219.1.122] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84edc2d45afsm4849189b3a.41.2026.08.04.02.32.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 02:32:54 -0700 (PDT) Message-ID: <59e76c3a-91ff-4fbb-936b-9a8464c60347@oss.qualcomm.com> Date: Tue, 4 Aug 2026 15:02:49 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] Bluetooth: qca: Allow capturing QCA debug logs in snoop logs To: Bartosz Golaszewski , Marcel Holtmann , Luiz Augusto von Dentz Cc: linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, quic_mohamull@quicinc.com, quic_hbandi@quicinc.com, rahul.samana@oss.qualcomm.com, harshitha.reddy@oss.qualcomm.com, yepuri.siddu@oss.qualcomm.com References: <20260804-qca_logs_enable-v2-1-587d584ef4c2@oss.qualcomm.com> Content-Language: en-US From: Dishank Garg In-Reply-To: <20260804-qca_logs_enable-v2-1-587d584ef4c2@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: Z2bklt4ZvhzOYM72ySCmfuPf-KsmawGd X-Proofpoint-ORIG-GUID: Z2bklt4ZvhzOYM72ySCmfuPf-KsmawGd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA0MDA3NSBTYWx0ZWRfX/Ym1hUUhPDXd gxIGxcc4KTmevDxK6M0Bp5ul1JUnErjnMVAiFotYLxg5/fZghqcIlmlm7XlMjqK7EH//bhoI+F2 QeE/p5BVAjsMMdLVOFC0GAN75dmsatiGScfTAjOh4+EfTQtk+9xT5ZyQg8HoKPwAllnz6Lb89m2 ViXM+Zt/LIy/6X2WsZYLUnPjsac8PggSKXdE09qrV7pnn0TdOI/xvIvHnjDjZ7t9ICnSJuZsl6z Ote4CNWh00QGW3Lf19hJsBJREaCyoKSsoOifruThrUxAsQFntC6yLGMjQ+uxELUT5M6ISuch/P6 q0ub8Rg6tppN5x85LU+CczW2c3HflONVZCbLADzo9uuH81Coe6BQKH9TT8L9BShWZlyUKcbayoD nkjtBxkKlpj3ePThMH1Dlw+c+IELTUWGIeqcgTUXGdC1mu5y2MXVtjdW8bARCAi7oxRMXJ105Up GkyrRbIslWiYopW8IYw== X-Proofpoint-Spam-Info: AW1haW4tMjYwODA0MDA3NSBTYWx0ZWRfX5vmi2FPpTbVi Fx5nM5Pz0m/qhviINpBEaaIcZWHpdVZTo985LCLusl865cnu9zNOuq2N3wfyMXSvMI8bhrlcbXX T15DS9/6+3V52x5Lo60MQMHv/xZCsto= X-Authority-Analysis: v=2.4 cv=ONEXGyaB c=1 sm=1 tr=0 ts=6a71b1c8 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=bC-a23v3AAAA:8 a=EUspDBNiAAAA:8 a=8xjHuzqBk6beOtrGZs0A:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 a=FO4_E8m0qiDe52t0p3_H:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-04_02,2026-08-03_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 bulkscore=0 spamscore=0 malwarescore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608040075 On 8/4/2026 10:47 AM, Dishank Garg wrote: > Add a debugfs flag to forward QCA diagnostic ACL packets as regular > ACL data, enabling their capture in Bluetooth snoop logs. > > Signed-off-by: Dishank Garg > --- > This series adds support for capturing QCA controller debug/diagnostic > logs in Bluetooth snoop logs. Currently, ACL packets carrying QCA > diagnostic data are intercepted and routed to the diagnostic layer via > hci_recv_diag(), which means they never show up in snoop captures. > This makes it hard to correlate QCA debug logs with the surrounding > HCI/ACL traffic when debugging issues, since the two have to be > captured and aligned separately. > > The series adds a new debugfs knob, diag_as_acl, under the hci_qca > debugfs directory. When enabled, diagnostic ACL packets are forwarded > through the normal ACL receive path instead of being diverted to the > diagnostic layer, so they get captured in the standard Bluetooth snoop > log alongside all other traffic. > --- > Changes in v2: > - EDITME: describe what is new in this series revision. > - EDITME: use bulletpoints and terse descriptions. > - Link to v1: https://patch.msgid.link/20260804-qca_logs_enable-v1-1-4e209447da0e@oss.qualcomm.com > --- > drivers/bluetooth/hci_qca.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c > index 1222f97800f4..6996966319e8 100644 > --- a/drivers/bluetooth/hci_qca.c > +++ b/drivers/bluetooth/hci_qca.c > @@ -182,6 +182,7 @@ struct qca_data { > u64 rx_votes_on; > u64 tx_votes_off; > u64 rx_votes_off; > + bool diag_as_acl; > u64 votes_on; > u64 votes_off; > }; > @@ -698,6 +699,7 @@ static void qca_debugfs_init(struct hci_dev *hdev) > debugfs_create_u32("wake_retrans", mode, ibs_dir, &qca->wake_retrans); > debugfs_create_u32("tx_idle_delay", mode, ibs_dir, > &qca->tx_idle_delay); > + debugfs_create_bool("diag_as_acl", 0644, hdev->debugfs, &qca->diag_as_acl); > } > > /* Flush protocol data */ > @@ -998,12 +1000,14 @@ static int qca_ibs_wake_ack(struct hci_dev *hdev, struct sk_buff *skb) > > static int qca_recv_acl_data(struct hci_dev *hdev, struct sk_buff *skb) > { > + struct hci_uart *hu = hci_get_drvdata(hdev); > + struct qca_data *qca = hu->priv; > /* We receive debug logs from chip as an ACL packets. > * Instead of sending the data to ACL to decode the > * received data, we are pushing them to the above layers > * as a diagnostic packet. > */ > - if (get_unaligned_le16(skb->data) == QCA_DEBUG_HANDLE) > + if (!READ_ONCE(qca->diag_as_acl) && get_unaligned_le16(skb->data) == QCA_DEBUG_HANDLE) > return hci_recv_diag(hdev, skb); > > return hci_recv_frame(hdev, skb); > > --- > base-commit: f5a7e2ae5f0a9a5caf59501457938eeb249a7dc8 > change-id: 20260803-qca_logs_enable-9b8197aaac09 > > Best regards, > -- > Dishank Garg Apologies for the confusion - the "v1" of this patch was sent as a test email to myself only, before I had added the actual To/Cc recipients. When I then sent it to the correct list with the full recipient list, b4 auto-incremented it to "v2". There were no changes to the patch content between the two - please disregard the v1 test mail and treat this v2 as the first real submission for review. I'll continue versioning normally (v2, v3, ...) from here if further changes are needed. Best regards, Dishank Garg