From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EF06C25B46 for ; Mon, 23 Oct 2023 17:06:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229929AbjJWRGQ (ORCPT ); Mon, 23 Oct 2023 13:06:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229938AbjJWRGN (ORCPT ); Mon, 23 Oct 2023 13:06:13 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7155510B for ; Mon, 23 Oct 2023 10:06:10 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5406c099cebso1450212a12.2 for ; Mon, 23 Oct 2023 10:06:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698080769; x=1698685569; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iuNkS1vd+Zd+VrcX8suE2Jf1b7hw/+wRSPSlfEzUIRc=; b=EPJ6Bwje+EtuUbXyyWbD6oblprYcPa2jUebzfivtS9+1Ts5Hgkh1TL0vcOMyqcObbP sX3t/AUc1fv7MuqOGrvamzCQGBK1OW3JjqpFg6W4adyqg0ej8mhmJLb5vYJ564zgJkQO jQFFodpJvmAV9P+gU6yu1lYb4spixu/RIQcfXxhzaPRlIQr9JQ72gtS3Gtou1krK82QU bzXZsrkH/JpQCspwkezitqsI6VoDQWppqxVR+ys0vOC3kDJWWXuWyph2AZ4INaCW9RmH zmVbfK/zwb9CRBEe4DXOlST4lYhIcN2bjcYVpuByjHCtohVLGVl9PTUe92IOlgZ8cqcD gwTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698080769; x=1698685569; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iuNkS1vd+Zd+VrcX8suE2Jf1b7hw/+wRSPSlfEzUIRc=; b=aecPGtl+KIUx15HHqRYut3vP3fYT14lnJwH0Hf7wMox3457hA2xycukTqdZQnEdSQn BqNf9HDZwkEIcEVRchr3Ur4a+5XenMoR7qHTEXK2wdEX4OBxQO5pTVjvFE3ybhS/lVJ5 o/NlZzuVALlb+/zBf6rzHVhzc2MmDUUFRm4XkxnRbqBHxYntBnQSfFN/N6LyGjnkOtUF k7Cc9G57mSVXHdkhcRcvhbwzcHdmULiV2jB+PFk/bh8qLp7nl6G9qAZbU1XQTuFXl0N2 0awIp4N7EMAGIxcYW+CIKUQzB2M6JOq8F7o/NdfUyw2sHVvJi1+3aKRsOWZaHeEciCUw LV2g== X-Gm-Message-State: AOJu0Yx3VhDGQpifRd7ya7+Qs1lbL2r3FQPsj/aFhJTg2E/n7/U6Dz18 M+6NshTtdAEuTMvHotVhayLxRw== X-Google-Smtp-Source: AGHT+IFg/unW3xdDh9FUgZuDg3qWnEitzvQlsARDu5ZM7VumYoliIbM/vxMYxdiwQ73lhD+0x6V46g== X-Received: by 2002:a17:907:7b9f:b0:9bf:8073:a922 with SMTP id ne31-20020a1709077b9f00b009bf8073a922mr8850355ejc.19.1698080768812; Mon, 23 Oct 2023 10:06:08 -0700 (PDT) Received: from [192.168.198.23] ([37.166.25.68]) by smtp.googlemail.com with ESMTPSA id y19-20020a1709060a9300b0098d2d219649sm7021536ejf.174.2023.10.23.10.06.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Oct 2023 10:06:08 -0700 (PDT) Message-ID: <59ea8714-2ed8-f64b-e8d4-93cd6bf4ff92@linaro.org> Date: Mon, 23 Oct 2023 19:06:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v4 03/18] PM: EM: Find first CPU online while updating OPP efficiency Content-Language: en-US To: Lukasz Luba , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rafael@kernel.org Cc: dietmar.eggemann@arm.com, rui.zhang@intel.com, amit.kucheria@verdurent.com, amit.kachhap@gmail.com, viresh.kumar@linaro.org, len.brown@intel.com, pavel@ucw.cz, mhiramat@kernel.org, qyousef@layalina.io, wvw@google.com References: <20230925081139.1305766-1-lukasz.luba@arm.com> <20230925081139.1305766-4-lukasz.luba@arm.com> From: Daniel Lezcano In-Reply-To: <20230925081139.1305766-4-lukasz.luba@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lukasz, On 25/09/2023 10:11, Lukasz Luba wrote: > The Energy Model might be updated at runtime and the energy efficiency > for each OPP may change. Thus, there is a need to update also the > cpufreq framework and make it aligned to the new values. In order to > do that, use a first online CPU from the Performance Domain. I'm failing to do the connection with the description and the change. Perhaps, the changelog shall explain why 'cpu' must be replaced with the first active cpu ? > Signed-off-by: Lukasz Luba > --- > kernel/power/energy_model.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c > index 42486674b834..3dafdd7731c4 100644 > --- a/kernel/power/energy_model.c > +++ b/kernel/power/energy_model.c > @@ -243,12 +243,19 @@ em_cpufreq_update_efficiencies(struct device *dev, struct em_perf_state *table) > struct em_perf_domain *pd = dev->em_pd; > struct cpufreq_policy *policy; > int found = 0; > - int i; > + int i, cpu; > > if (!_is_cpu_device(dev) || !pd) > return; > > - policy = cpufreq_cpu_get(cpumask_first(em_span_cpus(pd))); > + /* Try to get a CPU which is online and in this PD */ > + cpu = cpumask_first_and(em_span_cpus(pd), cpu_active_mask); > + if (cpu >= nr_cpu_ids) { > + dev_warn(dev, "EM: No online CPU for CPUFreq policy\n"); > + return; > + } > + > + policy = cpufreq_cpu_get(cpu); > if (!policy) { > dev_warn(dev, "EM: Access to CPUFreq policy failed\n"); > return; -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog