From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22B2F28FFF6 for ; Sun, 29 Mar 2026 09:18:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774775899; cv=none; b=C2fqhMIOlQbXW9se8DzMLY0xUN7/NcfAsn26FSgTYuGlyMmne9zqqYkjcTQ9BHVfTf+pVbsz+/aIvYpULh0DP9V6fS0AmFb5taJXA2moftlcYWjGy3xZkwLMkDkF8FWhvkJ+SOnUP+KnNJ+KouDSF+LR5VVwU1vYEE1wE9+pCkI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774775899; c=relaxed/simple; bh=KwQZsStmoPJ1NXGH/e4IHtbfV5W3jRP6vwY4TFNBQjk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Tj8FN6ROSMm2ohN8wITzknnqb071LXSMhCLaWQUqj0SMAuIUX4wKjAZnW4xdYXCuaxr5rRkC4Aj7bOmAJq0qC++YjwHg1MNluagFpvAP47WdOwbuper+G/htqA1TOWJyQ2A1885F+dmIH54LBWBso5dJd5prqRKHOWlKWnccg4E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=KkExcN9G; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="KkExcN9G" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62T4MFqB2390841; Sun, 29 Mar 2026 09:18:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=UsQXxP bm87yDctm8J27Q+AHlezFNkvrBWesRo6sfR8w=; b=KkExcN9GaGz1AVBq7onA7Z EisnCJI7nfgilABmDfPh2F2clOCyUkWHv3CdJe7bdvGrG5fESyG6dBZzmilKeXY8 sa470Od3sXhBtnD++Edx1M1KGzSsricbX2gcd2gx0DzYhqB7BiN/g6b7QeiYnyQS gbuw7A7KU6jg9AcpV4HDfEFatMYyNpUasG2cElZ6fF8Y+oIVRLM2A7MFbZhEN35V BCSyiLJwTa697xxwG0x2uvHO/zsmMuXt6TgQvJRnvCkG0m1nqGNrK+eYVlAZR+DD aslg0fPwVphp166HpiiPO7UaKrBLd6KSW1V64f34qbcylzQ8gtpcdFNwm+tylRcg == Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d64dgb59j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 29 Mar 2026 09:18:07 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 62T83CjM005910; Sun, 29 Mar 2026 09:18:07 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4d6spxs10f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 29 Mar 2026 09:18:07 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 62T9I5sS56426990 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 29 Mar 2026 09:18:05 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 39B8120043; Sun, 29 Mar 2026 09:18:05 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DC14620040; Sun, 29 Mar 2026 09:18:03 +0000 (GMT) Received: from [9.124.221.218] (unknown [9.124.221.218]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Sun, 29 Mar 2026 09:18:03 +0000 (GMT) Message-ID: <59fc5aaf-6704-40f2-82bf-a2e6c7fa35ad@linux.ibm.com> Date: Sun, 29 Mar 2026 14:48:03 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] powerpc: Use cpumask_next_wrap instead To: Yury Norov Cc: maddy@linux.ibm.com, linuxppc-dev@lists.ozlabs.org, yury.norov@gmail.com, linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org, chleroy@kernel.org References: <20260327063129.127302-1-sshegde@linux.ibm.com> <20260327063129.127302-2-sshegde@linux.ibm.com> From: Shrikanth Hegde Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI5MDA3MSBTYWx0ZWRfXzCsqQOLFvtu0 r0WzUeFTlJH3pTS+hUPkUsva6syZGts8r/ZH6iCBwGDJsOtDFFTQ7HGzeRl6bDWJQ/wPk259tsL I2UarEPToWdtSSUIY/n7yKFdz6BILFke08xSc/qo4gyBtqScgZf40U1z11UFojrkrZ0SFy7WQbv 8RpByiivue6vGHIyUj8ufIuxi9SUhgkpInDf1w0SvP2eY6oWzoeqOzW3wGdWg7rRb13qJ6cVyWz EJjQwjCbypfmxJRcV0XuVbZi0AWf+DWa8C0zhTUlKZVI8y1q09A9YXMtsfbFGScYOm1GgGBirkp 8gVjc76vyLkUgxtLqrsZCxF9zy6LSVROKwNhlrTz5uoLh5DkL6Y7ug/j6OexgQDiap/QKJsFkXY 0YFwSJRIfoaRoOl5PT8AV+Pcs4olfGQePWglr9zs0yHHFda/BfGmDpy7Dc/c+IMdP7IFFZm5wmJ 4e6uNEZyPuZiijUkqpg== X-Authority-Analysis: v=2.4 cv=QKZlhwLL c=1 sm=1 tr=0 ts=69c8ee50 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VnNF1IyMAAAA:8 a=pGLkceISAAAA:8 a=A5xHZKZMv6EtbT0R9gcA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: 1f4AHuaSFWTL8hz0xvLHcwo4humqSzY4 X-Proofpoint-ORIG-GUID: bBM-3Q_wq_uDtBem9KGrAKBbnCve79tu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_02,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 adultscore=0 impostorscore=0 clxscore=1015 spamscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603290071 Hi Yury. On 3/29/26 2:14 AM, Yury Norov wrote: > On Fri, Mar 27, 2026 at 12:01:28PM +0530, Shrikanth Hegde wrote: >> cpu = cpumask_next(cpu, mask) >> if (cpu >= nr_cpu_ids) >> cpu = cpumask_first(mask) >> >> Above block is identical to: >> cpu = cpumask_next_wrap(cpu, mask) >> >> Replace it, No change in functionality or performance. >> Slightly simpler code. >> >> Signed-off-by: Shrikanth Hegde >> --- >> arch/powerpc/kernel/irq.c | 5 +---- >> arch/powerpc/mm/book3s64/hash_utils.c | 4 +--- >> arch/powerpc/sysdev/xive/common.c | 5 +---- >> 3 files changed, 3 insertions(+), 11 deletions(-) >> >> diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c >> index a0e8b998c9b5..f69de08ad347 100644 >> --- a/arch/powerpc/kernel/irq.c >> +++ b/arch/powerpc/kernel/irq.c >> @@ -370,10 +370,7 @@ int irq_choose_cpu(const struct cpumask *mask) >> do_round_robin: >> raw_spin_lock_irqsave(&irq_rover_lock, flags); >> >> - irq_rover = cpumask_next(irq_rover, cpu_online_mask); >> - if (irq_rover >= nr_cpu_ids) >> - irq_rover = cpumask_first(cpu_online_mask); >> - >> + irq_rover = cpumask_next_wrap(irq_rover, cpu_online_mask); >> cpuid = irq_rover; >> >> raw_spin_unlock_irqrestore(&irq_rover_lock, flags); >> diff --git a/arch/powerpc/mm/book3s64/hash_utils.c b/arch/powerpc/mm/book3s64/hash_utils.c >> index 9dc5889d6ecb..e4fcf929cb33 100644 >> --- a/arch/powerpc/mm/book3s64/hash_utils.c >> +++ b/arch/powerpc/mm/book3s64/hash_utils.c >> @@ -1299,9 +1299,7 @@ static void stress_hpt_timer_fn(struct timer_list *timer) >> if (!firmware_has_feature(FW_FEATURE_LPAR)) >> tlbiel_all(); >> >> - next_cpu = cpumask_next(raw_smp_processor_id(), cpu_online_mask); >> - if (next_cpu >= nr_cpu_ids) >> - next_cpu = cpumask_first(cpu_online_mask); >> + next_cpu = cpumask_next_wrap(raw_smp_processor_id(), cpu_online_mask); >> stress_hpt_timer.expires = jiffies + msecs_to_jiffies(10); >> add_timer_on(&stress_hpt_timer, next_cpu); >> } >> diff --git a/arch/powerpc/sysdev/xive/common.c b/arch/powerpc/sysdev/xive/common.c >> index e1a4f8a97393..b6446abe29a6 100644 >> --- a/arch/powerpc/sysdev/xive/common.c >> +++ b/arch/powerpc/sysdev/xive/common.c >> @@ -577,10 +577,7 @@ static int xive_find_target_in_mask(const struct cpumask *mask, >> */ >> if (cpu_online(cpu) && xive_try_pick_target(cpu)) >> return cpu; >> - cpu = cpumask_next(cpu, mask); >> - /* Wrap around */ >> - if (cpu >= nr_cpu_ids) >> - cpu = cpumask_first(mask); >> + cpu = cpumask_next_wrap(cpu, mask); > > Again, for all except this: > > Reviewed-by: Yury Norov > Thanks for the review. > > Can you move my series for xive_find_target_in_mask() together with > your patches? Sure. I can add your patch to this series and send it. PS: Sorry, I hadn't seen your series.