From: "Jan Beulich" <JBeulich@suse.com>
To: "Ingo Molnar" <mingo@kernel.org>
Cc: <mingo@elte.hu>, <tglx@linutronix.de>,
"xen-devel" <xen-devel@lists.xenproject.org>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"Juergen Gross" <jgross@suse.com>, <sds@tycho.nsa.gov>,
<linux-kernel@vger.kernel.org>, <hpa@zytor.com>
Subject: Re: [PATCH 1/2] x86: consider effective protection attributes in W+X check
Date: Tue, 12 Dec 2017 03:43:56 -0700 [thread overview]
Message-ID: <5A2FC0FC0200007800196BA4@prv-mh.provo.novell.com> (raw)
In-Reply-To: <20171212103640.qcpyj7wxuimfkvjp@gmail.com>
>>> On 12.12.17 at 11:36, <mingo@kernel.org> wrote:
> * Jan Beulich <JBeulich@suse.com> wrote:
>
>> Using just the leaf page table entry flags would cause a false warning
>> in case _PAGE_RW is clear or _PAGE_NX is set in a higher level entry.
>
> Good find - I assume this bug can cause both false positives and false
> negatives
> as well, right?
Yes, albeit I'm not aware of any outside of Xen (with that other patch
applied).
Jan
next prev parent reply other threads:[~2017-12-12 10:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 10:24 [PATCH 0/2] x86: deal with remaining W+X pages on Xen Jan Beulich
2017-12-12 10:31 ` [PATCH 1/2] x86: consider effective protection attributes in W+X check Jan Beulich
2017-12-12 10:36 ` Ingo Molnar
2017-12-12 10:43 ` Jan Beulich [this message]
2017-12-12 10:32 ` [PATCH 2/2] x86-64/Xen: eliminate W+X mappings Jan Beulich
2017-12-12 10:38 ` Ingo Molnar
2017-12-12 10:48 ` Jan Beulich
2017-12-12 10:54 ` Ingo Molnar
[not found] ` <5A2FC2280200007800196BB8@suse.com>
2017-12-12 13:14 ` Juergen Gross
2017-12-18 11:11 ` [PATCH v2] " Jan Beulich
2017-12-18 12:28 ` Ingo Molnar
2017-12-18 15:52 ` Joe Perches
2017-12-18 16:37 ` [PATCH v3] " Jan Beulich
[not found] ` <5A2FBE0A0200007800196B4F@suse.com>
2017-12-14 14:04 ` [PATCH 1/2] x86: consider effective protection attributes in W+X check Juergen Gross
2017-12-14 14:12 ` Thomas Gleixner
2017-12-14 14:15 ` Jan Beulich
2017-12-14 14:17 ` Thomas Gleixner
2017-12-14 14:21 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A2FC0FC0200007800196BA4@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=tglx@linutronix.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®