From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754547AbdLTJO4 (ORCPT ); Wed, 20 Dec 2017 04:14:56 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:23808 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751801AbdLTJOw (ORCPT ); Wed, 20 Dec 2017 04:14:52 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20171220091449epoutp01875fd265d712430b2d2000b6c604bcdd~B9d9ncOc60166001660epoutp01f X-AuditID: b6c32a36-3d5ff7000000117d-11-5a3a2a089c82 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="UTF-8" Message-id: <5A3A2A0C.8040601@samsung.com> Date: Wed, 20 Dec 2017 18:14:52 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: s.nawrocki@samsung.com, tomasz.figa@gmail.com Cc: kgene@kernel.org, krzk@kernel.org, mturquette@baylibre.com, sboyd@codeaurora.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: samsung: s3c: Remove unneeded enumeration In-reply-to: <1511749908-29777-1-git-send-email-cw00.choi@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA01SfUgTcRjmt9tup7Q6V9Yvi1pHURku73R6mgtD04P8w4g+MMIuPVR0H+02 sywqrNTl/KAgnfZhWZEFxtTS7INMKyK0NKdGrUBMS0tMLAPT7nZE/fe8D8/78D4PL4aoS9EA LMNo5SxGNotAfeV3nqzVBmGBkUnBDvc6umRgBKE7O28radeAW0GPF3kUdPe9KpQu73woo1+/ 2Ew/Gc1X0FMvT8vp2nvTINqXGes7qWS6ix0yptn5Xsm4agtRpr7mKFPcUAuYCdeyRGUSF5XO samcRcMZU0ypGcY0PbFlW3JMsi4smAwiI+hwQmNkDZyeiE1IDIrLyBKuIzTZbJZNoBJZnifW b4yymGxWTpNu4q16YjdJUloyOFxLUZQ2NGRPJKUTJHu59F89D+TmaSKnfeQ6OAZuL7UDDIN4 KJyt97EDX0yNNwH4qOG5zA58hOEngB+rDohY1LzqL5RLfAuAN12ZIlbhfnDqjEcu+iD4ctjW 5aURfC1sbKlTSp4eALtbhlBJHwi/3mhSiliOr4LuvEteT1TgHw33eTXz8BWwZ2oAiNgf3wWb L/5Qiv4LcBL2txKiJ4K/A7CuohsRNfPxGFhe5PDe7IPHwe/fuoAogvgECj9dO49IAWLhZN4J VMLz4ZdnDUop/BLY1a6X9PkA5j+4gEjDWQA7ej0yaSEEfqq2y6Roc+G3ySKFtKyCBafUkoSB /eOzcglvgva2GYWUvgLAmscFslKwzPlfYc5/hTn/K+wSQGrBQs7MG9I4njRTWp418DZjmjbF ZHAB7zcGhjWByx0JrQDHADFHpdFGJKkVbDZ/0NAKIIYQC1S5EwKlSmUPHuIspmSLLYvjW4FO 6LsMCfBPMQm/bbQmk6ERwaFhlPBcESRJLFL517l3qfE01splcpyZs/zdk2E+AcdAzJuVvxXD Tyev3m9E6xrbqvOoVzlloxOrxwa1qT3O0f5DO/b9QGbujuW+bXeMtwxZVurDS9Q54b1Duo44 162QK1/gy8+nPNvZuUeax/Yfpmpm3CmLZzMTNpwlgvoGmfgLa3ZWRldWn9t+bWtkPPphodmf sh2v35PjqBx+rKEK9vkRcj6dJQMRC8/+AYS44vajAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCLMWRmVeSWpSXmKPExsVy+t9jAV0OLasog+c/RSz6H79mtjh/fgO7 xabH11gtPvbcY7W4vGsOm8WM8/uYLC6ecrU4/Kad1eLHmW4Wi1W7/jA6cHm8v9HK7nG5r5fJ Y+esu+wem1Z1snlsXlLv0bdlFaPH501yAexRXDYpqTmZZalF+nYJXBk/r+5lKfijVHH09XLG BsYNMl2MnBwSAiYSF252snQxcnEICexklPj06xwjSIJXQFDix+R7QAkODmYBeYkjl7JBwswC 6hKT5i1ihqh/wCjxrPkiC0S9lsTblTvYQWwWAVWJa80LwOJsQPH9L26wgdj8AooSV388ZgSZ KSoQIdF9ohLEFBEwlLh5SAlkJLPAHUaJlbvOg40RFnCWmNHTywRiCwnMZpR4DVLEycEp4Cbx 6d0lxgmMArOQXDoL4dJZSC5dwMi8ilEytaA4Nz232KjAMC+1XK84Mbe4NC9dLzk/dxMjMC62 Hdbq28F4f0n8IUYBDkYlHl4FPcsoIdbEsuLK3EOMEhzMSiK81Z+BQrwpiZVVqUX58UWlOanF hxilOViUxHlv5x2LFBJITyxJzU5NLUgtgskycXBKNTDmhs4TD3DKDJRQUeV8ed/5+uJz/Pfe vhT+amlgu95n57bA9LYFfktZPK4WFdic16+dzStzPeynuROXic9pH7bsX/u/bI73M87ZvnJC HscfxplxVnvlj729avv6c46b3uTp6pernr5ZWsv/0Hd23guTj7/i5djinwW3Cgn98ihpDD7H feBk/kQlluKMREMt5qLiRAA3/BZ+hwIAAA== X-CMS-MailID: 20171220091448epcas1p1065100c89f23ce9aa81fcf8382710d5a X-Msg-Generator: CA CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171127023145epcas1p1b97c3c66ce624f5362c8d9bf74997c7f X-RootMTR: 20171127023145epcas1p1b97c3c66ce624f5362c8d9bf74997c7f References: <1511749908-29777-1-git-send-email-cw00.choi@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Sylwester, Gently Ping. Regards, Chanwoo Choi On 2017년 11월 27일 11:31, Chanwoo Choi wrote: > This patch just removes the unneeded enumeration for PLL index. > > Signed-off-by: Chanwoo Choi > --- > drivers/clk/samsung/clk-s3c2412.c | 11 ++--------- > drivers/clk/samsung/clk-s3c2443.c | 17 ++++------------- > drivers/clk/samsung/clk-s3c64xx.c | 17 ++++++----------- > 3 files changed, 12 insertions(+), 33 deletions(-) > > diff --git a/drivers/clk/samsung/clk-s3c2412.c b/drivers/clk/samsung/clk-s3c2412.c > index b8340a49921b..1555e407529e 100644 > --- a/drivers/clk/samsung/clk-s3c2412.c > +++ b/drivers/clk/samsung/clk-s3c2412.c > @@ -27,11 +27,6 @@ > #define CLKSRC 0x1c > #define SWRST 0x30 > > -/* list of PLLs to be registered */ > -enum s3c2412_plls { > - mpll, upll, > -}; > - > static void __iomem *reg_base; > > #ifdef CONFIG_PM_SLEEP > @@ -144,10 +139,8 @@ struct samsung_mux_clock s3c2412_muxes[] __initdata = { > }; > > static struct samsung_pll_clock s3c2412_plls[] __initdata = { > - [mpll] = PLL(pll_s3c2440_mpll, MPLL, "mpll", "xti", > - LOCKTIME, MPLLCON, NULL), > - [upll] = PLL(pll_s3c2410_upll, UPLL, "upll", "urefclk", > - LOCKTIME, UPLLCON, NULL), > + PLL(pll_s3c2440_mpll, MPLL, "mpll", "xti", LOCKTIME, MPLLCON, NULL), > + PLL(pll_s3c2410_upll, UPLL, "upll", "urefclk", LOCKTIME, UPLLCON, NULL), > }; > > struct samsung_gate_clock s3c2412_gates[] __initdata = { > diff --git a/drivers/clk/samsung/clk-s3c2443.c b/drivers/clk/samsung/clk-s3c2443.c > index d94b85a42356..9580a6baf4d7 100644 > --- a/drivers/clk/samsung/clk-s3c2443.c > +++ b/drivers/clk/samsung/clk-s3c2443.c > @@ -41,11 +41,6 @@ enum supported_socs { > S3C2450, > }; > > -/* list of PLLs to be registered */ > -enum s3c2443_plls { > - mpll, epll, > -}; > - > static void __iomem *reg_base; > > #ifdef CONFIG_PM_SLEEP > @@ -225,10 +220,8 @@ struct samsung_clock_alias s3c2443_common_aliases[] __initdata = { > /* S3C2416 specific clocks */ > > static struct samsung_pll_clock s3c2416_pll_clks[] __initdata = { > - [mpll] = PLL(pll_6552_s3c2416, MPLL, "mpll", "mpllref", > - LOCKCON0, MPLLCON, NULL), > - [epll] = PLL(pll_6553, EPLL, "epll", "epllref", > - LOCKCON1, EPLLCON, NULL), > + PLL(pll_6552_s3c2416, MPLL, "mpll", "mpllref", LOCKCON0, MPLLCON, NULL), > + PLL(pll_6553, EPLL, "epll", "epllref", LOCKCON1, EPLLCON, NULL), > }; > > PNAME(s3c2416_hsmmc0_p) = { "sclk_hsmmc0", "sclk_hsmmcext" }; > @@ -279,10 +272,8 @@ struct samsung_clock_alias s3c2416_aliases[] __initdata = { > /* S3C2443 specific clocks */ > > static struct samsung_pll_clock s3c2443_pll_clks[] __initdata = { > - [mpll] = PLL(pll_3000, MPLL, "mpll", "mpllref", > - LOCKCON0, MPLLCON, NULL), > - [epll] = PLL(pll_2126, EPLL, "epll", "epllref", > - LOCKCON1, EPLLCON, NULL), > + PLL(pll_3000, MPLL, "mpll", "mpllref", LOCKCON0, MPLLCON, NULL), > + PLL(pll_2126, EPLL, "epll", "epllref", LOCKCON1, EPLLCON, NULL), > }; > > static struct clk_div_table armdiv_s3c2443_d[] = { > diff --git a/drivers/clk/samsung/clk-s3c64xx.c b/drivers/clk/samsung/clk-s3c64xx.c > index 7306867a0ab8..6db01cf5ab83 100644 > --- a/drivers/clk/samsung/clk-s3c64xx.c > +++ b/drivers/clk/samsung/clk-s3c64xx.c > @@ -56,11 +56,6 @@ > #define GATE_ON(_id, cname, pname, o, b) \ > GATE(_id, cname, pname, o, b, CLK_IGNORE_UNUSED, 0) > > -/* list of PLLs to be registered */ > -enum s3c64xx_plls { > - apll, mpll, epll, > -}; > - > static void __iomem *reg_base; > static bool is_s3c6400; > > @@ -364,12 +359,12 @@ static void __init s3c64xx_clk_sleep_init(void) {} > > /* List of PLL clocks. */ > static struct samsung_pll_clock s3c64xx_pll_clks[] __initdata = { > - [apll] = PLL(pll_6552, FOUT_APLL, "fout_apll", "fin_pll", > - APLL_LOCK, APLL_CON, NULL), > - [mpll] = PLL(pll_6552, FOUT_MPLL, "fout_mpll", "fin_pll", > - MPLL_LOCK, MPLL_CON, NULL), > - [epll] = PLL(pll_6553, FOUT_EPLL, "fout_epll", "fin_pll", > - EPLL_LOCK, EPLL_CON0, NULL), > + PLL(pll_6552, FOUT_APLL, "fout_apll", "fin_pll", > + APLL_LOCK, APLL_CON, NULL), > + PLL(pll_6552, FOUT_MPLL, "fout_mpll", "fin_pll", > + MPLL_LOCK, MPLL_CON, NULL), > + PLL(pll_6553, FOUT_EPLL, "fout_epll", "fin_pll", > + EPLL_LOCK, EPLL_CON0, NULL), > }; > > /* Aliases for common s3c64xx clocks. */ >