mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nadav Amit <namit@vmware.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Julien Freche <jfreche@vmware.com>,
	Pv-drivers <Pv-drivers@vmware.com>, Arnd Bergmann <arnd@arndb.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vmw_ballon: no need to check return value of debugfs_create functions
Date: Tue, 11 Jun 2019 19:36:36 +0000	[thread overview]
Message-ID: <5A5203EB-A789-4C48-9C25-EF0C0CBCE5CD@vmware.com> (raw)
In-Reply-To: <20190611185528.GA4659@kroah.com>

Please change the title of the patch to “vmw_balloon” (it is currently
“vmw_ballon”).

> On Jun 11, 2019, at 11:55 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.

I remember I saw a discussion about it, and didn’t know the resolution.

If that's the decision (assuming debugfs initialization always succeeds),
and after fixing the title of the patch:

  Acked-by: Nadav Amit <namit@vmware.com>

Thanks!
Nadav

  reply	other threads:[~2019-06-11 19:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-11 18:55 Greg Kroah-Hartman
2019-06-11 19:36 ` Nadav Amit [this message]
2019-06-12 11:35   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A5203EB-A789-4C48-9C25-EF0C0CBCE5CD@vmware.com \
    --to=namit@vmware.com \
    --cc=Pv-drivers@vmware.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jfreche@vmware.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®