From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752621AbeBZKy3 convert rfc822-to-8bit (ORCPT ); Mon, 26 Feb 2018 05:54:29 -0500 Received: from prv-mh.provo.novell.com ([137.65.248.74]:47374 "EHLO prv-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752457AbeBZKy1 (ORCPT ); Mon, 26 Feb 2018 05:54:27 -0500 Message-Id: <5A93F56E02000078001ABA78@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 18.0.0 Date: Mon, 26 Feb 2018 03:54:22 -0700 From: "Jan Beulich" To: "Andrey Ryabinin" Cc: , , , , , , , , , , , , "Juergen Gross" , , , Subject: Re: [tip:x86/mm] x86/mm: Consider effective protection attributes in W+X check References: <5A8FDE8902000078001AABBB@prv-mh.provo.novell.com> <5A93EABD02000078001AB9EC@prv-mh.provo.novell.com> <702b0f08-57a6-0ee0-d2e1-1310c00351e6@virtuozzo.com> In-Reply-To: <702b0f08-57a6-0ee0-d2e1-1310c00351e6@virtuozzo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> On 26.02.18 at 11:47, wrote: > > On 02/26/2018 01:08 PM, Jan Beulich wrote: >>>>> On 26.02.18 at 11:00, wrote: >>> On 02/26/2018 11:48 AM, tip-bot for Jan Beulich wrote: >>>> @@ -351,7 +362,7 @@ static inline bool kasan_page_table(struct seq_file *m, > struct pg_state *st, >>>> (pgtable_l5_enabled && __pa(pt) == __pa(kasan_zero_p4d)) || >>>> __pa(pt) == __pa(kasan_zero_pud)) { >>>> pgprotval_t prot = pte_flags(kasan_zero_pte[0]); >>>> - note_page(m, st, __pgprot(prot), 5); >>>> + note_page(m, st, __pgprot(prot), 0, 5); >>> >>> Isn't this disables W+X check for kasan page table? >>> Methinks it should be 'prot' here. >> >> Might well be - I actually did ask the question before sending v3, >> but didn't get any answer (yet). The kasan_zero_p?d names >> suggested to me that this is a shortcut for mappings which >> otherwise would be non-present anyway, but that was merely a >> guess. > > kasan_zero_p?? are used to map kasan_zero_page. That's it. Ah, thanks for explaining. >> As to W+X checks - I can't see how the result could be >> any better if the protections of kasan_zero_pte[0] would be >> used: Those can't possibly be applicable independent of VA. > > I'm not sure I understand what do you mean. > If we somehow screw up and accidentally make kasan_zero_pte writable and executable, > note_page() should report this. With your patch, it won't work. If this is a case to care about, simply passing "prot" won't be right though - the callers accumulated effective protections would then need passing in here, and merging with prot. Before I do this for a possible v4, I'd like to seek clarification though whether this really is a case to care about. Jan