From: JeffyChen <jeffy.chen@rock-chips.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
briannorris@google.com, "Heiko Stübner" <heiko@sntech.de>,
"Dmitry Torokhov" <dtor@google.com>,
"Douglas Anderson" <dianders@google.com>,
devicetree <devicetree@vger.kernel.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Joseph Lo" <josephl@nvidia.com>,
"stephen lu" <lumotuwe@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Kate Stewart" <kstewart@linuxfoundation.org>,
linux-input <linux-input@vger.kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Philippe Ombredanne" <pombredanne@nexb.com>,
"Arvind Yadav" <arvind.yadav.cs@gmail.com>
Subject: Re: [PATCH v4 1/3] Input: gpio-keys - add support for wakeup event action
Date: Thu, 08 Mar 2018 15:32:09 +0800 [thread overview]
Message-ID: <5AA0E6F9.6060704@rock-chips.com> (raw)
In-Reply-To: <CAHp75VcmbHbnD8FnTHXAqGajhs10wA7Z7U_D6SY9=j=y+GLLPA@mail.gmail.com>
Hi Andy,
Thanks for your reply.
On 03/07/2018 07:57 PM, Andy Shevchenko wrote:
> On Tue, Mar 6, 2018 at 9:44 AM, Jeffy Chen <jeffy.chen@rock-chips.com> wrote:
>> Add support for specifying event actions to trigger wakeup when using
>> the gpio-keys input device as a wakeup source.
>>
>> This would allow the device to configure when to wakeup the system. For
>> example a gpio-keys input device for pen insert, may only want to wakeup
>> the system when ejecting the pen.
>
>> + bool wakeup_enabled;
>
>> + if (bdata->wakeup_enabled) {
>
> This is redundant. IRQ core keeps track on this information already.
>
> Check below as an example
> aef3ad103a68 ("serial: core: remove unneeded irq_wake flag")
>
right, that make sense.
>
prev parent reply other threads:[~2018-03-08 7:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 7:44 [PATCH v4 0/3] gpio-keys: Add support for specifying " Jeffy Chen
2018-03-06 7:44 ` [PATCH v4 1/3] Input: gpio-keys - add support for " Jeffy Chen
2018-03-06 7:51 ` [PATCH v4 2/3] Input: gpio-keys - allow setting wakeup event action in DT Jeffy Chen
2018-03-06 7:51 ` [PATCH v4 3/3] arm64: dts: rockchip: kevin: Avoid wakeup when inserting the pen Jeffy Chen
2018-03-07 11:57 ` [PATCH v4 1/3] Input: gpio-keys - add support for wakeup event action Andy Shevchenko
2018-03-08 7:32 ` JeffyChen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5AA0E6F9.6060704@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=andy.shevchenko@gmail.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=briannorris@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dtor@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=josephl@nvidia.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lumotuwe@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pombredanne@nexb.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome